Skip to content

Commit 5957d54

Browse files
committed
Req changes from code review
1 parent 82919bb commit 5957d54

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

lib/schemaUtils.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2125,7 +2125,7 @@ module.exports = {
21252125
previewLanguage = this.resolveResponsePreviewLanguageAndResponseHeader(responseBodyWrapper,
21262126
responseHeaders, response);
21272127
// replace 'X' char with '0'
2128-
code = code.replace(/X/g, '0');
2128+
code = code.replace(/X|x/g, '0');
21292129
code = code === 'default' ? 500 : _.toSafeInteger(code);
21302130

21312131
sdkResponse = new sdk.Response({
@@ -2140,6 +2140,13 @@ module.exports = {
21402140
return sdkResponse;
21412141
},
21422142

2143+
/**
2144+
* Identifies the previewLanguage to use and also adds the identified content header to the responseHeaders array
2145+
* @param {object} responseBodyWrapper generated response body and its related information
2146+
* @param {object} responseHeaders - The existent array of response headers
2147+
* @param {object} response in operationItem responses
2148+
* @returns {string} previewLanguage
2149+
*/
21432150
resolveResponsePreviewLanguageAndResponseHeader: function (responseBodyWrapper,
21442151
responseHeaders, response) {
21452152
let previewLanguage = 'text';

test/unit/x20schemapack.test.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,9 @@ describe('Convert method', function() {
7676
expect(error).to.be.null;
7777
expect(result.output[0].data.item[0].response[0]._postman_previewlanguage).to.equal('json');
7878
expect(result.output[0].data.item[0].response[0].body).to.not.be.empty;
79+
expect(result.output[0].data.item[0].response[0].header.find((header) => {
80+
return header.key === 'Content-Type';
81+
}).value).to.equal('*/*');
7982
});
8083
done();
8184
});

0 commit comments

Comments
 (0)