Fixed an issue where for validateTransactionV2() interface, when mismatches were found there were issues reported for valid data as well due to scheam mutation

Author: VShingala

libV2/validationUtils.js

@@ -150,7 +150,12 @@ function safeSchemaFaker (context, oldSchema, resolveFor, parameterSourceOption,
     resolveTo = _.get(options, 'parametersResolution', 'example'),
     indentCharacter = options.indentCharacter;
 
-  resolvedSchema = resolveSchema(context, oldSchema, 0, PROCESSING_TYPE.VALIDATION);
+  /**
+   * Schema is cloned here as resolveSchema() when called for CONVERSION use cases, will mutate schema in certain way.
+   * i.e. For array it'll add maxItems = 2. This should be avoided as we'll again be needing non-mutated schema
+   * in further VALIDATION use cases as needed.
+   */
+  resolvedSchema = resolveSchema(context, _.cloneDeep(oldSchema), 0, _.toLower(PROCESSING_TYPE.CONVERSION));
 
   resolvedSchema = concreteUtils.fixExamplesByVersion(resolvedSchema);
   key = JSON.stringify(resolvedSchema);
@@ -171,7 +176,6 @@ function safeSchemaFaker (context, oldSchema, resolveFor, parameterSourceOption,
 
   if (resolveFor === PROCESSING_TYPE.VALIDATION) {
     schemaFaker.option({
-      useDefaultValue: false,
       avoidExampleItemsLength: false
     });
   }

test/unit/ValidateV2.test.js

@@ -537,7 +537,7 @@ describe('The Validation option', function () {
       let schema = fs.readFileSync(specData.path, 'utf8'),
         collection = fs.readFileSync(suggestAvailableFixesCollection, 'utf8'),
         schemaPack = new Converter.SchemaPack({ type: 'string', data: schema },
-          { suggestAvailableFixes: true }),
+          { suggestAvailableFixes: true, parametersResolution: 'Example' }),
         historyRequest = [],
         resultObj,
         responseResult,
@@ -980,7 +980,8 @@ describe('VALIDATE FUNCTION TESTS ', function () {
             ignoreUnresolvedVariables: true,
             validateMetadata: true,
             suggestAvailableFixes: true,
-            detailedBlobValidation: true
+            detailedBlobValidation: true,
+            parametersResolution: 'Example'
           },
           schemaPack = new Converter.SchemaPack({ type: 'string', data: primitiveDataTypeBodySpec }, options);