Merge pull request #761 from postmanlabs/feature/CUE-3989

Copy path variable description to generated collection

Author: jatin3893

package-lock.json

@@ -128,7 +128,7 @@
     "object-hash": "3.0.0",
     "graphlib": "2.1.8",
     "path-browserify": "1.0.1",
-    "postman-collection": "4.1.5",
+    "postman-collection": "4.2.1",
     "swagger2openapi": "7.0.8",
     "traverse": "0.6.6",
     "yaml": "1.10.2"

package.json

@@ -0,0 +1,57 @@
+openapi: "3.0.0"
+info:
+  version: "1.0.0"
+  title: "Sample API"
+  description: Buy or rent spacecrafts
+
+paths:
+  /space/{spacecraftId}:
+    get:
+      parameters:
+        - name: spacecraftId
+          description: "Required spacecraftId path param"
+          in: path
+          required: true
+          schema:
+            type: string
+        - name: pathParamOptional
+          description: "Path param optional description"
+          in: path
+          required: false
+          schema:
+            type: string
+        - name: limit
+          in: query
+          description: "QUERY PARAM DESCRIPTION"
+          required: true
+          schema:
+            type: integer
+            format: int32
+        - name: optionalQueryParam
+          in: query
+          description: "QUERY PARAM Optional"
+          required: false
+          schema:
+            type: integer
+            format: int32
+        - name: page
+          in: header
+          description: "HEADER PARAM DESCRIPTION"
+          required: true
+          schema:
+            type: string
+        - name: offset
+          in: header
+          description: "HEADER PARAM Optional"
+          required: false
+          schema:
+            type: string
+
+      summary: Read a spacecraft
+      responses:
+        "201":
+          description: The spacecraft corresponding to the provided `spacecraftId`
+          content:
+            application/json:
+              schema:
+                type: string

test/data/valid_openapi/description-test.yaml

@@ -54,6 +54,7 @@ const expect = require('chai').expect,
     path.join(__dirname, VALID_OPENAPI_PATH, '/query_param_with_enum_resolve_as_example.json'),
   formDataParamDescription = path.join(__dirname, VALID_OPENAPI_PATH, '/form_data_param_description.yaml'),
   allHTTPMethodsSpec = path.join(__dirname, VALID_OPENAPI_PATH, '/all-http-methods.yaml'),
+  descriptionTestSpec = path.join(__dirname, VALID_OPENAPI_PATH, '/description-test.yaml'),
   invalidNullInfo = path.join(__dirname, INVALID_OPENAPI_PATH, '/invalid-null-info.json'),
   invalidNullInfoTitle = path.join(__dirname, INVALID_OPENAPI_PATH, '/invalid-info-null-title.json'),
   invalidNullInfoVersion = path.join(__dirname, INVALID_OPENAPI_PATH, '/invalid-info-null-version.json'),
@@ -1170,6 +1171,33 @@ describe('The convert v2 Function', function() {
       });
   });
 
+  it('should generate a collection with description for Query Params, Path variables and Headers', function(done) {
+    var openapi = fs.readFileSync(descriptionTestSpec, 'utf8');
+
+    Converter.convertV2({ type: 'string', data: openapi },
+      {}, (err, conversionResult) => {
+        expect(
+          conversionResult.output[0].data.item[0].item[0].item[0].request.url.query[0].description.content)
+          .to.equal('(Required) QUERY PARAM DESCRIPTION');
+        expect(
+          conversionResult.output[0].data.item[0].item[0].item[0].request.url.query[1].description.content)
+          .to.equal('QUERY PARAM Optional');
+        expect(conversionResult.output[0].data.item[0].item[0].item[0].request.url.variable[0].description).to.equal(
+          '(Required) Required spacecraftId path param'
+        );
+        expect(conversionResult.output[0].data.item[0].item[0].item[0].request.url.variable[1].description).to.equal(
+          'Path param optional description'
+        );
+        expect(conversionResult.output[0].data.item[0].item[0].item[0].request.header[0].description.content).to.equal(
+          '(Required) HEADER PARAM DESCRIPTION'
+        );
+        expect(conversionResult.output[0].data.item[0].item[0].item[0].request.header[1].description.content).to.equal(
+          'HEADER PARAM Optional'
+        );
+        done();
+      });
+  });
+
   it('Should have disableBodyPruning option for protocolProfileBehavior set to true for all types of request' +
     allHTTPMethodsSpec, function (done) {
     var openapi = fs.readFileSync(allHTTPMethodsSpec, 'utf8');