Skip to content

Commit 6528a22

Browse files
zbindenrenzbindenren
authored
Merge pull request #167 from justin0u0/dont-set-daemonset-maxsurge-by-default
2 parents cd56ef0 + 143a0e1 commit 6528a22

File tree

3 files changed

+49
-44
lines changed

3 files changed

+49
-44
lines changed

‎README.md‎

Lines changed: 45 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -94,49 +94,51 @@ The following command can be used to install kubenurse with Helm: `helm upgrade
9494
<details>
9595
<summary>helm parameters list</summary>
9696

97-
| Setting | Description | Default |
98-
| ---------------------------------- | -------------------------------------------------------------------------------------------------------------------- | ---------------------------------- |
99-
| daemonset.image.repository | The repository name | `postfinance/kubenurse` |
100-
| daemonset.image.tag | The tag/ version of the image | `v1.4.0` |
101-
| daemonset.podLabels | Additional labels to be added to the pods of the daemonset | `[]` |
102-
| daemonset.podAnnotations | Additional annotations to be added to the pods of the daemonset | `[]` |
103-
| daemonset.podSecurityContext | The security context of the daemonset | `{}` |
104-
| daemonset.priorityClassName | The priority class name for the daemonset pods | `""` |
105-
| daemonset.containerSecurityContext | The security context of the containers within the pods of the daemonset | `{}` |
106-
| daemonset.containerResources | The container resources of the containers within the pods of the daemonset | `{}` |
107-
| daemonset.containerImagePullPolicy | The container image pull policy the pods of the daemonset | `IfNotPresent` |
108-
| daemonset.tolerations | The tolerations of the daemonset | See Default tolerations below |
109-
| daemonset.dnsConfig | Specifies the DNS parameters of the pods in the daemonset | `{}` |
110-
| daemonset.volumeMounts | Additional volumeMounts to be added to the pods of the daemonset | `[]` |
111-
| daemonset.volumes | Additional volumes to be added to the daemonset | `[]` |
112-
| serviceMonitor.enabled | Adds a ServiceMonitor for use with [Prometheus-operator](https://github.com/prometheus-operator/prometheus-operator) | `false` |
113-
| serviceMonitor.labels | Additional labels to be added to the ServiceMonitor | `{}` |
114-
| serviceMonitor.relabelings | Additional relabelings to be added to the endpoint of the ServiceMonitor | `[]` |
115-
| serviceAccount.name | The name of the service account which is used | `Release.Name` |
116-
| service.name | The name of service which exposes the kubenurse application | `8080-8080` |
117-
| service.port | The port number of the service | `8080` |
118-
| service.labels | Additional labels to be added to the Service | |
119-
| ingress.enabled | Enable/ Disable the ingress | `true` |
120-
| ingress.className | The classname of the ingress controller (e.g. the nginx ingress controller) | `nginx` |
121-
| ingress.url | The url of the ingress; e.g. kubenurse.westeurope.cloudapp.example.com | `dummy-kubenurse.example.com` |
122-
| insecure | Set `KUBENURSE_INSECURE` environment variable | `true` |
123-
| allow_unschedulable | Sets `KUBENURSE_ALLOW_UNSCHEDULABLE` environment variable | `false` |
124-
| neighbour_filter | Sets `KUBENURSE_NEIGHBOUR_FILTER` environment variable | `app.kubernetes.io/name=kubenurse` |
125-
| neighbour_limit | Sets `KUBENURSE_NEIGHBOUR_LIMIT` environment variable | `10` |
126-
| histogram_buckets | Sets `KUBENURSE_HISTOGRAM_BUCKETS` environment variable | |
127-
| extra_ca | Sets `KUBENURSE_EXTRA_CA` environment variable | |
128-
| extra_checks | Sets `KUBENURSE_EXTRA_CHECKS` environment variable | |
129-
| kubernetes_service_dns | Sets `KUBERNETES_SERVICE_DNS` environment variable | |
130-
| check_api_server_direct | Sets `KUBENURSE_CHECK_API_SERVER_DIRECT` environment variable | `true` |
131-
| check_api_server_dns | Sets `KUBENURSE_CHECK_API_SERVER_DNS` environment variable | `true` |
132-
| check_me_ingress | Sets `KUBENURSE_CHECK_ME_INGRESS` environment variable | `true` |
133-
| check_me_service | Sets `KUBENURSE_CHECK_ME_SERVICE` environment variable | `true` |
134-
| check_neighbourhood | Sets `KUBENURSE_CHECK_NEIGHBOURHOOD` environment variable | `true` |
135-
| check_interval | Sets `KUBENURSE_CHECK_INTERVAL` environment variable | `5s` |
136-
| reuse_connections | Sets `KUBENURSE_REUSE_CONNECTIONS` environment variable | `false` |
137-
| use_tls | Sets `KUBENURSE_USE_TLS` environment variable | `false` |
138-
| cert_file | Sets `KUBENURSE_CERT_FILE` environment variable | |
139-
| cert_key | Sets `KUBENURSE_CERT_KEY` environment variable | |
97+
| Setting | Description | Default |
98+
|----------------------------------------|----------------------------------------------------------------------------------------------------------------------|------------------------------------|
99+
| daemonset.image.repository | The repository name | `postfinance/kubenurse` |
100+
| daemonset.image.tag | The tag/ version of the image | `v1.4.0` |
101+
| daemonset.podLabels | Additional labels to be added to the pods of the daemonset | `[]` |
102+
| daemonset.podAnnotations | Additional annotations to be added to the pods of the daemonset | `[]` |
103+
| daemonset.podSecurityContext | The security context of the daemonset | `{}` |
104+
| daemonset.priorityClassName | The priority class name for the daemonset pods | `""` |
105+
| daemonset.containerSecurityContext | The security context of the containers within the pods of the daemonset | `{}` |
106+
| daemonset.containerResources | The container resources of the containers within the pods of the daemonset | `{}` |
107+
| daemonset.containerImagePullPolicy | The container image pull policy the pods of the daemonset | `IfNotPresent` |
108+
| daemonset.tolerations | The tolerations of the daemonset | See Default tolerations below |
109+
| daemonset.dnsConfig | Specifies the DNS parameters of the pods in the daemonset | `{}` |
110+
| daemonset.volumeMounts | Additional volumeMounts to be added to the pods of the daemonset | `[]` |
111+
| daemonset.volumes | Additional volumes to be added to the daemonset | `[]` |
112+
| daemonset.rollingUpdate.maxUnavailable | The maximum number of DaemonSet pods that can be unavailable during the update | `34%` |
113+
| daemonset.rollingUpdate.maxSurge | The maximum number of nodes with an existing available DaemonSet pod that can have an updated pod during an update | |
114+
| serviceMonitor.enabled | Adds a ServiceMonitor for use with [Prometheus-operator](https://github.com/prometheus-operator/prometheus-operator) | `false` |
115+
| serviceMonitor.labels | Additional labels to be added to the ServiceMonitor | `{}` |
116+
| serviceMonitor.relabelings | Additional relabelings to be added to the endpoint of the ServiceMonitor | `[]` |
117+
| serviceAccount.name | The name of the service account which is used | `Release.Name` |
118+
| service.name | The name of service which exposes the kubenurse application | `8080-8080` |
119+
| service.port | The port number of the service | `8080` |
120+
| service.labels | Additional labels to be added to the Service | |
121+
| ingress.enabled | Enable/ Disable the ingress | `true` |
122+
| ingress.className | The classname of the ingress controller (e.g. the nginx ingress controller) | `nginx` |
123+
| ingress.url | The url of the ingress; e.g. kubenurse.westeurope.cloudapp.example.com | `dummy-kubenurse.example.com` |
124+
| insecure | Set `KUBENURSE_INSECURE` environment variable | `true` |
125+
| allow_unschedulable | Sets `KUBENURSE_ALLOW_UNSCHEDULABLE` environment variable | `false` |
126+
| neighbour_filter | Sets `KUBENURSE_NEIGHBOUR_FILTER` environment variable | `app.kubernetes.io/name=kubenurse` |
127+
| neighbour_limit | Sets `KUBENURSE_NEIGHBOUR_LIMIT` environment variable | `10` |
128+
| histogram_buckets | Sets `KUBENURSE_HISTOGRAM_BUCKETS` environment variable | |
129+
| extra_ca | Sets `KUBENURSE_EXTRA_CA` environment variable | |
130+
| extra_checks | Sets `KUBENURSE_EXTRA_CHECKS` environment variable | |
131+
| kubernetes_service_dns | Sets `KUBERNETES_SERVICE_DNS` environment variable | |
132+
| check_api_server_direct | Sets `KUBENURSE_CHECK_API_SERVER_DIRECT` environment variable | `true` |
133+
| check_api_server_dns | Sets `KUBENURSE_CHECK_API_SERVER_DNS` environment variable | `true` |
134+
| check_me_ingress | Sets `KUBENURSE_CHECK_ME_INGRESS` environment variable | `true` |
135+
| check_me_service | Sets `KUBENURSE_CHECK_ME_SERVICE` environment variable | `true` |
136+
| check_neighbourhood | Sets `KUBENURSE_CHECK_NEIGHBOURHOOD` environment variable | `true` |
137+
| check_interval | Sets `KUBENURSE_CHECK_INTERVAL` environment variable | `5s` |
138+
| reuse_connections | Sets `KUBENURSE_REUSE_CONNECTIONS` environment variable | `false` |
139+
| use_tls | Sets `KUBENURSE_USE_TLS` environment variable | `false` |
140+
| cert_file | Sets `KUBENURSE_CERT_FILE` environment variable | |
141+
| cert_key | Sets `KUBENURSE_CERT_KEY` environment variable | |
140142

141143
</details>
142144

‎helm/kubenurse/templates/daemonset.yaml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ spec:
1313
{{- include "kubenurse.selectorLabels" . | nindent 6 }}
1414
updateStrategy:
1515
rollingUpdate:
16-
maxSurge: 0
16+
{{- with .Values.daemonset.rollingUpdate.maxSurge }}
17+
maxSurge: {{ . }}
18+
{{- end }}
1719
maxUnavailable: {{ .Values.daemonset.rollingUpdate.maxUnavailable }}
1820
type: RollingUpdate
1921
template:

‎helm/kubenurse/values.yaml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ daemonset:
2222
priorityClassName: ""
2323
rollingUpdate:
2424
maxUnavailable: 34%
25+
# maxSurge:
2526

2627
serviceMonitor:
2728
enabled: false

0 commit comments

Comments
 (0)