make playwright
can't run when make
path has spaces
#1946
Labels
chore
A maintenance task that doesn't affect functionality
Makefile
has the following entry forplaywright-shiny
(and similar ones for other playwright fixtures):Due to missing
""
around$(MAKE)
, this fails to execute when make is installed at a path with spaces. Say, underProgram Files (x86)
1.It'll be easy to fix, and I'd be happy to make a PR. Before I do that though, I wanted to ask if the same fix should be applied to other path variables like
$(TEST_FILE)
whenever they don't have quotations.PS. It isn't really a bug with Shiny but rather with its test setup, so I didn't opt for using the bug report issue template.
Footnotes
I'm an uncivilized brute that still hasn't moved from Windows 10. ↩
The text was updated successfully, but these errors were encountered: