Skip to content

make playwright can't run when make path has spaces #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ErdaradunGaztea opened this issue Mar 29, 2025 · 1 comment
Open

make playwright can't run when make path has spaces #1946

ErdaradunGaztea opened this issue Mar 29, 2025 · 1 comment
Assignees
Labels
chore A maintenance task that doesn't affect functionality

Comments

@ErdaradunGaztea
Copy link
Contributor

ErdaradunGaztea commented Mar 29, 2025

Makefile has the following entry for playwright-shiny (and similar ones for other playwright fixtures):

playwright-shiny: FORCE
	$(MAKE) playwright TEST_FILE="$(SHINY_TEST_FILE)"

Due to missing "" around $(MAKE), this fails to execute when make is installed at a path with spaces. Say, under Program Files (x86)1.

It'll be easy to fix, and I'd be happy to make a PR. Before I do that though, I wanted to ask if the same fix should be applied to other path variables like $(TEST_FILE) whenever they don't have quotations.

PS. It isn't really a bug with Shiny but rather with its test setup, so I didn't opt for using the bug report issue template.

Footnotes

  1. I'm an uncivilized brute that still hasn't moved from Windows 10.

@schloerke
Copy link
Collaborator

I'd be curious of the solution. But if it's a drastic change, we may reject the PR.

Related: https://stackoverflow.com/questions/9838384/can-gnu-make-handle-filenames-with-spaces.


Would using make instead of $(MAKE) be better? I don't believe we leverage the --touch, --just-print, or --question flags.

Related: https://stackoverflow.com/a/38978887

@schloerke schloerke added chore A maintenance task that doesn't affect functionality and removed needs-triage labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A maintenance task that doesn't affect functionality
Projects
None yet
Development

No branches or pull requests

2 participants