Skip to content

make playwright can't run when make path has spaces #1946

Open
@ErdaradunGaztea

Description

@ErdaradunGaztea

Makefile has the following entry for playwright-shiny (and similar ones for other playwright fixtures):

playwright-shiny: FORCE
	$(MAKE) playwright TEST_FILE="$(SHINY_TEST_FILE)"

Due to missing "" around $(MAKE), this fails to execute when make is installed at a path with spaces. Say, under Program Files (x86)1.

It'll be easy to fix, and I'd be happy to make a PR. Before I do that though, I wanted to ask if the same fix should be applied to other path variables like $(TEST_FILE) whenever they don't have quotations.

PS. It isn't really a bug with Shiny but rather with its test setup, so I didn't opt for using the bug report issue template.

Footnotes

  1. I'm an uncivilized brute that still hasn't moved from Windows 10.

Metadata

Metadata

Labels

choreA maintenance task that doesn't affect functionality

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions