Skip to content

Commit ea5db0e

Browse files
authored
chore: Rename internal dataframe files to data-frame; (#1312)
1 parent c0d334a commit ea5db0e

31 files changed

+17
-17
lines changed

js/build.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ async function bundle_helper(
3636

3737
if (options.metafile) {
3838
// Save metafile
39-
const dataframe_results = result;
39+
const data_frame_results = result;
4040
await fs.writeFile(
4141
"esbuild-metadata.json",
42-
JSON.stringify(dataframe_results.metafile)
42+
JSON.stringify(data_frame_results.metafile)
4343
);
4444
console.log("Metadata file written to esbuild-metadata.json");
4545
}
@@ -51,7 +51,7 @@ async function bundle_helper(
5151

5252
const opts: Array<BuildOptions> = [
5353
{
54-
entryPoints: { "dataframe/dataframe": "dataframe/index.tsx" },
54+
entryPoints: { "data-frame/data-frame": "data-frame/index.tsx" },
5555
plugins: [sassPlugin({ type: "css-text", sourceMap: false })],
5656
metafile: true,
5757
},
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

js/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"name": "shiny-dataframe-binding",
2+
"name": "py-shiny-js",
33
"private": true,
44
"license": "MIT",
55
"scripts": {

js/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,5 @@
2020
"noUncheckedIndexedAccess": true
2121
},
2222
"include": ["**/*.tsx", "**/*.ts"],
23-
"exclude": ["dataframe/*"],
23+
"exclude": ["data-frame/*"],
2424
}

shiny/render/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
from . import ( # noqa: F401
66
transformer, # pyright: ignore[reportUnusedImport]
77
)
8-
from ._dataframe import ( # noqa: F401
8+
from ._data_frame import ( # noqa: F401
99
CellPatch, # pyright: ignore[reportUnusedImport]
1010
DataGrid,
1111
DataTable,

shiny/render/_dataframe.py renamed to shiny/render/_data_frame.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
from ..session._utils import Session
5757

5858
DataFrameT = TypeVar("DataFrameT", bound=pd.DataFrame)
59-
# TODO-future; Pandas, Polars, api compat, etc.; Today, we only support Pandas
59+
# TODO-barret-render.data_frame; Pandas, Polars, api compat, etc.; Today, we only support Pandas
6060

6161

6262
from ._data_frame_utils._datagridtable import DataFrameResult

shiny/ui/_html_deps_py_shiny.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ def data_frame_deps() -> HTMLDependency:
2020
version=__version__,
2121
source={
2222
"package": "shiny",
23-
"subdir": "www/shared/py-shiny/dataframe",
23+
"subdir": "www/shared/py-shiny/data-frame",
2424
},
25-
script={"src": "dataframe.js", "type": "module"},
25+
script={"src": "data-frame.js", "type": "module"},
2626
)
2727

2828

shiny/ui/dataframe/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
from ._dataframe import output_data_frame
1+
from ._data_frame import output_data_frame
22

33
__all__ = ("output_data_frame",)
File renamed without changes.

shiny/www/shared/py-shiny/dataframe/dataframe.js renamed to shiny/www/shared/py-shiny/data-frame/data-frame.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

shiny/www/shared/py-shiny/dataframe/dataframe.js.map renamed to shiny/www/shared/py-shiny/data-frame/data-frame.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/playwright/shiny/components/data_frame/edit/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from palmerpenguins import load_penguins_raw
77

88
from shiny import App, Inputs, Outputs, Session, module, render, ui
9-
from shiny.render._dataframe import CellPatch
9+
from shiny.render._data_frame import CellPatch
1010

1111
# TODO-barret-render.data_frame; Make an example that uses a dataframe that then updates a higher level reactive, that causes the df to update... which causes the table to render completely
1212
# TODO-barret-render.data_frame; When "updating" data, try to maintain the scroll, filter info when a new `df` is supplied;

tests/playwright/shiny/components/data_frame/validate_data_edit_mode/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
from palmerpenguins import load_penguins_raw # pyright: ignore[reportMissingTypeStubs]
22

33
from shiny import App, Inputs, Outputs, Session, render, ui
4-
from shiny.render._dataframe import CellPatch
4+
from shiny.render._data_frame import CellPatch
55
from shiny.types import SafeException
66

77
app_ui = ui.page_fluid(

tests/playwright/shiny/components/data_frame/validate_data_save/app.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from palmerpenguins import load_penguins_raw # pyright: ignore[reportMissingTypeStubs]
44

55
from shiny import App, Inputs, Outputs, Session, render, ui
6-
from shiny.render._dataframe import CellPatch
6+
from shiny.render._data_frame import CellPatch
77

88
app_ui = ui.page_fluid(
99
ui.h2("Palmer Penguins"),

0 commit comments

Comments
 (0)