Code feedback

Author: schloerke

Makefile

@@ -1,5 +1,3 @@
-# .PHONY: help clean% check% format% docs% lint test pyright playwright% install% testrail% coverage release
-
 # Depend on `FORCE` to ensure the target is always run
 FORCE:
 
@@ -82,7 +80,7 @@ PYTEST = $(SITE_PACKAGES)/pytest
 COVERAGE = $(SITE_PACKAGES)/coverage
 PYRIGHT = $(SITE_PACKAGES)/pyright
 PLAYWRIGHT = $(SITE_PACKAGES)/playwright
-$(PYTEST) $(COVERAGE) $(PYRIGHT) $(PLAYWRIGHT):
+$(RUFF) $(PYTEST) $(COVERAGE) $(PYRIGHT) $(PLAYWRIGHT):
 	@$(MAKE) install-deps
 
 

examples/model-score/app.py

@@ -16,6 +16,16 @@
 THRESHOLD_LOW = 0.5
 THRESHOLD_LOW_COLOR = "rgb(193, 0, 0)"
 
+
+def value_box_theme(score):
+    if score > THRESHOLD_MID:
+        return "text-success"
+    elif score < THRESHOLD_LOW:
+        return "bg-danger"
+    else:
+        return "text-warning"
+
+
 # Start a background thread that writes fake data to the SQLite database every second
 scoredata.begin()
 
@@ -195,13 +205,7 @@ def value_boxes():
                 ui.value_box(
                     model,
                     ui.h2(score),
-                    theme=(
-                        "text-success"
-                        if score > THRESHOLD_MID
-                        else "text-warning"
-                        if score > THRESHOLD_LOW
-                        else "bg-danger"
-                    ),
+                    theme=value_box_theme(score),
                 )
                 for model, score in scores_by_model.items()
             ],