test: remove exception swallower to make debug easier (#1328)

Author: karangattu

tests/playwright/utils/deploy_utils.py

@@ -45,21 +45,6 @@ def skip_if_not_chrome(fn: CallableT) -> CallableT:
     return fn
 
 
-def exception_swallower(
-    function: Callable[[str, str], str]
-) -> Callable[[str, str], str]:
-    def wrapper(app_name: str, app_dir: str) -> str:
-        runtime_e: Exception | None = None
-        try:
-            return function(app_name, app_dir)
-        except Exception as e:
-            runtime_e = e
-        if isinstance(runtime_e, Exception):
-            raise RuntimeError("Failed to deploy to server.")
-
-    return wrapper
-
-
 def run_command(cmd: str) -> str:
     output = subprocess.run(
         cmd,
@@ -104,9 +89,6 @@ def deploy_to_connect(app_name: str, app_dir: str) -> str:
     return url
 
 
-quiet_deploy_to_connect = exception_swallower(deploy_to_connect)
-
-
 # TODO-future: Supress web browser from opening after deploying - https://github.com/rstudio/rsconnect-python/issues/462
 def deploy_to_shinyapps(app_name: str, app_dir: str) -> str:
     # Deploy to shinyapps.io
@@ -115,9 +97,6 @@ def deploy_to_shinyapps(app_name: str, app_dir: str) -> str:
     return f"https://{name}.shinyapps.io/{app_name}/"
 
 
-quiet_deploy_to_shinyapps = exception_swallower(deploy_to_shinyapps)
-
-
 # Since connect parses python packages, we need to get latest version of shiny on HEAD
 def write_requirements_txt(app_dir: str) -> None:
     app_requirements_file_path = os.path.join(app_dir, "app_requirements.txt")
@@ -173,8 +152,8 @@ def deploy_app(
         write_requirements_txt(tmp_app_dir)
 
         deployment_function = {
-            "connect": quiet_deploy_to_connect,
-            "shinyapps": quiet_deploy_to_shinyapps,
+            "connect": deploy_to_connect,
+            "shinyapps": deploy_to_shinyapps,
         }[location]
 
         pre_deployment_time = time.time()