Skip to content

Commit 4c28e91

Browse files
authored
Stop sending recalculated message immediately after persistent progress message (#1356)
1 parent 93389d9 commit 4c28e91

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

shiny/session/_session.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1414,9 +1414,10 @@ async def output_obs():
14141414
session._send_progress(
14151415
"binding", {"id": output_name, "persistent": True}
14161416
)
1417+
# It's important to exit early here _without_ a recalculated message
14171418
return
14181419
except SilentCancelOutputException:
1419-
return
1420+
pass
14201421
except SilentException:
14211422
session._outbound_message_queues.set_value(output_name, None)
14221423
except Exception as e:
@@ -1436,16 +1437,15 @@ async def output_obs():
14361437
"type": None,
14371438
}
14381439
session._outbound_message_queues.set_error(output_name, err_message)
1439-
return
1440-
finally:
1441-
await session._send_message(
1442-
{
1443-
"recalculating": {
1444-
"name": output_name,
1445-
"status": "recalculated",
1446-
}
1440+
1441+
await session._send_message(
1442+
{
1443+
"recalculating": {
1444+
"name": output_name,
1445+
"status": "recalculated",
14471446
}
1448-
)
1447+
}
1448+
)
14491449

14501450
output_obs.on_invalidate(
14511451
lambda: require_real_session()._send_progress(

0 commit comments

Comments
 (0)