Skip to content

Commit 381e851

Browse files
authored
fix: Revert - fix(session): Always have calling session be the parent session when making scoped session (#1924)
1 parent 14b92d4 commit 381e851

File tree

3 files changed

+2
-9
lines changed

3 files changed

+2
-9
lines changed

CHANGELOG.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2525

2626
* Fixed an issue with the `.click()` method on InputActionButton controllers in `shiny.playwright.controllers` where the method would not work as expected. (#1886)
2727

28-
* Fixed an issue where the parent session of a nested module's session was not being set to the calling session. Now, a session who's namespace is `A-B` has a parent of `A` and grandparent of `(root)` (whereas before it would have skipped `A` and the parent would have been `(root)`). (#1923)
29-
30-
3128
## [1.3.0] - 2025-03-03
3229

3330
### New features

shiny/session/_session.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1233,9 +1233,8 @@ def is_stub_session(self) -> bool:
12331233
async def close(self, code: int = 1001) -> None:
12341234
await self._parent.close(code)
12351235

1236-
def make_scope(self, id: Id) -> Session:
1237-
ns = self.ns(id)
1238-
return SessionProxy(parent=self, ns=ns)
1236+
def make_scope(self, id: str) -> Session:
1237+
return self._parent.make_scope(self.ns(id))
12391238

12401239
def root_scope(self) -> Session:
12411240
res = self

tests/playwright/shiny/bookmark/modules/test_bookmark_modules.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,6 @@ def test_bookmark_modules(
2828
mod1_key: str,
2929
) -> None:
3030

31-
if "recursive" in app_name:
32-
pytest.skip("Skip broken recursive test")
33-
3431
# Set environment variable before the app starts
3532
os.environ["SHINY_BOOKMARK_STORE"] = bookmark_store
3633

0 commit comments

Comments
 (0)