Skip to content

Commit 2d7e0c9

Browse files
committed
Update _bookmark.py
1 parent 24c134b commit 2d7e0c9

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

shiny/bookmark/_bookmark.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,12 @@
6666
BookmarkStore = Literal["url", "server", "disable"]
6767

6868

69+
# TODO: future - Local storage Bookmark class!
70+
# * Needs a consistent id for storage.
71+
# * Needs ways to clean up other storage
72+
# * Needs ways to see available IDs
73+
74+
6975
class Bookmark(ABC):
7076

7177
_root_session: Session
@@ -94,6 +100,7 @@ def __init__(self, root_session: Session):
94100
# async def get_url(self) -> str:
95101
# ...
96102

103+
# # TODO: Barret - Implement this?!?
97104
# # `session.bookmark.on_bookmarked(session.bookmark.update_query_string)`
98105
# # `session.bookmark.on_bookmarked(session.bookmark.show_modal)`
99106
# await def show_modal(self, url: Optional[str] = None) -> None:

0 commit comments

Comments
 (0)