We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent 24c134b commit 2d7e0c9Copy full SHA for 2d7e0c9
shiny/bookmark/_bookmark.py
@@ -66,6 +66,12 @@
66
BookmarkStore = Literal["url", "server", "disable"]
67
68
69
+# TODO: future - Local storage Bookmark class!
70
+# * Needs a consistent id for storage.
71
+# * Needs ways to clean up other storage
72
+# * Needs ways to see available IDs
73
+
74
75
class Bookmark(ABC):
76
77
_root_session: Session
@@ -94,6 +100,7 @@ def __init__(self, root_session: Session):
94
100
# async def get_url(self) -> str:
95
101
# ...
96
102
103
+ # # TODO: Barret - Implement this?!?
97
104
# # `session.bookmark.on_bookmarked(session.bookmark.update_query_string)`
98
105
# # `session.bookmark.on_bookmarked(session.bookmark.show_modal)`
99
106
# await def show_modal(self, url: Optional[str] = None) -> None:
0 commit comments