Fix lints; Update Changelog

Author: schloerke

CHANGELOG.md

@@ -11,7 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 * `@render.data_frame`'s input value `input.<ID>_data_view_indices` has been renamed to `input.<ID>_data_view_rows` for consistent naming. Please use `input.<ID>_data_view_rows` and consider `input.<ID>_data_view_indices` deprecated. (#1374)
 
-* Restored `@render.data_frame`'s (prematurely removed) input value `input.<ID>_selected_rows()`. This value is to be considered deprecated. Please use `<ID>.input_cell_selection()["rows"]` moving forward. (#1345)
+* Restored `@render.data_frame`'s (prematurely removed in v0.9.0) input value `input.<ID>_selected_rows()`. Please use `<ID>.input_cell_selection()["rows"]` and consider `input.<ID>_selected_rows()` deprecated. (#1345)
 
 ### New features
 

tests/playwright/shiny/components/data_frame/edit/app.py

@@ -22,7 +22,7 @@
 
 
 # Add some HTML content to the dataframe!
-df["Sample Number"] = df["Sample Number"].apply(
+df["Sample Number"] = df["Sample Number"].apply(  # pyright: ignore[reportCallIssue]
     lambda x: ui.HTML(  # pyright: ignore[reportUnknownLambdaType]
         str(
             ui.tags.strong(
@@ -88,19 +88,19 @@ def summary_data():
     def _():
         print(
             "Filters:",
-            summary_data._input_column_filter(),  # pyright: ignore[reportUnknownArgumentType,reportAttributeAccessIssue]
+            summary_data.input_column_filter(),  # pyright: ignore[reportUnknownArgumentType,reportAttributeAccessIssue]
         )
 
     @reactive.effect
     def _():
         print(
             "Sorting:",
-            summary_data._input_column_sort(),  # pyright: ignore[reportUnknownArgumentType,reportAttributeAccessIssue]
+            summary_data.input_column_sort(),  # pyright: ignore[reportUnknownArgumentType,reportAttributeAccessIssue]
         )
 
     @reactive.effect
     def _():
-        print("indices:", summary_data._input_data_view_indices())
+        print("indices:", summary_data._input_data_view_rows())
 
     @reactive.effect
     def _():

tests/playwright/shiny/components/data_frame/html_columns_df/df_organization/app.py

@@ -20,7 +20,7 @@
     ),
     ui.output_data_frame("iris_df"),
     ui.h2("Data view indices"),
-    ui.output_text_verbatim("data_view_indices"),
+    ui.output_text_verbatim("data_view_rows"),
     ui.h2("Indices when view_selected=True"),
     ui.output_text_verbatim("data_view_selected_true"),
     ui.h2("Indices when view_selected=False"),
@@ -41,8 +41,8 @@ def iris_df():
         )
 
     @render.code  # pyright: ignore[reportArgumentType]
-    def data_view_indices():
-        return iris_df._input_data_view_indices()
+    def data_view_rows():
+        return iris_df._input_data_view_rows()
 
     @render.code  # pyright: ignore[reportArgumentType]
     def data_view_selected_false():  # pyright: ignore[reportUnknownParameterType]

tests/playwright/shiny/components/data_frame/html_columns_df/df_organization/test_df_organization.py

@@ -6,42 +6,42 @@
 def test_dataframe_organization_methods(page: Page, local_app: ShinyAppProc) -> None:
     page.goto(local_app.url)
     data_frame = OutputDataFrame(page, "iris_df")
-    input_view_indices = OutputCode(page, "data_view_indices")
+    input_view_rows = OutputCode(page, "data_view_rows")
     input_view_selected_true = OutputCode(page, "data_view_selected_true")
     input_view_selected_false = OutputCode(page, "data_view_selected_false")
     input_cell_selection = OutputCode(page, "cell_selection")
     reset_df = InputActionButton(page, "reset_df")
 
     # assert value of unsorted table
-    input_view_indices.expect_value("(0, 1, 2)")
+    input_view_rows.expect_value("(0, 1, 2)")
     input_view_selected_true.expect_value("[]")
     input_view_selected_false.expect_value("[ 0 50 100]")
     input_cell_selection.expect_value("()")
 
     # sort column by number descending
     data_frame.set_column_sort(col=0)
-    input_view_indices.expect_value("(1, 2, 0)")
+    input_view_rows.expect_value("(1, 2, 0)")
     input_view_selected_true.expect_value("[]")
     input_view_selected_false.expect_value("[ 50 100   0]")
     input_cell_selection.expect_value("()")
 
     # sort column by number ascending
     data_frame.set_column_sort(col=0)
-    input_view_indices.expect_value("(0, 2, 1)")
+    input_view_rows.expect_value("(0, 2, 1)")
     input_view_selected_true.expect_value("[]")
     input_view_selected_false.expect_value("[ 0 100 50]")
     input_cell_selection.expect_value("()")
 
     # sort column by text ascending
     data_frame.set_column_sort(col=4)
-    input_view_indices.expect_value("(0, 1, 2)")
+    input_view_rows.expect_value("(0, 1, 2)")
     input_view_selected_true.expect_value("[]")
     input_view_selected_false.expect_value("[ 0 50 100]")
     input_cell_selection.expect_value("()")
 
     # sort column by text descending
     data_frame.set_column_sort(col=4)
-    input_view_indices.expect_value("(2, 1, 0)")
+    input_view_rows.expect_value("(2, 1, 0)")
     input_view_selected_true.expect_value("[]")
     input_view_selected_false.expect_value("[100 50  0]")
     input_cell_selection.expect_value("()")
@@ -51,7 +51,7 @@ def test_dataframe_organization_methods(page: Page, local_app: ShinyAppProc) ->
 
     # filter using numbers
     data_frame.set_column_filter(col=0, text=["6", "7"])
-    input_view_indices.expect_value("(1, 2)")
+    input_view_rows.expect_value("(1, 2)")
     input_view_selected_true.expect_value("[]")
     input_view_selected_false.expect_value("[ 50 100]")
     input_cell_selection.expect_value("()")
@@ -61,7 +61,7 @@ def test_dataframe_organization_methods(page: Page, local_app: ShinyAppProc) ->
 
     # select multiple rows
     data_frame.select_rows([0, 2])
-    input_view_indices.expect_value("(0, 1, 2)")
+    input_view_rows.expect_value("(0, 1, 2)")
     input_view_selected_true.expect_value("[  0 100]")
     input_view_selected_false.expect_value("[  0  50 100]")
     input_cell_selection.expect_value("(0, 2)")
@@ -71,7 +71,7 @@ def test_dataframe_organization_methods(page: Page, local_app: ShinyAppProc) ->
 
     # select single row
     data_frame.select_rows([0])
-    input_view_indices.expect_value("(0, 1, 2)")
+    input_view_rows.expect_value("(0, 1, 2)")
     input_view_selected_true.expect_value("[0]")
     input_view_selected_false.expect_value("[  0  50 100]")
     input_cell_selection.expect_value("(0,)")