test(express): Add kitchensink apps & tests (#1886)

Author: karangattu

.github/workflows/pytest.yaml

@@ -187,7 +187,6 @@ jobs:
       - name: Install node.js
         uses: actions/setup-node@v4
         with:
-          node-version: "18"
           cache: npm
           cache-dependency-path: examples/brownian/shinymediapipe/package-lock.json
       - name: Install node.js package
@@ -206,6 +205,49 @@ jobs:
           path: test-results/
           retention-days: 5
 
+  playwright-ai:
+    if: github.event_name != 'release'
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: ["3.12", "3.11", "3.10", "3.9"]
+        browser: ["chromium", "firefox", "webkit"]
+        exclude:
+          - python-version: ${{ github.event.pull_request.draft && '3.11' }}
+          - python-version: ${{ github.event.pull_request.draft && '3.10' }}
+          - python-version: ${{ github.event.pull_request.draft && '3.9' }}
+          - browser: ${{ github.event.pull_request.draft && 'firefox' }}
+          - browser: ${{ github.event.pull_request.draft && 'webkit' }}
+      fail-fast: false
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+      - name: Setup py-shiny
+        uses: ./.github/py-shiny/setup
+        with:
+          python-version: ${{ matrix.python-version }}
+      - name: Determine browsers for testing
+        uses: ./.github/py-shiny/pytest-browsers
+        id: browsers
+        with:
+          browser: ${{ matrix.browser }}
+          # If anything other than `true`, it will heavily reduce webkit performance
+          # Related: https://github.com/microsoft/playwright/issues/18119
+          disable-playwright-diagnostics: ${{ matrix.browser == 'webkit' || matrix.browser == 'firefox' }}
+
+      - name: Run playwright tests for AI generated apps
+        timeout-minutes: 60
+        run: |
+          make playwright-ai SUB_FILE=". --numprocesses 3 ${{ steps.browsers.outputs.playwright-diagnostic-args }}" ${{ steps.browsers.outputs.browsers }}
+      - uses: actions/upload-artifact@v4
+        if: failure() && steps.browsers.outputs.has-playwright-diagnostics
+        with:
+          name: "playright-ai-${{ runner.os }}-${{ matrix.python-version }}-${{ matrix.browser }}-results"
+          path: test-results/
+          retention-days: 5
+
   playwright-deploys-precheck:
     if: github.event_name != 'release'
     runs-on: ubuntu-latest

CHANGELOG.md

@@ -23,6 +23,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 * Fixed an issue where the `.update_user_input()` method on `ui.Chat()` isn't working in shinylive.  (#1891)
 
+* Fixed an issue with the `.click()` method on InputActionButton controllers in `shiny.playwright.controllers` where the method would not work as expected. (#1886)
+
 ## [1.3.0] - 2025-03-03
 
 ### New features

Makefile

@@ -157,6 +157,7 @@ TEST_FILE:=tests/playwright/$(SUB_FILE)
 DEPLOYS_TEST_FILE:=tests/playwright/deploys$(SUB_FILE)
 SHINY_TEST_FILE:=tests/playwright/shiny/$(SUB_FILE)
 EXAMPLES_TEST_FILE:=tests/playwright/examples/$(SUB_FILE)
+AI_TEST_FILE:=tests/playwright/ai_generated_apps/$(SUB_FILE)
 
 install-playwright: FORCE
 	playwright install --with-deps
@@ -187,6 +188,10 @@ playwright-deploys: FORCE
 playwright-examples: FORCE
 	$(MAKE) playwright TEST_FILE="$(EXAMPLES_TEST_FILE)"
 
+# end-to-end tests for all AI generated apps
+playwright-ai: FORCE
+	$(MAKE) playwright TEST_FILE="$(AI_TEST_FILE)"
+
 coverage: FORCE ## check combined code coverage (must run e2e last)
 	pytest --cov-report term-missing --cov=shiny tests/pytest/ $(SHINY_TEST_FILE) $(PYTEST_BROWSERS)
 	coverage html

pyrightconfig.json

@@ -10,7 +10,7 @@
     "docs",
     "tests/playwright/deploys/*/app.py",
     "shiny/templates",
-    "tests/playwright/shiny/tests_for_ai_generated_apps"
+    "tests/playwright/ai_generated_apps",
   ],
   "typeCheckingMode": "strict",
   "reportImportCycles": "none",

shiny/playwright/controller/_base.py

@@ -123,8 +123,12 @@ def set_text(
 
 
 def _expect_multiple(loc: Locator, multiple: bool, timeout: Timeout = None) -> None:
-    value = "True" if multiple else None
-    _expect_style_to_have_value(loc, "multiple", value, timeout=timeout)
+    _expect_attribute_to_have_value(
+        loc,
+        "multiple",
+        value="multiple" if multiple else None,
+        timeout=timeout,
+    )
 
 
 ######################################################

shiny/playwright/controller/_input_buttons.py

@@ -101,7 +101,7 @@ def click(self, *, timeout: Timeout = None):
         timeout
             The maximum time to wait for the input dark mode to be clicked. Defaults to `None`.
         """
-        self.loc.click(timeout=timeout)
+        self.loc.locator("button").click(timeout=timeout)
         return self
 
     def expect_mode(self, value: str, *, timeout: Timeout = None):

tests/playwright/shiny/tests_for_ai_generated_apps/accordion/app-core.py renamed to tests/playwright/ai_generated_apps/accordion/app-core.py

@@ -0,0 +1,65 @@
+from shiny import App, render, ui
+
+# Define the UI
+app_ui = ui.page_fillable(
+    # Add Font Awesome CSS in the head section
+    ui.tags.head(
+        ui.tags.link(
+            rel="stylesheet",
+            href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.7.2/css/all.min.css",
+        )
+    ),
+    # Card containing accordion
+    ui.card(
+        ui.accordion(
+            # Basic Panel
+            ui.accordion_panel(
+                "Basic Panel",
+                ui.markdown("This is a basic panel with just a title parameter"),
+            ),
+            # Panel with title and value
+            ui.accordion_panel(
+                "Panel with Value",
+                ui.markdown("This panel has both a title and a value parameter"),
+                value="panel2",
+            ),
+            # Panel with title, value, and icon
+            ui.accordion_panel(
+                "Panel with Icon",
+                ui.markdown("This panel includes an icon parameter using Font Awesome"),
+                value="panel3",
+                icon=ui.tags.i(
+                    class_="fa-solid fa-shield-halved", style="font-size: 1rem;"
+                ),
+            ),
+            # Panel with title, value, icon, and custom attributes
+            ui.accordion_panel(
+                "Panel with Custom Attributes",
+                ui.markdown(
+                    "This panel demonstrates custom attributes (class and style)"
+                ),
+                value="panel4",
+                icon=ui.tags.i(class_="fa-solid fa-star", style="font-size: 1rem;"),
+                class_="custom-panel",
+                style="background-color: #f8f9fa;",
+            ),
+            id="acc",
+            open=True,
+            multiple=True,
+        ),
+    ),
+    # Output for selected panel
+    ui.output_text("selected_panel"),
+)
+
+
+# Define the server
+def server(input, output, session):
+    @output
+    @render.text
+    def selected_panel():
+        return f"Currently selected panel: {input.acc()}"
+
+
+# Create the app
+app = App(app_ui, server)