Python inlay type hints

[kv9898]

In VS Code, you could have Pylance which could offer inlay type hints:

Which is quite handy:

Is this part of the Positron roadmap?

[kv9898]

BasedPyright provides this functionality for VS Code-based editors such as Positron.

But I get this annoying pop-up everytime I start Positron:

[juliasilge]

I opened #7393 for the problem with that setting, so we can look into what's going on. Thanks for the report! 🙌

[ntluong95]

I dont find basedpyright is the good alternative. I hope Posit team can do something to improve the Jedi LSP to get on par with Pylance.
One thing is the semantic highlighting, type hint, and many other to be named. I know Ruff team is doing something, hope we can have an alternative for Pylance

[kv9898]

For those who are interested in a BasedPyright version compatible with Positron:

I’ve created a custom fork of BasedPyright tailored for use with Positron. It resolves the persistent popup issue and disables features that overlap with positron-python by default.

To use it:

1. Disable the built-in Pyright extension.
2. Install the forked extension from Open VSX.

That’s it — you’re all set.

[kv9898]

Yes I'm trying to add diagnostics now, would you like to try when it's done?

[ntluong95]

yes sure. I would like to have a look on your code too to see if I can help anything :)

[kv9898]

yes sure. I would like to have a look on your code too to see if I can help anything :)

it's in my quarto fork under branch 'extra-language-service'.

Currently, for type-checking/linting, the annoying thing is that there isn't a vscode.executeDiagnosticProvider API analogous to vscode.executeInlayHintProvider which I used to retrieve relevant information for the virtual document.

[ntluong95]

yes sure. I would like to have a look on your code too to see if I can help anything :)

it's in my quarto fork under branch 'extra-language-service'.

Currently, for type-checking/linting, the annoying thing is that there isn't a vscode.executeDiagnosticProvider API analogous to vscode.executeInlayHintProvider which I used to retrieve relevant information for the virtual document.

That is the shame, I think. I have asked them for that features as well as inline results for years but I think they will not implement it

[kv9898]

I created a PR for the inlay hint feature only. It seems that even Microsoft itself recognises the drawback with diagnostics.

And here's a related issue:
microsoft/vscode#159911

[kv9898]

@juliasilge with my customised basedpyright extension, the user has two parallel sets of LSP support. Now my extension turns of the overlapping LSP features by default. Nevertheless, sometimes I find the basedpyright features are more helpful (in the screenshot, basedpyright infers the return type while Positron's built-in feature doesn't). In this case I would like to disable the hover from positron-python. Would it be preferable if we allow users to cherry pick the features they want from either language service by a consistent series of settings respected by both Positron and basedpyright extension? I can write a PR if that's the preferred way.

[juliasilge]

IIUC it is expected that folks will get two hover signatures if they are running two LSPs that provide such a feature, for example when running both Jedi and pyright LSPs (see this, for example); this isn't something going wrong but the way LSPs work (you can have many of them going at the same time).

I think the best option in this type of situation would be for an extension like yours to contribute a configuration default that turns off a specific language feature, for example, one or more of the hover settings outlined here:
https://github.com/pappasam/jedi-language-server/blob/main/README.md#configuration

[kv9898]

IIUC it is expected that folks will get two hover signatures if they are running two LSPs that provide such a feature, for example when running both Jedi and pyright LSPs (see this, for example); this isn't something going wrong but the way LSPs work (you can have many of them going at the same time).

I think the best option in this type of situation would be for an extension like yours to contribute a configuration default that turns off a specific language feature, for example, one or more of the hover settings outlined here:
https://github.com/pappasam/jedi-language-server/blob/main/README.md#configuration

Thanks for the reply! Just to clarify — I understand the dual-hover behavior is expected when two LSPs overlap. What I'm proposing is to introduce a shared, consistent mechanism for users to selectively choose a service provider for specific features (like hover, completions, etc.) across both positron-python and basedpyright.

My extension already disables overlapping features by default, but currently, there's no way to disable Positron’s features from the outside. If there's interest in making this possible through configuration defaults or a shared API surface, I’d be happy to open a PR.