Top New / Open menu text & icon color doesn't have enough contrast when using custom color scheme

[statik]

Hi! I am using the Peacock plugin to set some custom colors. Most of the text in the window frame around the editor adapts to this color scheme. The New / Open menu text & icon color does not adapt - I think these are special items for Positron. Is there something I should do to update the color settings for the New / Open menu text color? Thanks for your help.

When I set a color in the peacock extension, it adds these settings to my workspace .vscode/settings.json file:

{
    "workbench.colorCustomizations": {
        "activityBar.activeBackground": "#93e6fc",
        "activityBar.background": "#93e6fc",
        "activityBar.foreground": "#15202b",
        "activityBar.inactiveForeground": "#15202b99",
        "activityBarBadge.background": "#fa45d4",
        "activityBarBadge.foreground": "#15202b",
        "commandCenter.border": "#15202b99",
        "sash.hoverBorder": "#93e6fc",
        "statusBar.background": "#61dafb",
        "statusBar.foreground": "#15202b",
        "statusBarItem.hoverBackground": "#2fcefa",
        "statusBarItem.remoteBackground": "#61dafb",
        "statusBarItem.remoteForeground": "#15202b",
        "titleBar.activeBackground": "#61dafb",
        "titleBar.activeForeground": "#15202b",
        "titleBar.inactiveBackground": "#61dafb99",
        "titleBar.inactiveForeground": "#15202b99"
    },
    "peacock.color": "#61dafb"
}

Here is how Positron looks afterwards

[statik]

I noticed that the forward/back arrows on the left of the search bar also didn't change, I wonder if this is a missing setting in the peacock plugin and there is an additional colorCustomization setting that I need to set to control the colors of both the forward/back arrows and the New/Open menus.

[juliasilge]

Thank you for this report! We will investigate what may be going on here when we look into #3799 during this milestone.

What do you see using VS Code with the same theme? Does the theme behave more correctly there?

[statik]

Thanks for looking at this! Apologies it took me so long to compare against vscode. I think that vscode has the same problem, where the forward/back arrows to the left of the top search bar are not adapting between light/dark themes, while the icons in the left activity bar do toggle between light and dark versions.

I normally don't use those forward/back arrows next to the top search bar, so I never noticed the problem until using positron, and I notice it because the New | Open | 💾 menus items are something that I reach for in positron.

I am attaching a screenshot with positron in the background, and vscode in the foreground, highlighting the icons in the top bar that don't seem to be adapting to the theme.

[juliasilge]

Thanks! I opened #8385 to track and prioritize this. Since it is inherited behavior from upstream (rather than the custom UI components we make), that does make it a bit tougher to fix FYI.