Skip to content

Commit fe621e8

Browse files
authored
Shut down supervisor gracefully on SIGINT/SIGTERM (#8011)
Speculative fix for #7991. I could not reproduce with the steps in that issue, but was able to reproduce a similar situation synthetically as follows: - start with Positron with supervisor's idle shutdown timeout set to 4 hours - start R and Python, observer `kcserver` is running as part of the Positron process tree - close Positron, observe `kcserver` is now owned by `init(1)` and still running (expected) - `killall kcserver` to terminate the supervisor - now `ark` is running all by its lonesome, unsupervised (unexpected) To help prevent this from happening, this change adds signal handlers to the supervisor that cause it to send shutdown requests to the kernels it is running before it exits itself. QA team, could you review by seeing if this fixes the issue for you?
1 parent ea3eb56 commit fe621e8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

extensions/positron-supervisor/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@
150150
},
151151
"positron": {
152152
"binaryDependencies": {
153-
"kallichore": "0.1.43"
153+
"kallichore": "0.1.45"
154154
}
155155
},
156156
"extensionDependencies": [

0 commit comments

Comments
 (0)