Skip to content

Commit e2f2116

Browse files
committed
Use JEP 92 for supported features
1 parent dd713ec commit e2f2116

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

crates/amalthea/src/wire/kernel_info_reply.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ pub struct KernelInfoReplyFull {
4141
/// Version of messaging protocol
4242
pub protocol_version: String,
4343

44-
/// Unofficial feature flag to indicate that the kernel implements JEP 65.
45-
pub support_iopub_welcome: bool,
44+
/// List of feature flags supported by the kernel. See JEP 92.
45+
pub supported_features: Vec<String>,
4646

4747
/// The execution status ("ok" or "error")
4848
pub status: Status,
@@ -72,7 +72,7 @@ impl From<KernelInfoReply> for KernelInfoReplyFull {
7272
Self {
7373
// These fields are set by Amalthea
7474
protocol_version: String::from("5.4"),
75-
support_iopub_welcome: true,
75+
supported_features: vec![String::from("iopub_welcome")],
7676

7777
// These fields are set by the Amalthea user
7878
status: value.status,

crates/amalthea/tests/client.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@ fn test_amalthea_kernel_info() {
3838
frontend.recv_shell(),
3939
Message::KernelInfoReply(reply) => {
4040
assert_eq!(reply.content.language_info.name, "Test");
41+
assert_eq!(reply.content.protocol_version, "5.4");
42+
assert!(reply.content.supported_features.contains(&String::from("iopub_welcome")));
4143
}
4244
);
4345

0 commit comments

Comments
 (0)