Collect document symbols in arguments

Author: lionel-

crates/ark/src/lsp/snapshots/ark__lsp__symbols__tests__symbol_call_arguments.snap

@@ -0,0 +1,69 @@
+---
+source: crates/ark/src/lsp/symbols.rs
+expression: "test_symbol(\"\n# section ----\nlocal({\n    a <- function() {\n        1\n    }\n})\n\")"
+---
+[
+    DocumentSymbol {
+        name: "section",
+        detail: None,
+        kind: String,
+        tags: None,
+        deprecated: None,
+        range: Range {
+            start: Position {
+                line: 1,
+                character: 0,
+            },
+            end: Position {
+                line: 6,
+                character: 2,
+            },
+        },
+        selection_range: Range {
+            start: Position {
+                line: 1,
+                character: 0,
+            },
+            end: Position {
+                line: 6,
+                character: 2,
+            },
+        },
+        children: Some(
+            [
+                DocumentSymbol {
+                    name: "a",
+                    detail: Some(
+                        "function()",
+                    ),
+                    kind: Function,
+                    tags: None,
+                    deprecated: None,
+                    range: Range {
+                        start: Position {
+                            line: 3,
+                            character: 4,
+                        },
+                        end: Position {
+                            line: 5,
+                            character: 5,
+                        },
+                    },
+                    selection_range: Range {
+                        start: Position {
+                            line: 3,
+                            character: 4,
+                        },
+                        end: Position {
+                            line: 5,
+                            character: 5,
+                        },
+                    },
+                    children: Some(
+                        [],
+                    ),
+                },
+            ],
+        ),
+    },
+]

crates/ark/src/lsp/symbols.rs

@@ -273,13 +273,13 @@ fn collect_call(
 
     match fun_symbol.as_str() {
         "test_that" => collect_call_test_that(node, contents, symbols)?,
-        _ => collect_call_methods(node, contents, symbols)?,
+        _ => collect_call_arguments(node, contents, symbols)?,
     }
 
     Ok(())
 }
 
-fn collect_call_methods(
+fn collect_call_arguments(
     node: &Node,
     contents: &Rope,
     symbols: &mut Vec<DocumentSymbol>,
@@ -298,42 +298,57 @@ fn collect_call_methods(
         let Some(arg_value) = arg.child_by_field_name("value") else {
             continue;
         };
-        if arg_value.kind() != "function_definition" {
-            continue;
+
+        // Recurse into arguments. They might be a braced list, another call
+        // that might contain functions, etc.
+        collect_symbols(&arg_value, contents, 0, symbols)?;
+
+        if arg_value.kind() == "function_definition" {
+            // Functions are not collected by `collect_symbols()` so we deal
+            // with them here by processing the function body to extract child
+            // symbols. We do this even if it's not a "method", i.e. if it's not
+            // named.
+            let body = arg_value.child_by_field_name("body").into_result()?;
+            let mut children = Vec::new();
+            collect_symbols(&body, contents, 0, &mut children)?;
+
+            // If there is a name node, collect it as a method
+            if let Some(arg_fun) = arg.child_by_field_name("name") {
+                collect_method(&arg_fun, &arg_value, contents, symbols)?;
+            };
         }
+    }
 
-        // Process the function body to extract child symbols.
-        // We do this even if it's not a "method", i.e. if it's not named.
-        let body = arg_value.child_by_field_name("body").into_result()?;
-        let mut children = Vec::new();
-        collect_symbols(&body, contents, 0, &mut children)?;
+    Ok(())
+}
 
-        // There must be a name node, we're only collecting named functions as methods
-        let Some(arg_name) = arg.child_by_field_name("name") else {
-            continue;
-        };
-        if !arg_name.is_identifier_or_string() {
-            continue;
-        }
-        let arg_name_str = contents.node_slice(&arg_name)?.to_string();
+fn collect_method(
+    arg_fun: &Node,
+    arg_value: &Node,
+    contents: &Rope,
+    symbols: &mut Vec<DocumentSymbol>,
+) -> anyhow::Result<()> {
+    if !arg_fun.is_identifier_or_string() {
+        return Ok(());
+    }
+    let arg_name_str = contents.node_slice(&arg_fun)?.to_string();
 
-        let start = convert_point_to_position(contents, arg_value.start_position());
-        let end = convert_point_to_position(contents, arg_value.end_position());
+    let start = convert_point_to_position(contents, arg_value.start_position());
+    let end = convert_point_to_position(contents, arg_value.end_position());
 
-        let mut symbol = new_symbol_node(
-            arg_name_str,
-            SymbolKind::METHOD,
-            Range { start, end },
-            vec![],
-        );
+    let mut symbol = new_symbol_node(
+        arg_name_str,
+        SymbolKind::METHOD,
+        Range { start, end },
+        vec![],
+    );
 
-        // Don't include whole function as detail as the body often doesn't
-        // provide useful information and only make the outline more busy (with
-        // curly braces, newline characters, etc).
-        symbol.detail = Some(String::from("function()"));
+    // Don't include whole function as detail as the body often doesn't
+    // provide useful information and only make the outline more busy (with
+    // curly braces, newline characters, etc).
+    symbol.detail = Some(String::from("function()"));
 
-        symbols.push(symbol);
-    }
+    symbols.push(symbol);
 
     Ok(())
 }
@@ -766,11 +781,18 @@ list(
 "
         ));
     }
-}
 
-// chat <- r6::r6class(
-//   "chat",
-//   public = list(
-//     initialize = function() "initialize",
-//  )
-//     )
+    #[test]
+    fn test_symbol_call_arguments() {
+        insta::assert_debug_snapshot!(test_symbol(
+            "
+# section ----
+local({
+    a <- function() {
+        1
+    }
+})
+"
+        ));
+    }
+}