Fix tests on Windows

`lsp_types::Url::from_file_path()` returns `None` if not a valid path.
Path should start with e.g. `C:\` on Windows.

Author: lionel-

crates/ark/src/lsp/definitions.rs

@@ -78,14 +78,13 @@ pub fn goto_definition<'a>(
 
 #[cfg(test)]
 mod tests {
-    use std::path::PathBuf;
-
     use assert_matches::assert_matches;
     use tower_lsp::lsp_types;
 
     use super::*;
     use crate::lsp::documents::Document;
     use crate::lsp::indexer;
+    use crate::lsp::util::test_path;
 
     #[test]
     fn test_goto_definition() {
@@ -96,15 +95,13 @@ foo <- 42
 print(foo)
 "#;
         let doc = Document::new(code, None);
-        let path = PathBuf::from("/foo/test.R");
+        let (path, uri) = test_path();
 
         indexer::update(&doc, &path).unwrap();
 
         let params = GotoDefinitionParams {
             text_document_position_params: lsp_types::TextDocumentPositionParams {
-                text_document: lsp_types::TextDocumentIdentifier {
-                    uri: Url::from_file_path(&path).unwrap(),
-                },
+                text_document: lsp_types::TextDocumentIdentifier { uri },
                 position: lsp_types::Position::new(2, 7),
             },
             work_done_progress_params: Default::default(),
@@ -114,9 +111,6 @@ print(foo)
         assert_matches!(
             goto_definition(&doc, params).unwrap(),
             Some(GotoDefinitionResponse::Link(ref links)) => {
-                assert!(!links.is_empty());
-                assert_eq!(links[0].target_uri, Url::from_file_path(&path).unwrap());
-
                 assert_eq!(
                     links[0].target_range,
                     lsp_types::Range {
@@ -138,14 +132,13 @@ foo <- 1
 print(foo)
 "#;
         let doc = Document::new(code, None);
-        let path = PathBuf::from("/foo/section_test.R");
+        let (path, uri) = test_path();
+
         indexer::update(&doc, &path).unwrap();
 
         let params = lsp_types::GotoDefinitionParams {
             text_document_position_params: lsp_types::TextDocumentPositionParams {
-                text_document: lsp_types::TextDocumentIdentifier {
-                    uri: lsp_types::Url::from_file_path(&path).unwrap(),
-                },
+                text_document: lsp_types::TextDocumentIdentifier { uri },
                 position: lsp_types::Position::new(3, 7),
             },
             work_done_progress_params: Default::default(),
@@ -155,14 +148,6 @@ print(foo)
         assert_matches!(
             goto_definition(&doc, params).unwrap(),
             Some(lsp_types::GotoDefinitionResponse::Link(ref links)) => {
-                assert!(!links.is_empty());
-
-                let link = &links[0];
-                assert_eq!(
-                    link.target_uri,
-                    lsp_types::Url::from_file_path(&path).unwrap()
-                );
-
                 // The section should is not the target, the variable has priority
                 assert_eq!(
                     links[0].target_range,

crates/ark/src/lsp/symbols.rs

@@ -587,6 +587,7 @@ mod tests {
     use crate::lsp::config::WorkspaceSymbolsConfig;
     use crate::lsp::documents::Document;
     use crate::lsp::indexer::ResetIndexerGuard;
+    use crate::lsp::util::test_path;
 
     fn test_symbol(code: &str) -> Vec<DocumentSymbol> {
         let doc = Document::new(code, None);
@@ -914,7 +915,8 @@ a <- function() {
 
             // Index the document
             let doc = Document::new(code, None);
-            indexer::update(&doc, std::path::Path::new("/test.R")).unwrap();
+            let (path, _) = test_path();
+            indexer::update(&doc, &path).unwrap();
 
             // Query for all symbols
             let params = WorkspaceSymbolParams {

crates/ark/src/lsp/util.rs

@@ -28,3 +28,17 @@ pub unsafe extern "C-unwind" fn ps_object_id(object: SEXP) -> anyhow::Result<SEX
     let value = format!("{:p}", object);
     return Ok(Rf_mkString(value.as_ptr() as *const c_char));
 }
+
+#[cfg(test)]
+pub(crate) fn test_path() -> (std::path::PathBuf, url::Url) {
+    use std::path::PathBuf;
+
+    let path = if cfg!(windows) {
+        PathBuf::from(r"C:\test.R")
+    } else {
+        PathBuf::from("/test.R")
+    };
+    let uri = url::Url::from_file_path(&path).unwrap();
+
+    (path, uri)
+}