Skip to content

Bug with constraint solving default #172

@SeanTAllen

Description

@SeanTAllen

In constraint.pony:

      try
        Constraints._parse_constraints(version)?
        "main" // Is a constraint: use main until update.
      else

that default, will fail entirely if the branch doesn't exist. Given that GitHub is making it easy to switch default branch names, this is highly problematic. Our tests for constraints fail if the repo being pulled doesn't have said branch. Which is problematic given the constraint exists. This is a bug that should be fixed.

To reproduce, change that "main" to a non-existent branch in our corral-test-repo (e.g. free-candy-branch) and run the integration tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is neededtriggers releaseMajor issue that when fixed, results in an "emergency" release

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions