Skip to content

Replace pdfkit with weasyprint #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisl8 opened this issue Jul 23, 2024 · 1 comment
Open

Replace pdfkit with weasyprint #44

chrisl8 opened this issue Jul 23, 2024 · 1 comment

Comments

@chrisl8
Copy link

chrisl8 commented Jul 23, 2024

I was able to swap out pdfkit with weasyprint pretty easily and everything still works, except with fewer errors and hopefully using non-abandoned software.

If this tool is still being maintained I think it would be cool to do that "officially".

I can make a PR with my changes when I get some time if you like.

@polo2ro
Copy link
Owner

polo2ro commented Aug 2, 2024

good idea, i was wondering if pdfkit was used anymore, dont hesitate to submit a PR if you want to persist your change in the project and if this improve conversion quality, i do not use pdfkit anyway. Just be sure to make it optional for users like me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants