Upgrade to stable2509
#951
Draft
+2,002
−1,298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandres95
changed the title
stable2509stable2509
Contributor
|
I have a PR updating the encointer-pallets ready: #965 |
Contributor
|
Added Fulu fork config: #966 |
I bumped the encointer-pallets to the polkadot-unstable-202509. However, I could not fully verify if it is correct, as the workspace still has other errors. The cargo.lock shows some dedupes for the encointer dependencies though, which is a positive sign.
Contributor
|
Bumped to re- ambassador fellowship needs |
Bumps the dependencies associated with [stable2509-1](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-stable2509-1) done with psvm -v "polkadot-stable2509-1" @pandres95
Contributor
|
Resolved dep conflicts here: #988 |
@clangenb there are a couple of Encointer errors: ``` error[E0599]: no function or associated item named `convert` found for struct `EncointerBalanceConverter` in the current scope --> /Users/claravanstaden/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/pallet-encointer-balances-20.2.1/src/impl_fungibles.rs:27:29 | 27 | EncointerBalanceConverter::convert(balance) | ^^^^^^^ function or associated item not found in `EncointerBalanceConverter` | note: there are multiple different versions of crate `sp_runtime` in the dependency graph ``` --------- Co-authored-by: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Ron <yrong1997@gmail.com> Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> Co-authored-by: Dónal Murray <donalm@seadanda.dev> Co-authored-by: Adrian Catangiu <adrian@parity.io>
This PR fixes the dependency mess that we still have in the update branch. The issues with encointer's dependencies was that we only introduced patch bumps for the stable202509 upgrade to keep being aligned with the polkadot-sdk releases (we messed up the rhythm, as the unstable branch was a major release for us). The patch bump did not propagate to our innermost dependencies in the lock file, as it was deemed compatible with the ones explicitly defined in the root toml. So this PR fixes (I believe all) of the duplicate substrate dependencies by running 1. `cargo update -p encointer-crates-at-wrong-version` 2. `psvm --version polkadot-stable2509-1`
# Conflicts: # CHANGELOG.md # Cargo.lock # Cargo.toml # relay/kusama/src/lib.rs # relay/polkadot/src/lib.rs # system-parachains/asset-hubs/asset-hub-kusama/src/lib.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/lib.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/weights/pallet_election_provider_multi_block.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/weights/pallet_election_provider_multi_block_signed.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/weights/pallet_election_provider_multi_block_unsigned.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/weights/pallet_election_provider_multi_block_verifier.rs # system-parachains/asset-hubs/asset-hub-polkadot/src/weights/pallet_staking_async.rs # system-parachains/bridge-hubs/bridge-hub-kusama/src/lib.rs # system-parachains/bridge-hubs/bridge-hub-polkadot/src/lib.rs # system-parachains/collectives/collectives-polkadot/src/lib.rs # system-parachains/coretime/coretime-kusama/src/lib.rs # system-parachains/coretime/coretime-polkadot/src/lib.rs # system-parachains/encointer/src/lib.rs # system-parachains/gluttons/glutton-kusama/src/lib.rs # system-parachains/people/people-kusama/src/lib.rs # system-parachains/people/people-polkadot/src/lib.rs
# Conflicts: # Cargo.lock # Cargo.toml
Merging main into the upgrade branch has messed up the dependencies again. This PR fixes them by: * cargo update -p encointer-pallets-at-wrong-version * Fixing the staking dependency that was accidentally downgraded in the Cargo.toml
Contributor
|
Ethereum mainnet Fulu fork is on 3 Dec, so need to semi-urgently get this out. 🙃 |
Contributor
can you get the Fulu fork changes into |
Contributor
|
The other thing we need to check for system chains are changes backported to AHM-related changes/fixes went into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-author: @johandroid (Candidate).
Requests
Note
I'll be adding some additional requests whenever they start appearing
stable2509(@clangenb / @brenzi).fuluchain (@claravanstaden / @bkontur).