-
Notifications
You must be signed in to change notification settings - Fork 132
[DNM] asset-hub-kusama: use inmemorydb weights #918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[DNM] asset-hub-kusama: use inmemorydb weights #918
Conversation
Modify asset-hub-kusama to use the read/write costs in validate block on validator reference hardware, since these are weights that guarantee the blocks will pass validation and make it on the relay chain. This were obtained with the benchmark created here: paritytech/polkadot-sdk#8069. Part of: paritytech/polkadot-sdk#6131 Fixes: polkadot-fellows#800 Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
|
How big of a change is this? I would like to avoid including big changes with the AHM runtime upgrade since we will do AHM Kusama very soon. |
@ggwpez, The whole point of this change is improving throughput for the SCC launch, which is after AHM migration, so I would say it can be merged after AHM Kusama happens. |
AndreiEres
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
|
if not urgent, let merge this after the AHM release. if this merged we need to adjust some weights on RC side (control flow mechanics accounting for AH weights) and test it. |
ACK, marked it as DNM so that it merges after AHM release. |
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Modify asset-hub-kusama to use the read/write costs computed in validate block on validator reference hardware, since these are weights that guarantee the blocks will pass validation and make it on the relay chain.
This were obtained with the benchmark created here: paritytech/polkadot-sdk#8069.
Part of: #800