Skip to content

Conversation

@alexggh
Copy link
Contributor

@alexggh alexggh commented Sep 22, 2025

Modify asset-hub-kusama to use the read/write costs computed in validate block on validator reference hardware, since these are weights that guarantee the blocks will pass validation and make it on the relay chain.

This were obtained with the benchmark created here: paritytech/polkadot-sdk#8069.

Part of: #800

Modify asset-hub-kusama to use the read/write costs in validate block on
validator reference hardware, since these are weights that guarantee the
blocks will pass validation and make it on the relay chain.

This were obtained with the benchmark created here: paritytech/polkadot-sdk#8069.

Part of: paritytech/polkadot-sdk#6131
Fixes: polkadot-fellows#800

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@ggwpez
Copy link
Member

ggwpez commented Sep 22, 2025

How big of a change is this? I would like to avoid including big changes with the AHM runtime upgrade since we will do AHM Kusama very soon.

@alexggh
Copy link
Contributor Author

alexggh commented Sep 22, 2025

How big of a change is this? I would like to avoid including big changes with the AHM runtime upgrade since we will do AHM Kusama very soon.

@ggwpez, The whole point of this change is improving throughput for the SCC launch, which is after AHM migration, so I would say it can be merged after AHM Kusama happens.

Copy link
Contributor

@AndreiEres AndreiEres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@muharem
Copy link
Contributor

muharem commented Sep 23, 2025

if not urgent, let merge this after the AHM release. if this merged we need to adjust some weights on RC side (control flow mechanics accounting for AH weights) and test it.

@alexggh
Copy link
Contributor Author

alexggh commented Sep 23, 2025

if not urgent, let merge this after the AHM release. if this merged we need to adjust some weights on RC side (control flow mechanics accounting for AH weights) and test it.

ACK, marked it as DNM so that it merges after AHM release.

@alexggh alexggh changed the title asset-hub-kusama: use inmemorydb weights [DNM] asset-hub-kusama: use inmemorydb weights Sep 23, 2025
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
@alexggh
Copy link
Contributor Author

alexggh commented Oct 24, 2025

@ggwpez @muharem, now that kusama migration has happened, can I move forward with this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants