Skip to content

Commit 80ac2e4

Browse files
bkchracatangiufellowship-merge-bot[bot]
authored
Let the entire job fail when one strategy fails (#529)
Before the entire job counted as success, even with individual strategies failing. <!-- Remember that you can run `/merge` to enable auto-merge in the PR --> <!-- Remember to modify the changelog. If you don't need to modify it, you can check the following box. Instead, if you have already modified it, simply delete the following line. --> - [x] Does not require a CHANGELOG entry --------- Co-authored-by: Adrian Catangiu <adrian@parity.io> Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
1 parent 9c904ee commit 80ac2e4

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/check-migrations.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,9 +44,10 @@ jobs:
4444
# if they all pass, that job will pass too.
4545
check-migrations:
4646
needs: [runtime-matrix]
47-
continue-on-error: true
4847
runs-on: ubuntu-latest
4948
strategy:
49+
# Ensure the other jobs continue
50+
fail-fast: false
5051
matrix:
5152
runtime: ${{ fromJSON(needs.runtime-matrix.outputs.runtime) }}
5253
steps:

0 commit comments

Comments
 (0)