Snowbridge - Integration test for 2-hop transfer from Ethereum to AHP to AHK (#625)

Adds a test to send Weth bridge from Ethereum to Polkadot AH to Kusama
AH, in a second transaction. This shows how we could support bridging to
Kusama in a 2-step fashion until Snowbridge V2 is released.

- [x] Does not require a CHANGELOG entry

---------

Co-authored-by: Adrian Catangiu <adrian@parity.io>

Author: claravanstaden

Cargo.lock

@@ -19,20 +19,27 @@ parachains-common = { workspace = true, default-features = true }
 cumulus-primitives-core = { workspace = true, default-features = true }
 emulated-integration-tests-common = { workspace = true }
 xcm = { workspace = true, default-features = true }
+xcm-builder = { workspace = true, default-features = true }
 polkadot-parachain-primitives = { workspace = true }
 
 # Runtimes
 asset-hub-kusama-runtime = { workspace = true }
 kusama-emulated-chain = { workspace = true }
 penpal-emulated-chain = { workspace = true }
 
+
+# Emulated tests
+integration-tests-helpers = { workspace = true }
+
 [features]
 runtime-benchmarks = [
 	"asset-hub-kusama-runtime/runtime-benchmarks",
 	"cumulus-primitives-core/runtime-benchmarks",
 	"frame-support/runtime-benchmarks",
+	"integration-tests-helpers/runtime-benchmarks",
 	"kusama-emulated-chain/runtime-benchmarks",
 	"parachains-common/runtime-benchmarks",
 	"penpal-emulated-chain/runtime-benchmarks",
 	"polkadot-parachain-primitives/runtime-benchmarks",
+	"xcm-builder/runtime-benchmarks",
 ]

integration-tests/emulated/chains/parachains/assets/asset-hub-kusama/Cargo.toml

@@ -18,11 +18,17 @@ use sp_keyring::Sr25519Keyring as Keyring;
 
 // Cumulus
 use emulated_integration_tests_common::{
-	accounts, build_genesis_storage, collators, RESERVABLE_ASSET_ID, SAFE_XCM_VERSION,
+	accounts, build_genesis_storage, collators, xcm_emulator::ConvertLocation, RESERVABLE_ASSET_ID,
+	SAFE_XCM_VERSION,
 };
 use frame_support::sp_runtime::traits::AccountIdConversion;
+use integration_tests_helpers::common::snowbridge::{
+	EthLocationXcmV4, WethLocationXcmV4, MIN_ETHER_BALANCE,
+};
 use parachains_common::{AccountId, Balance};
 use polkadot_parachain_primitives::primitives::Sibling;
+use xcm::prelude::*;
+use xcm_builder::GlobalConsensusParachainConvertsFor;
 
 pub const PARA_ID: u32 = 1000;
 pub const ED: Balance = asset_hub_kusama_runtime::ExistentialDeposit::get();
@@ -37,7 +43,12 @@ frame_support::parameter_types! {
 				xcm::v4::Junction::GeneralIndex(penpal_emulated_chain::TELEPORTABLE_ASSET_ID.into()),
 			]
 		);
+	pub UniversalLocation: InteriorLocation = [GlobalConsensus(Kusama), Parachain(PARA_ID)].into();
+	pub AssetHubPolkadotLocation: Location = Location::new(2, [GlobalConsensus(Polkadot), Parachain(1000)]);
 	pub PenpalASiblingSovereignAccount: AccountId = Sibling::from(penpal_emulated_chain::PARA_ID_A).into_account_truncating();
+	pub AssetHubPolkadotSovereignAccount: AccountId = GlobalConsensusParachainConvertsFor::<UniversalLocation, AccountId>::convert_location(
+		&AssetHubPolkadotLocation::get(),
+	).unwrap();
 }
 
 pub fn genesis() -> sp_core::storage::Storage {
@@ -92,6 +103,20 @@ pub fn genesis() -> sp_core::storage::Storage {
 					false,
 					ED,
 				),
+				// Ether
+				(
+					EthLocationXcmV4::get(),
+					AssetHubPolkadotSovereignAccount::get(),
+					true,
+					MIN_ETHER_BALANCE,
+				),
+				// Weth
+				(
+					WethLocationXcmV4::get(),
+					AssetHubPolkadotSovereignAccount::get(),
+					true,
+					MIN_ETHER_BALANCE,
+				),
 			],
 			..Default::default()
 		},

integration-tests/emulated/chains/parachains/assets/asset-hub-kusama/src/genesis.rs

@@ -26,13 +26,21 @@ asset-hub-polkadot-runtime = { workspace = true }
 polkadot-emulated-chain = { workspace = true }
 penpal-emulated-chain = { workspace = true }
 
+# Bridges
+snowbridge-router-primitives = { workspace = true, default-features = true }
+
+# Emulated tests
+integration-tests-helpers = { workspace = true }
+
 [features]
 runtime-benchmarks = [
 	"asset-hub-polkadot-runtime/runtime-benchmarks",
 	"cumulus-primitives-core/runtime-benchmarks",
 	"frame-support/runtime-benchmarks",
+	"integration-tests-helpers/runtime-benchmarks",
 	"parachains-common/runtime-benchmarks",
 	"penpal-emulated-chain/runtime-benchmarks",
 	"polkadot-emulated-chain/runtime-benchmarks",
 	"polkadot-parachain-primitives/runtime-benchmarks",
+	"snowbridge-router-primitives/runtime-benchmarks",
 ]

integration-tests/emulated/chains/parachains/assets/asset-hub-polkadot/Cargo.toml

@@ -17,12 +17,19 @@
 use sp_keyring::{Ed25519Keyring, Sr25519Keyring};
 
 // Cumulus
+use asset_hub_polkadot_runtime::xcm_config::bridging::to_ethereum::EthereumNetwork;
 use emulated_integration_tests_common::{
-	accounts, build_genesis_storage, RESERVABLE_ASSET_ID, SAFE_XCM_VERSION,
+	accounts, build_genesis_storage, xcm_emulator::ConvertLocation, RESERVABLE_ASSET_ID,
+	SAFE_XCM_VERSION,
 };
 use frame_support::sp_runtime::traits::AccountIdConversion;
+use integration_tests_helpers::common::snowbridge::{
+	EthLocationXcmV4, WethLocationXcmV4, MIN_ETHER_BALANCE,
+};
 use parachains_common::{AccountId, Balance};
 use polkadot_parachain_primitives::primitives::Sibling;
+use snowbridge_router_primitives::inbound::EthereumLocationsConverterFor;
+use xcm::prelude::*;
 
 pub const PARA_ID: u32 = 1000;
 pub const ED: Balance = asset_hub_polkadot_runtime::ExistentialDeposit::get();
@@ -46,6 +53,12 @@ frame_support::parameter_types! {
 		);
 	pub PenpalASiblingSovereignAccount: AccountId = Sibling::from(penpal_emulated_chain::PARA_ID_A).into_account_truncating();
 	pub PenpalBSiblingSovereignAccount: AccountId = Sibling::from(penpal_emulated_chain::PARA_ID_B).into_account_truncating();
+	pub EthereumSovereignAccount: AccountId = EthereumLocationsConverterFor::<AccountId>::convert_location(
+		&Location::new(
+			2,
+			[GlobalConsensus(EthereumNetwork::get())],
+		),
+	).unwrap();
 }
 
 pub mod collators {
@@ -120,6 +133,15 @@ pub fn genesis() -> sp_core::storage::Storage {
 					false,
 					ED,
 				),
+				// Ether
+				(EthLocationXcmV4::get(), EthereumSovereignAccount::get(), true, MIN_ETHER_BALANCE),
+				// Weth
+				(
+					WethLocationXcmV4::get(),
+					EthereumSovereignAccount::get(),
+					true,
+					MIN_ETHER_BALANCE,
+				),
 			],
 			..Default::default()
 		},

integration-tests/emulated/chains/parachains/assets/asset-hub-polkadot/src/genesis.rs

@@ -9,8 +9,10 @@ publish = false
 
 [dependencies]
 paste = { workspace = true }
+hex-literal = { workspace = true }
 
 # Substrate
+frame-support = { workspace = true, default-features = true }
 pallet-balances = { workspace = true, default-features = true }
 pallet-message-queue = { workspace = true, default-features = true }
 
@@ -26,6 +28,7 @@ asset-test-utils = { workspace = true }
 [features]
 runtime-benchmarks = [
 	"cumulus-pallet-xcmp-queue/runtime-benchmarks",
+	"frame-support/runtime-benchmarks",
 	"pallet-balances/runtime-benchmarks",
 	"pallet-message-queue/runtime-benchmarks",
 	"pallet-xcm/runtime-benchmarks",

integration-tests/emulated/helpers/Cargo.toml

@@ -0,0 +1,31 @@
+// Copyright (C) Parity Technologies (UK) Ltd.
+// SPDX-License-Identifier: Apache-2.0
+
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// 	http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+pub mod snowbridge {
+	use hex_literal::hex;
+	use xcm_emulator::parameter_types;
+
+	// Weth (Wrapped Ether) contract address on Ethereum mainnet.
+	pub const WETH: [u8; 20] = hex!("c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2");
+	// The minimum Ether balance required for an account to exist. Matches value on Polkadot
+	// mainnet.
+	pub const MIN_ETHER_BALANCE: u128 = 15_000_000_000_000;
+
+	parameter_types! {
+		pub EthereumNetworkXcmV4: xcm::v4::NetworkId = xcm::v4::NetworkId::Ethereum { chain_id: 1 };
+		pub WethLocationXcmV4: xcm::v4::Location =  xcm::v4::Location::new(2, [xcm::v4::Junction::GlobalConsensus(EthereumNetworkXcmV4::get()), xcm::v4::Junction::AccountKey20 { network: None, key: WETH }]);
+		pub EthLocationXcmV4: xcm::v4::Location =  xcm::v4::Location::new(2, [xcm::v4::Junction::GlobalConsensus(EthereumNetworkXcmV4::get())]);
+	}
+}

integration-tests/emulated/helpers/src/common.rs

@@ -28,6 +28,8 @@ pub use asset_test_utils;
 pub use cumulus_pallet_xcmp_queue;
 pub use xcm_emulator::Chain;
 
+pub mod common;
+
 /// TODO: when bumping to polkadot-sdk v1.8.0,
 /// remove this crate altogether and get the macros from `emulated-integration-tests-common`.
 /// TODO: backport this macros to polkadot-sdk

integration-tests/emulated/helpers/src/lib.rs

@@ -44,6 +44,7 @@ pub use emulated_integration_tests_common::{
 	xcm_helpers::{xcm_transact_paid_execution, xcm_transact_unpaid_execution},
 	ASSETS_PALLET_ID, PROOF_SIZE_THRESHOLD, REF_TIME_THRESHOLD, XCM_V4,
 };
+pub use integration_tests_helpers::common::snowbridge::{MIN_ETHER_BALANCE, WETH};
 pub use kusama_polkadot_system_emulated_network::{
 	asset_hub_kusama_emulated_chain::{
 		genesis::ED as ASSET_HUB_KUSAMA_ED, AssetHubKusamaParaPallet as AssetHubKusamaPallet,

integration-tests/emulated/tests/bridges/bridge-hub-polkadot/src/lib.rs

@@ -14,6 +14,9 @@
 // limitations under the License.
 
 use crate::tests::*;
+use bp_bridge_hub_polkadot::snowbridge::EthereumNetwork;
+use snowbridge_router_primitives::inbound::EthereumLocationsConverterFor;
+use xcm_executor::traits::ConvertLocation;
 
 fn send_assets_over_bridge<F: FnOnce()>(send_fn: F) {
 	// fund the PAH's SA on PBH for paying bridge transport fees
@@ -183,7 +186,7 @@ fn send_dot_usdt_and_weth_from_asset_hub_polkadot_to_asset_hub_kusama() {
 	let receiver_dot_after =
 		foreign_balance_on_ah_kusama(bridged_dot_at_asset_hub_kusama, &receiver);
 	let dot_in_reserve_on_pah_after =
-		<AssetHubPolkadot as Chain>::account_data_of(sov_kah_on_pah).free;
+		<AssetHubPolkadot as Chain>::account_data_of(sov_kah_on_pah.clone()).free;
 
 	// Sender's balance is reduced
 	assert!(sender_dot_before > sender_dot_after);
@@ -203,20 +206,27 @@ fn send_dot_usdt_and_weth_from_asset_hub_polkadot_to_asset_hub_kusama() {
 	let bridged_weth_at_ah = weth_at_asset_hubs();
 	let bridged_weth_at_ah_latest: Location = bridged_weth_at_ah.clone().try_into().unwrap();
 
+	let snowbridge_sovereign: AccountId =
+		EthereumLocationsConverterFor::<[u8; 32]>::convert_location(&Location::new(
+			2,
+			[GlobalConsensus(EthereumNetwork::get())],
+		))
+		.unwrap()
+		.into();
+
 	// mint USDT in sender's account (USDT already created in genesis)
 	AssetHubPolkadot::mint_asset(
 		<AssetHubPolkadot as Chain>::RuntimeOrigin::signed(AssetHubPolkadotAssetOwner::get()),
 		USDT_ID,
 		sender.clone(),
 		amount * 2,
 	);
-	// create wETH at src and dest and prefund sender's account
-	create_foreign_on_ah_polkadot(
+	AssetHubPolkadot::mint_foreign_asset(
+		<AssetHubPolkadot as Chain>::RuntimeOrigin::signed(snowbridge_sovereign),
 		bridged_weth_at_ah.clone(),
-		true,
-		vec![(sender.clone(), amount * 2)],
+		sender.clone(),
+		MIN_ETHER_BALANCE,
 	);
-	create_foreign_on_ah_kusama(bridged_weth_at_ah.clone(), true);
 	create_foreign_on_ah_kusama(bridged_usdt_at_asset_hub_kusama.clone(), true);
 	set_up_pool_with_ksm_on_ah_kusama(bridged_usdt_at_asset_hub_kusama.clone(), true);
 
@@ -227,7 +237,7 @@ fn send_dot_usdt_and_weth_from_asset_hub_polkadot_to_asset_hub_kusama() {
 	// send USDTs and wETHs
 	let assets: Assets = vec![
 		(usdt_at_asset_hub_polkadot_latest.clone(), amount).into(),
-		(bridged_weth_at_ah_latest.clone(), amount).into(),
+		(bridged_weth_at_ah_latest.clone(), MIN_ETHER_BALANCE).into(),
 	]
 	.into();
 	// use USDT for fees
@@ -265,7 +275,7 @@ fn send_dot_usdt_and_weth_from_asset_hub_polkadot_to_asset_hub_kusama() {
 	assert!(receiver_usdts_after > receiver_usdts_before);
 	assert!(receiver_usdts_after < receiver_usdts_before + amount);
 	// Receiver's wETH balance is increased by sent amount
-	assert_eq!(receiver_weth_after, receiver_weth_before + amount);
+	assert_eq!(receiver_weth_after, receiver_weth_before + MIN_ETHER_BALANCE);
 }
 
 #[test]