Add AppendEmptyValue to opt builders (#969)

Author: brancz

pqarrow/builder/optbuilders.go

@@ -151,6 +151,13 @@ func (b *OptBinaryBuilder) AppendNull() {
 	b.builderBase.AppendNulls(1)
 }
 
+// AppendEmptyValue adds a new empty byte slice to the array being built.
+func (b *OptBinaryBuilder) AppendEmptyValue() {
+	b.offsets = append(b.offsets, uint32(len(b.data)))
+	// Don't append any data, just close the offset for an empty slice
+	b.appendValid(1)
+}
+
 // AppendNulls appends n null values to the array being built. This is specific
 // to distinct optimizations in FrostDB.
 func (b *OptBinaryBuilder) AppendNulls(n int) {
@@ -322,6 +329,11 @@ func (b *OptInt64Builder) AppendNull() {
 	b.AppendNulls(1)
 }
 
+// AppendEmptyValue adds a new zero value (0) to the array being built.
+func (b *OptInt64Builder) AppendEmptyValue() {
+	b.Append(0)
+}
+
 func (b *OptInt64Builder) AppendNulls(n int) {
 	b.resizeData(b.length + n)
 	b.builderBase.AppendNulls(n)
@@ -435,6 +447,11 @@ func (b *OptBooleanBuilder) AppendNull() {
 	b.AppendNulls(1)
 }
 
+// AppendEmptyValue adds a new zero value (false) to the array being built.
+func (b *OptBooleanBuilder) AppendEmptyValue() {
+	b.AppendSingle(false)
+}
+
 func (b *OptBooleanBuilder) AppendNulls(n int) {
 	v := b.length + n
 	b.data = resizeBitmap(b.data, v)
@@ -566,6 +583,11 @@ func (b *OptInt32Builder) AppendNull() {
 	b.AppendNulls(1)
 }
 
+// AppendEmptyValue adds a new zero value (0) to the array being built.
+func (b *OptInt32Builder) AppendEmptyValue() {
+	b.Append(0)
+}
+
 func (b *OptInt32Builder) AppendNulls(n int) {
 	b.resizeData(b.length + n)
 	b.builderBase.AppendNulls(n)
@@ -702,6 +724,11 @@ func (b *OptFloat64Builder) AppendNull() {
 	b.AppendNulls(1)
 }
 
+// AppendEmptyValue adds a new zero value (0.0) to the array being built.
+func (b *OptFloat64Builder) AppendEmptyValue() {
+	b.Append(0.0)
+}
+
 func (b *OptFloat64Builder) AppendNulls(n int) {
 	b.resizeData(b.length + n)
 	b.builderBase.AppendNulls(n)

pqarrow/builder/optbuilders_test.go

@@ -169,3 +169,70 @@ func TestOptBinaryBuilder_Value(t *testing.T) {
 		require.Equal(t, value, string(b.Value(i)))
 	}
 }
+
+func TestAppendEmptyValue(t *testing.T) {
+	t.Run("OptBinaryBuilder", func(t *testing.T) {
+		b := builder.NewOptBinaryBuilder(arrow.BinaryTypes.Binary)
+		b.AppendEmptyValue()
+		require.Equal(t, 1, b.Len())
+		require.True(t, b.IsValid(0))
+		require.Len(t, b.Value(0), 0) // Empty value should have length 0
+
+		arr := b.NewArray().(*array.Binary)
+		require.Equal(t, 1, arr.Len())
+		require.False(t, arr.IsNull(0))
+		require.Len(t, arr.Value(0), 0) // Empty value should have length 0
+	})
+
+	t.Run("OptInt64Builder", func(t *testing.T) {
+		b := builder.NewOptInt64Builder(arrow.PrimitiveTypes.Int64)
+		b.AppendEmptyValue()
+		require.Equal(t, 1, b.Len())
+		require.True(t, b.IsValid(0))
+		require.Equal(t, int64(0), b.Value(0))
+
+		arr := b.NewArray().(*array.Int64)
+		require.Equal(t, 1, arr.Len())
+		require.False(t, arr.IsNull(0))
+		require.Equal(t, int64(0), arr.Value(0))
+	})
+
+	t.Run("OptInt32Builder", func(t *testing.T) {
+		b := builder.NewOptInt32Builder(arrow.PrimitiveTypes.Int32)
+		b.AppendEmptyValue()
+		require.Equal(t, 1, b.Len())
+		require.True(t, b.IsValid(0))
+		require.Equal(t, int32(0), b.Value(0))
+
+		arr := b.NewArray().(*array.Int32)
+		require.Equal(t, 1, arr.Len())
+		require.False(t, arr.IsNull(0))
+		require.Equal(t, int32(0), arr.Value(0))
+	})
+
+	t.Run("OptFloat64Builder", func(t *testing.T) {
+		b := builder.NewOptFloat64Builder(arrow.PrimitiveTypes.Float64)
+		b.AppendEmptyValue()
+		require.Equal(t, 1, b.Len())
+		require.True(t, b.IsValid(0))
+		require.Equal(t, 0.0, b.Value(0))
+
+		arr := b.NewArray().(*array.Float64)
+		require.Equal(t, 1, arr.Len())
+		require.False(t, arr.IsNull(0))
+		require.Equal(t, 0.0, arr.Value(0))
+	})
+
+	t.Run("OptBooleanBuilder", func(t *testing.T) {
+		b := builder.NewOptBooleanBuilder(arrow.FixedWidthTypes.Boolean)
+		b.AppendEmptyValue()
+		require.Equal(t, 1, b.Len())
+		require.True(t, b.IsValid(0))
+		require.Equal(t, false, b.Value(0))
+
+		arr := b.NewArray().(*array.Boolean)
+		require.Equal(t, 1, arr.Len())
+		require.False(t, arr.IsNull(0))
+		require.Equal(t, false, arr.Value(0))
+	})
+}