Pods::duplicate() doesn't clear object cache

[lougreenwood]

I have some method which duplicates some records when the user performs some action.

When the user has performed this action, I expect these duplicated records to appear in the UI.

Instead, when object caching (via Redis) is enabled, after the user has performed their action, the results don't show in my front end until I manually flush the Redis cache.

It seems this is possibly a bug specific to the pods::duplicate() method, since creating/updating records using pods pods::add() & pods::save() appear to correctly clear the object cache.

[lougreenwood]

@sc0ttkclark can't confirm without more testing, but I suspect that taxonomy term's ::save() method may also have the same issue...

[JoryHogeveen]

@sc0ttkclark
Could this have anything with the clear_slug_cache parameter (or track_changed_fields parameter)? It's not set by default on PodsAPI::duplicate_pod_item.

See:

• track_changed_fields: https://github.com/pods-framework/pods/blob/release/2.7/classes/PodsAPI.php#L3096-L3114
• clear_slug_cache: https://github.com/pods-framework/pods/blob/release/2.7/classes/PodsAPI.php#L3829-L3835

All other cache removal seems to be triggered on each save action (which is triggered by duplicating).

[szepeviktor]

the results don't show in my front end until I manually flush the Redis cache.

I may have been ran into this when created a Custom Settings Page and used wp-redis object cache.

The values are not updated on save.

As I was drilling down, I've noticed some Pods transients - maybe these transients are the cause.

[sc0ttkclark]

This might have been fixed by some other fixes to how the duplicate process runs. Can you retest on release/2.7 to confirm this is still a problem? @lougreenwood

[lougreenwood]

hey @sc0ttkclark I haven't had a chance to re-test the problem, but it seem that I am actually able to trigger it with ::add(). The steps to reproduce look like this:

• Perform a ::find() against some Pod
• Add some post to that Pod
• Perform another ::find() against that Pod
• See that the new post isn't returned in the result.

Pods cache mode is 'transitent' and expires in 1 hour. Using Redis for caching.

If I add \wp_cache_flush(); after my pods::add() call, then the subsequent ::find() includes the new record, but obviously this is slow because it invalidates the entire cache, rather than the cache for a specific Pod...

[szepeviktor]

+1 for always using Redis!