Bug: Inserting new fields

[raptor235]

When inserting new fields into a table based post_type if you enter two fields with the same slug the process will die as expected... however some of the fields will get created in the db table structure but the pod won't save them... when you refresh the pod will be empty and table structure will have been partially changed till it go to the duplicate field.

[quasel]

Reproduced

• existing table_storage CPT
• add fields with same name e.g. test
• add any new field afterwards
• save
• get error msg
• reload page
• no new fields in the edit UI, but the DB has a new column for the first duplicated field test
• try to add the test field again
• error because the column already exists e.g
  Cannot create new field; SQL: ALTER TABLE wp_pods_real_table_storageADD COLUMNtest VARCHAR(255); Response: Duplicate column name 'test'

[sc0ttkclark]

Yeah this one is tricky because we don't do safety checks during the new pod / save multiple fields process. It should:

• Check if the fields exist already in the configs
• Check if the columns exist already in the table
• Only then, continue to process the multiple fields saving to config