Don’t sanitize Pods Whatsit objects in pods_sanitize() of params through PodsAPI handling

This will allow those objects to be properly used to save on DB/API method calls

Author: sc0ttkclark

classes/PodsAPI.php

@@ -6504,9 +6504,9 @@ public function duplicate_pod( $params, $strict = false ) {
 				$params = array( 'name' => $params );
 			}
 
-			$params = (object) pods_sanitize( $params );
+			$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 		} else {
-			$params = (object) pods_sanitize( $params );
+			$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 		}
 
 		$pod = $this->load_pod( $params, false );
@@ -6649,9 +6649,9 @@ public function duplicate_group( $params, $strict = false ) {
 				$params = array( 'name' => $params );
 			}
 
-			$params = (object) pods_sanitize( $params );
+			$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 		} else {
-			$params = (object) pods_sanitize( $params );
+			$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 		}
 
 		if ( ! empty( $params->pod_id ) ) {
@@ -6660,7 +6660,7 @@ public function duplicate_group( $params, $strict = false ) {
 			$load_params['pod'] = $params->pod;
 		}
 
-		$group = $this->load_group( $params, false );
+		$group = $this->load_group( $load_params, false );
 
 		if ( empty( $group ) ) {
 			if ( false !== $strict ) {
@@ -6757,7 +6757,7 @@ public function duplicate_field( $params, $strict = false ) {
 			}
 		}
 
-		$params = (object) pods_sanitize( $params );
+		$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 
 		$load_params = array();
 
@@ -6831,7 +6831,7 @@ public function duplicate_field( $params, $strict = false ) {
 	 */
 	public function duplicate_pod_item( $params ) {
 
-		$params = (object) pods_sanitize( $params );
+		$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 
 		$load_pod_params = array(
 			'name' => $params->pod,
@@ -7222,7 +7222,7 @@ private function export_pod_item_level( $pod, $params ) {
 	 */
 	public function reorder_pod_item( $params ) {
 
-		$params = (object) pods_sanitize( $params );
+		$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 
 		if ( null === pods_v( 'pod', $params, null, true ) ) {
 			return pods_error( __( '$params->pod is required', 'pods' ), $this );
@@ -7289,7 +7289,7 @@ public function reset_pod( $params, $pod = false ) {
 		}
 
 		if ( is_array( $params ) || is_object( $params ) ) {
-			$params = (object) pods_sanitize( $params );
+			$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 		} else {
 			$params = new stdClass();
 		}
@@ -7434,7 +7434,7 @@ public function delete_pod( $params, $strict = false, $delete_all = false ) {
 		global $wpdb;
 
 		if ( is_array( $params ) || is_object( $params ) ) {
-			$params = (object) pods_sanitize( $params );
+			$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 		} else {
 			$params = new stdClass();
 		}
@@ -7740,9 +7740,9 @@ public function delete_group( $params, $strict = false, $delete_all = false ) {
 				$params = [ 'name' => $params ];
 			}
 
-			$params = (object) pods_sanitize( $params );
+			$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 		} else {
-			$params = (object) pods_sanitize( $params );
+			$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 		}
 
 		if ( ! isset( $params->delete_all ) ) {
@@ -8285,7 +8285,7 @@ public function pod_exists( $params, $type = null ) {
 			$params = array( 'name' => $params );
 		}
 
-		$params = (object) pods_sanitize( $params );
+		$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 
 		if ( ! empty( $params->id ) || ! empty( $params->name ) ) {
 			if ( ! isset( $params->name ) ) {
@@ -9341,7 +9341,7 @@ public function load_helpers( $params = null ) {
 	 */
 	public function load_pod_item( $params ) {
 
-		$params = (object) pods_sanitize( $params );
+		$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 
 		if ( ! isset( $params->pod ) || empty( $params->pod ) ) {
 			return pods_error( __( 'Pod name required', 'pods' ), $this );
@@ -9386,7 +9386,7 @@ public function load_pod_item( $params ) {
 	 */
 	public function load_sister_fields( $params, $pod = null ) {
 
-		$params = (object) pods_sanitize( $params );
+		$params = (object) pods_sanitize( $params, [ 'allow_pods_objects' => true ] );
 
 		if ( empty( $pod ) ) {
 			$pod = $this->load_pod( array( 'name' => $params->pod ), false );

includes/data.php

@@ -26,9 +26,10 @@ function pods_sanitize( $input, $params = array() ) {
 	$output = array();
 
 	$defaults = array(
-		'nested' => false,
-		'type'   => null,
+		'nested'             => false,
+		'type'               => null,
 		// %s %d %f etc
+		'allow_pods_objects' => false,
 	);
 
 	if ( ! is_array( $params ) ) {
@@ -40,6 +41,10 @@ function pods_sanitize( $input, $params = array() ) {
 	}
 
 	if ( is_object( $input ) ) {
+		if ( $params['allow_pods_objects'] && $input instanceof Whatsit ) {
+			return $input;
+		}
+
 		$input = get_object_vars( $input );
 
 		$n_params           = $params;