Pods 3.3 (#7398)

Author: sc0ttkclark

.env.testing.slic

@@ -5,6 +5,9 @@ PODS_REBUILD_DATA=false
 # Set this back to "pods" when done testing
 PODS_ROOT_FOLDER="pods"
 
+# Workaround for slic / testing not supporting 6.3+
+PODS_WP_VERSION_MINIMUM="6.1"
+
 # This file will be consumed by both the CI and the tests.
 # Some environment variables might not apply to one but might apply to the other: modify with care.
 

.github/workflows/build-zip.yml

@@ -0,0 +1,23 @@
+name: Build ZIP for new release
+on:
+  release:
+    types:
+      - published
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout files
+        uses: actions/checkout@v4
+      - name: Create zip
+        run: |
+          git archive --format=zip --worktree-attributes -9 -o ${{ github.event.repository.name }}.zip HEAD
+          unzip -d ${{ github.event.repository.name }} ${{ github.event.repository.name }}.zip
+          zip -9 -r ${{ github.event.repository.name }}.${{ github.ref_name }}.zip ${{ github.event.repository.name }}
+      - name: Add asset to release
+        uses: softprops/action-gh-release@v1
+        if: startsWith(github.ref, 'refs/tags/')
+        with:
+          files: ${{ github.event.repository.name }}.${{ github.ref_name }}.zip
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

changelog.txt

@@ -2,9 +2,28 @@ Found a bug? Have a great feature idea? Get on GitHub and tell us about it and w
 
 Our GitHub has the full list of all prior releases of Pods: https://github.com/pods-framework/pods/releases
 
+= 3.3 - May 1st, 2025 =
+
+* New minimum WP version required: WordPress 6.3+ (previously: WP 6.0+)
+* Removed: PHP support for Pod Templates and Pod Pages has been officially removed from Pods. This feature was deprecated in Pods 2.3. We recommend you follow the newer more secure way: https://docs.pods.io/displaying-pods/pod-page-template-hierarchy-for-themes/ and https://docs.pods.io/displaying-pods/pod-template-hierarchy-for-themes/ and a snippet if you absolutely still need PHP support for now https://gist.github.com/sc0ttkclark/35a15e6f93622c45f12d671184fb1315 (@sc0ttkclark)
+* Feature: Form validation for the Block Editor now prevents saving a post if there are required fields and shows the appropriate error message. #7343 #7369 (@JoryHogeveen, @sc0ttkclark)
+* Feature: Upgraded Pods Blocks to the WP Blocks API version 3 to support more feautres like block wrapper attributes and the iframe editor. (@sc0ttkclark)
+* Feature: Added support for WYSIWYG field type when using the TinyMCE editor to allow Delayed initialization and not showing the editor until clicking. This is optional and can be enabled per field. (@sc0ttkclark)
+* Feature: Added support for WYSIWYG field type when using the TinyMCE editor to refresh the editor if you encounter compatibility issues with other plugins on load. (@sc0ttkclark)
+* Tweak: Allow forcing `pods_serial_comma()` to use exactly what is sent instead of relying on the field config itself. (@sc0ttkclark)
+* Tweak: Remove Pods Pro WPGraphQL deactivation message to support future features there. The core functionality of that was merged into Pods 2.9 but new work is still being done in the add-on. (@sc0ttkclark)
+* Tweak: Pods Forms now wrap `div` / `p` form output types within a new `div.pods-form-fieldset` wrapper element. The table form output type has the new class `pods-form-fieldset` added to it too. (@sc0ttkclark)
+* Fixed: Prevent doing it wrong notices in WP from unintentionally loading translatable strings too early. (@sc0ttkclark)
+* Fixed: Improved PHP compatibiltiy with strlen() usage. #7394 (@lbonomo, @sc0ttkclark)
+* Fixed: More PHP 8.x compatibility fixes for `PodsUI`. (@sc0ttkclark)
+* Fixed: Docs link for Date / Time field type now points to the correct URL. #7405 (@BrookeDot)
+* Fixed: Remove unnecessary duplicate IDs in the fetching within `Pods::field()`. (@sc0ttkclark)
+* Fixed: Name check handling when duplicating pod now works as expected and prevents weirdly named duplicate pod names. (@sc0ttkclark)
+* Tooling: Generate build provenance attestation during deployment for .org zip. #7419 (@johnbillion)
+
 = 3.2.8.2 - February 7th, 2025 =
 
-* Security: Do not allow using custom SQL clauses for Relationship fields when SQL clauses are disabled in the Pods security settings. Props to the CleanTalk / Dmitrii Ignatyev for responsibly reporting this. (@sc0ttkclark) 
+* Security: Do not allow using custom SQL clauses for Relationship fields when SQL clauses are disabled in the Pods security settings. Props to the CleanTalk / Dmitrii Ignatyev for responsibly reporting this. (@sc0ttkclark)
 
 = 3.2.8.1 - November 22nd, 2024 =
 
@@ -108,7 +127,7 @@ To be safe and sure that those who are using Pods do not mistake Pods 3.2.3 as a
 * Fixed: PHP 8.1 compatibility fix for null values passed to esc_* functions in WP. (@sc0ttkclark)
 * Fixed: PHP 8.1 compatibility fix for html_entity_decode. (@sc0ttkclark)
 
-= 3.2.0 - March 25th, 2024 =
+= 3.2 - March 25th, 2024 =
 
 * Feature: New support for Custom Field revisions in Pods that are Post Types that use Meta storage. You can optionally enable the feature per-pod or per-field. #7265 (@sc0ttkclark)
 * Feature: New support for WordPress `register_meta()` for all Pods fields on meta-based Pods. You can enable this feature in Pods Admin > Settings > "Register meta fields". (@sc0ttkclark)

classes/Pods.php

@@ -1174,6 +1174,9 @@ public function field( $name, $single = null, $raw = false ) {
 							$last_options        = $current_field;
 							$last_object_options = $current_field;
 
+							// Don't fetch extra unnecessary data.
+							$ids = array_unique( $ids );
+
 							// Temporary hack until there's some better handling here.
 							$last_limit *= count( $ids );
 

classes/PodsAPI.php

@@ -6552,10 +6552,10 @@ public function duplicate_pod( $params, $strict = false ) {
 
 			if ( 'post_type' === $pod['type'] ) {
 				// Max length for post types are 20 characters, so let's limit it to that minus the strlen of $try.
-				$check_name_limited = substr( $$check_name_limited, 0, 20 - strlen( (string) $try ) );
+				$check_name_limited = substr( $check_name_limited, 0, 20 - strlen( (string) $try ) );
 			} elseif ( 'taxonomy' === $pod['type'] ) {
 				// Max length for taxonomies are 32 characters, so let's limit it to that minus the strlen of $try.
-				$check_name_limited = substr( $$check_name_limited, 0, 32 - strlen( (string) $try ) );
+				$check_name_limited = substr( $check_name_limited, 0, 32 - strlen( (string) $try ) );
 			}
 
 			$check_name = $check_name_limited . $try;

classes/PodsAdmin.php

@@ -2019,9 +2019,7 @@ public function admin_access_rights_review() {
 	 */
 	public function get_callouts() {
 		// Demo mode always bypasses callouts.
-		if ( pods_is_demo() ) {
-			return [];
-		}
+		$is_demo = pods_is_demo();
 
 		$force_callouts = 1 === (int) pods_v( 'pods_force_callouts' );
 
@@ -2035,9 +2033,10 @@ public function get_callouts() {
 
 		if ( ! $callouts ) {
 			$callouts = [
-				'friends_2024_docs' => 1,
+				'friends_2024_docs' => $is_demo ? 0 : 1,
 				'access_rights'     => (
-					PodsInit::$version_last
+					! $is_demo
+					&& PodsInit::$version_last
 					&& version_compare( PodsInit::$version_last, '3.1.0-a-1', '<' )
 				) ? 1 : 0,
 			];
@@ -2046,8 +2045,8 @@ public function get_callouts() {
 		}
 
 		// Handle callouts logic.
-		$callouts['access_rights'] = ! isset( $callouts['access_rights'] ) || $callouts['access_rights'] ? 1 : 0;
-		$callouts['friends_2024_docs'] = ! isset( $callouts['friends_2024_docs'] ) || $callouts['friends_2024_docs'] || $force_callouts ? 1 : 0;
+		$callouts['access_rights'] = $callouts['access_rights'] ?? 0;
+		$callouts['friends_2024_docs'] = ( ! isset( $callouts['friends_2024_docs'] ) || $callouts['friends_2024_docs'] || $force_callouts ) ? 1 : 0;
 
 		/**
 		 * Allow hooking into whether or not the specific callouts should show.

classes/PodsForm.php

@@ -228,21 +228,6 @@ public static function field( $name, $value, $type = 'text', $options = null, $p
 		$value           = apply_filters( "pods_form_ui_field_{$type}_value", $value, $name, $options, $pod, $id );
 		$form_field_type = self::$field_type;
 
-		$helper = false;
-
-		$input_helper = pods_v( 'input_helper', $options );
-
-		/**
-		 * Input helpers are deprecated and not guaranteed to work properly.
-		 *
-		 * They will be entirely removed in Pods 3.0.
-		 *
-		 * @deprecated 2.7.0
-		 */
-		if ( is_string( $input_helper ) && 0 < strlen( $input_helper ) ) {
-			$helper = pods_api()->load_helper( array( 'name' => $input_helper ) );
-		}
-
 		if ( empty( $type ) ) {
 			return;
 		}
@@ -485,6 +470,8 @@ public static function attributes( $attributes, $name = null, $type = null, $opt
 
 		$attributes = (array) apply_filters( "pods_form_ui_field_{$type}_attributes", $attributes, $name, $options );
 
+		$final_attributes = [];
+
 		foreach ( $attributes as $attribute => $value ) {
 			if ( null === $value ) {
 				continue;
@@ -496,6 +483,16 @@ public static function attributes( $attributes, $name = null, $type = null, $opt
 				$value = pods_enforce_safe_id( $value );
 			}
 
+			$final_attributes[ (string) $attribute ] = (string) $value;
+		}
+
+		if (pods_render_is_in_block()) {
+			echo get_block_wrapper_attributes( $final_attributes );
+
+			return;
+		}
+
+		foreach ( $final_attributes as $attribute => $value ) {
 			echo ' ' . esc_attr( (string) $attribute ) . '="' . esc_attr( (string) $value ) . '"';
 		}
 	}

classes/PodsInit.php

@@ -1,8 +1,7 @@
 <?php
 
 use Pods\Config_Handler;
-use Pods\Static_Cache;
-use Pods\Whatsit\Pod;
+use Pods\Whatsit\Store;
 use Pods\Wisdom_Tracker;
 
 /**
@@ -216,7 +215,7 @@ public static function autoload_class( $class ) {
 			);
 
 			if ( ! empty( $loader['exclude_prefix'] ) ) {
-				$class = substr( $class, strlen( $loader['prefix'] ) );
+				$class = substr( $class, strlen( (string) $loader['prefix'] ) );
 			}
 
 			if ( ! empty( $loader['filter'] ) ) {
@@ -256,10 +255,6 @@ public function plugins_loaded() {
 			define( 'PODS_TABLELESS', false );
 		}
 
-		if ( ! defined( 'PODS_DISABLE_EVAL' ) ) {
-			define( 'PODS_DISABLE_EVAL', true );
-		}
-
 		if ( ! defined( 'PODS_STATS_TRACKING' ) || PODS_STATS_TRACKING ) {
 			$this->stats_tracking( PODS_FILE, 'pods' );
 		}
@@ -383,7 +378,7 @@ public function stats_tracking( $plugin_file, $plugin_slug ) {
 			];
 
 			foreach ( $tlds_to_check as $tld ) {
-				$minus_tld = strlen( $host ) - strlen( $tld );
+				$minus_tld = strlen( (string) $host ) - strlen( (string) $tld );
 
 				if ( $minus_tld === strpos( $host, $tld ) ) {
 					return true;
@@ -924,7 +919,7 @@ public function register_pods() {
 			'delete_with_user' => false,
 		);
 
-		$args = self::object_label_fix( $args, 'post_type' );
+		$args = self::object_label_fix( $args, 'post_type', '_pods_pod' );
 
 		register_post_type( '_pods_pod', apply_filters( 'pods_internal_register_post_type_pod', $args ) );
 
@@ -943,7 +938,7 @@ public function register_pods() {
 			'delete_with_user' => false,
 		);
 
-		$args = self::object_label_fix( $args, 'post_type' );
+		$args = self::object_label_fix( $args, 'post_type', '_pods_group' );
 
 		register_post_type( '_pods_group', apply_filters( 'pods_internal_register_post_type_group', $args ) );
 
@@ -962,7 +957,7 @@ public function register_pods() {
 			'delete_with_user' => false,
 		);
 
-		$args = self::object_label_fix( $args, 'post_type' );
+		$args = self::object_label_fix( $args, 'post_type', '_pods_field' );
 
 		register_post_type( '_pods_field', apply_filters( 'pods_internal_register_post_type_field', $args ) );
 
@@ -1631,7 +1626,7 @@ public function setup_content_types( $force = false ) {
 			$ct_post_types = $options['post_types'];
 			$options       = $options['options'];
 
-			$options = self::object_label_fix( $options, 'taxonomy' );
+			$options = self::object_label_fix( $options, 'taxonomy', $taxonomy );
 
 			// Max length for taxonomies are 32 characters
 			$taxonomy = substr( $taxonomy, 0, 32 );
@@ -1688,7 +1683,7 @@ public function setup_content_types( $force = false ) {
 				continue;
 			}
 
-			$options = self::object_label_fix( $options, 'post_type' );
+			$options = self::object_label_fix( $options, 'post_type', $post_type );
 
 			// Max length for post types are 20 characters
 			$post_type = substr( $post_type, 0, 20 );
@@ -1942,7 +1937,7 @@ public function setup_updated_messages( $messages ) {
 				continue;
 			}
 
-			$labels = self::object_label_fix( $pods_cpt_ct['post_types'][ $post_type['name'] ], 'post_type' );
+			$labels = self::object_label_fix( $pods_cpt_ct['post_types'][ $post_type['name'] ], 'post_type', $post_type['name'] );
 			$labels = $labels['labels'];
 
 			$revision = (int) pods_v( 'revision' );
@@ -1991,20 +1986,31 @@ public function setup_updated_messages( $messages ) {
 		return $messages;
 	}
 
-	/**
-	 * @param        $args
-	 * @param string $type
-	 *
-	 * @return array
-	 */
-	public static function object_label_fix( $args, $type = 'post_type' ) {
+	public static function object_label_fix( array $args, string $type, ?string $name = null ): array {
 
-		if ( empty( $args ) || ! is_array( $args ) ) {
-			$args = array();
+		if ( empty( $args ) ) {
+			$args = [];
 		}
 
 		if ( ! isset( $args['labels'] ) || ! is_array( $args['labels'] ) ) {
-			$args['labels'] = array();
+			$args['labels'] = [];
+		}
+
+		$is_placeholder_label = Store::PLACEHOLDER === pods_v( 'label', $args );
+		$is_placeholder_description = Store::PLACEHOLDER === pods_v( 'description', $args );
+
+		if ( $is_placeholder_label || $is_placeholder_description ) {
+			$default_object_labels = Store::get_default_object_labels();
+
+			if ( $name && isset( $default_object_labels[ $name ] ) ) {
+				if ( $is_placeholder_label ) {
+					$args['label'] = $default_object_labels[ $name ]['label'] ?? null;
+				}
+
+				if ( $is_placeholder_description ) {
+					$args['description'] = $default_object_labels[ $name ]['description'] ?? null;
+				}
+			}
 		}
 
 		$label          = pods_v( 'name', $args['labels'], pods_v( 'label', $args, __( 'Items', 'pods' ), true ), true );