Add-PnPListItem with batch and all day event yields incorrect time

[dunkabing]

Hello,

I'm using PNP.powershell and SharePointPnPPowerShell2016 to copy a SharePoint 2016 calendar to a SharePoint Online list. I'm encountering two strange issues.

The first issue is that if create a new list item using add-pnplistitem and use the source lists's $CalendarEntry.FieldValues.EventDate and $CalendarEntry.FieldValues.EndDate values, the times appear off by the UTC-5:00 offset in the destination list, but only if $CalendarEntry.FieldValues.fAllDayEvent -eq $true on the source list. If $CalendarEntry.FieldValues.fAllDayEvent -eq $false then the times come over just fine. I was able to work around this by calculating the difference between localtime and utc and using .addhours() to correct the times, but this seems like a workaround for a bug.

The second issue is that if I use New-PnPBatch, the AM and PM values become inverted on the newly created list items. This seems to affect all new list items where the source item was an all-day event, and only some other events randomly. For example, when adding a list item with EventDate = 12:00 am and EndDate = 11:59 pm, the new SharePoint list shows EventDate = 12:00 pm and EndDate = 11:59 am. Check out the examples below.

#here are the modules I'm using
Import-Module PnP.PowerShell
Import-Module SharePointPnPPowerShell2016 -Prefix Old -WarningAction SilentlyContinue #required to work with on-prem sharepoint server

$CalendarName = "testcalendar"
        
New-PnPList -Title $CalendarName -Template GenericList
Set-PnPList -Identity $CalendarName -ListExperience NewExperience
Add-PnPField -List $CalendarName -Type DateTime -InternalName "EventDate" -DisplayName "Start Date" -AddToDefaultView
Add-PnPField -List $CalendarName -Type DateTime -InternalName "EndDate" -DisplayName "End Date" -AddToDefaultView

$batch = New-PnPBatch
$Calendar = Get-OldPnPListItem -List $($_.SourceName) -PageSize 500
ForEach ($CalendarEntry in $Calendar) {
    If ($CalendarEntry.FieldValues.fAllDayEvent -eq $true){
        $eventDelta = New-TimeSpan -start $calendarEntry.FieldValues.EventDate.ToLocalTime() -end $calendarEntry.FieldValues.EventDate
        $eventDate = $CalendarEntry.FieldValues.EventDate.AddHours($eventDelta.TotalHours)
        $endDelta = New-TimeSpan -start $calendarEntry.FieldValues.EndDate.ToLocalTime() -end $calendarEntry.FieldValues.EndDate
        $endDate = $calendarEntry.FieldValues.EndDate.AddHours($endDelta.TotalHours)
        }
    Else{
        $eventDate = $CalendarEntry.FieldValues.EventDate
        $endDate = $CalendarEntry.FieldValues.EndDate
        }
        Add-PnPListItem -List $CalendarName -Values @{"Title" = $CalendarEntry.FieldValues.Title; "EventDate" = $eventDate; "EndDate" = $endDate} -Batch $batch
}
Invoke-PnPBatch -Batch $batch

Here's a screenshot of a few items on the source list

Here's the destination list when running this without batch

Here's the destination list when running this with batch

Am I doing something wrong? Did I find a bug of some sort? I'm pretty new to scripting so any help I can get would be appreciated.