Replaced error writing to new logging framework

KoenZomers · KoenZomers · commit 698576f416f7 · 2025-03-14T19:07:31.000+01:00
diff --git a/src/Commands/Admin/AddTenantTheme.cs b/src/Commands/Admin/AddTenantTheme.cs
@@ -41,7 +41,7 @@ protected override void ExecuteCmdlet()
                 }
                 else
                 {
-                    WriteError(new ErrorRecord(new Exception($"Theme exists"), "THEMEEXISTS", ErrorCategory.ResourceExists, Identity.Name));
+                    LogError("Theme exists");
                 }
             }
             else
diff --git a/src/Commands/Admin/NewSite.cs b/src/Commands/Admin/NewSite.cs
@@ -190,12 +190,12 @@ protected override void ExecuteCmdlet()
                     }
                     catch (Exception ex)
                     {
-                        WriteError(ex);
+                        LogError(ex);
                     }
                 }
                 else
                 {
-                    WriteError(new PSInvalidOperationException("Creating a new teamsite requires an underlying Microsoft 365 group. In order to create this we need to acquire an access token for the Microsoft Graph. This is not possible using ACS App Only connections."));
+                    LogError(new PSInvalidOperationException("Creating a new teamsite requires an underlying Microsoft 365 group. In order to create this we need to acquire an access token for the Microsoft Graph. This is not possible using ACS App Only connections."));
                 }
             }
             else
diff --git a/src/Commands/AzureAD/GetAzureADAppPermission.cs b/src/Commands/AzureAD/GetAzureADAppPermission.cs
@@ -23,7 +23,7 @@ protected override void ExecuteCmdlet()
                 var app = Identity.GetApp(GraphRequestHelper);
                 if (app == null)
                 {
-                    WriteError(new PSArgumentException("Azure AD App not found"));
+                    LogError(new PSArgumentException("Azure AD App not found"));
                 }
                 WriteObject(ConvertToPSObject(app));
             }
diff --git a/src/Commands/AzureAD/SetAzureADGroup.cs b/src/Commands/AzureAD/SetAzureADGroup.cs
@@ -98,12 +98,12 @@ protected override void ExecuteCmdlet()
                 catch (Exception e)
                 {
                     while (e.InnerException != null) e = e.InnerException;
-                    WriteError(new ErrorRecord(e, "GROUPUPDATEFAILED", ErrorCategory.InvalidOperation, this));
+                    LogError(e);
                 }
             }
             else
             {
-                WriteError(new ErrorRecord(new Exception("Group not found"), "GROUPNOTFOUND", ErrorCategory.ObjectNotFound, this));
+                LogError("Group not found");
             }
         }
     }
diff --git a/src/Commands/Base/BasePSCmdlet.cs b/src/Commands/Base/BasePSCmdlet.cs
@@ -130,16 +130,16 @@ public bool ParameterSpecified(string parameterName)
         /// Allows logging an error
         /// </summary>
         /// <param name="exception">The exception to log as an error</param>
-        internal void WriteError(Exception exception)
+        internal void LogError(Exception exception)
         {
-            WriteError(exception.Message);
+            LogError(exception.Message);
         }
 
         /// <summary>
         /// Allows logging an error
         /// </summary>
         /// <param name="message">The message to log</param>
-        internal void WriteError(string message)
+        internal void LogError(string message)
         {
             Utilities.Logging.LoggingUtility.Error(this, message, correlationId: CorrelationId);
         }
diff --git a/src/Commands/Base/GetAccessToken.cs b/src/Commands/Base/GetAccessToken.cs
@@ -84,7 +84,7 @@ protected override void ExecuteCmdlet()
 
             if (accessTokenValue == null)
             {
-                WriteError(new PSArgumentException("Unable to retrieve access token"));
+                LogError(new PSArgumentException("Unable to retrieve access token"));
             }
             if (ListPermissionScopes.IsPresent)
             {
diff --git a/src/Commands/Base/GetManagedAppId.cs b/src/Commands/Base/GetManagedAppId.cs
@@ -20,7 +20,7 @@ protected override void ProcessRecord()
             }
             else
             {
-                WriteError(new ErrorRecord(new Exception("AppId not found"), "APPIDNOTFOUND", ErrorCategory.AuthenticationError, this));
+                LogError("AppId not found");
             }
         }
     }
diff --git a/src/Commands/Base/GetStoredCredential.cs b/src/Commands/Base/GetStoredCredential.cs
@@ -18,7 +18,7 @@ protected override void ProcessRecord()
             }
             else
             {
-                WriteError(new ErrorRecord(new System.Exception("Credentials not found"), "CREDSNOTFOUND", ErrorCategory.AuthenticationError, this));
+                LogError(new System.Exception("Credentials not found"));
             }
         }
     }
diff --git a/src/Commands/Base/PipeBinds/ContentTypePipeBind.cs b/src/Commands/Base/PipeBinds/ContentTypePipeBind.cs
@@ -240,20 +240,20 @@ internal PnPCore.IContentType GetContentTypeOrThrow(string paramName, PnP.Core.S
             => GetContentType(context, searchInSiteHierarchy)
             ?? throw new PSArgumentException(NotFoundMessage(searchInSiteHierarchy), paramName);
 
-        internal ContentType GetContentTypeOrError(Cmdlet cmdlet, string paramName, Web web, bool searchInSiteHierarchy = true)
+        internal ContentType GetContentTypeOrError(BasePSCmdlet cmdlet, string paramName, Web web, bool searchInSiteHierarchy = true)
         {
             var ct = GetContentType(web, searchInSiteHierarchy);
             if (ct is null)
-                cmdlet.WriteError(new ErrorRecord(new PSArgumentException(NotFoundMessage(searchInSiteHierarchy), paramName), "CONTENTTYPEDOESNOTEXIST", ErrorCategory.InvalidArgument, this));
+                cmdlet.LogError(new PSArgumentException(NotFoundMessage(searchInSiteHierarchy), paramName));
             return ct;
         }
 
-        internal PnPCore.IContentType GetContentTypeOrError(Cmdlet cmdlet, string paramName, PnP.Core.Services.PnPContext context, bool searchInSiteHierarchy = true)
+        internal PnPCore.IContentType GetContentTypeOrError(BasePSCmdlet cmdlet, string paramName, PnP.Core.Services.PnPContext context, bool searchInSiteHierarchy = true)
         {
             var ct = GetContentType(context, searchInSiteHierarchy);
             if (ct is null)
             {
-                cmdlet.WriteError(new ErrorRecord(new PSArgumentException(NotFoundMessage(searchInSiteHierarchy), paramName), "CONTENTTYPEDOESNOTEXIST", ErrorCategory.InvalidArgument, this));
+                cmdlet.LogError(new PSArgumentException(NotFoundMessage(searchInSiteHierarchy), paramName));
             }
             return ct;
         }
@@ -262,19 +262,19 @@ internal ContentType GetContentTypeOrThrow(string paramName, List list)
             => GetContentType(list)
             ?? throw new PSArgumentException(NotFoundMessage(list), paramName);
 
-        internal ContentType GetContentTypeOrError(Cmdlet cmdlet, string paramName, List list)
+        internal ContentType GetContentTypeOrError(BasePSCmdlet cmdlet, string paramName, List list)
         {
             var ct = GetContentType(list);
             if (ct is null)
-                cmdlet.WriteError(new ErrorRecord(new PSArgumentException(NotFoundMessage(list), paramName), "CONTENTTYPEDOESNOTEXIST", ErrorCategory.InvalidArgument, this));
+                cmdlet.LogError(new PSArgumentException(NotFoundMessage(list), paramName));
             return ct;
         }
 
-        internal PnPCore.IContentType GetContentTypeOrError(Cmdlet cmdlet, string paramName, PnPCore.IList list)
+        internal PnPCore.IContentType GetContentTypeOrError(BasePSCmdlet cmdlet, string paramName, PnPCore.IList list)
         {
             var ct = GetContentType(list);
             if (ct is null)
-                cmdlet.WriteError(new ErrorRecord(new PSArgumentException(NotFoundMessage(list), paramName), "CONTENTTYPEDOESNOTEXIST", ErrorCategory.InvalidArgument, this));
+                cmdlet.LogError(new PSArgumentException(NotFoundMessage(list), paramName));
             return ct;
         }
 
diff --git a/src/Commands/Base/PnPConnectedCmdlet.cs b/src/Commands/Base/PnPConnectedCmdlet.cs
@@ -113,13 +113,8 @@ protected override void ProcessRecord()
                 {
                     ex.Data["CorrelationId"] = Connection.Context.TraceCorrelationId;
                     ex.Data["TimeStampUtc"] = DateTime.UtcNow;
-                    var errorDetails = new ErrorDetails(errorMessage);
 
-                    errorDetails.RecommendedAction = "Use Get-PnPException for more details.";
-                    var errorRecord = new ErrorRecord(ex, "EXCEPTION", ErrorCategory.WriteError, null);
-                    errorRecord.ErrorDetails = errorDetails;
-
-                    WriteError(errorRecord);
+                    LogError(errorMessage);
                 }
                 
             }
diff --git a/src/Commands/Base/RemoveManagedAppId.cs b/src/Commands/Base/RemoveManagedAppId.cs
@@ -23,13 +23,13 @@ protected override void ProcessRecord()
                 {
                     if (!Utilities.CredentialManager.RemoveAppid(uri.ToString()))
                     {
-                        WriteError(new ErrorRecord(new Exception($"AppId for {Url} not removed"), "APPIDNOTREMOVED", ErrorCategory.WriteError, Url));
+                        LogError($"AppId for {Url} not removed");
                     }
                 }
             }
             else
             {
-                WriteError(new ErrorRecord(new Exception($"AppId not found for {Url}"), "APPIDNOTFOUND", ErrorCategory.ObjectNotFound, Url));
+                LogError($"AppId not found for {Url}");
             }
         }
     }
diff --git a/src/Commands/Base/RemoveStoredCredential.cs b/src/Commands/Base/RemoveStoredCredential.cs
@@ -21,13 +21,13 @@ protected override void ProcessRecord()
                 {
                     if (!Utilities.CredentialManager.RemoveCredential(Name))
                     {
-                        WriteError(new ErrorRecord(new System.Exception($"Credential {Name} not removed"), "CREDENTIALNOTREMOVED", ErrorCategory.WriteError, Name));
+                        LogError($"Credential {Name} not removed");
                     }
                 }
             }
             else
             {
-                WriteError(new ErrorRecord(new System.Exception($"Credential {Name} not found"), "CREDENTIALNOTFOUND", ErrorCategory.ObjectNotFound, Name));
+                LogError($"Credential {Name} not found");
             }
         }
     }
diff --git a/src/Commands/ContentTypes/GetContentTypePublishingStatus.cs b/src/Commands/ContentTypes/GetContentTypePublishingStatus.cs
@@ -24,7 +24,7 @@ protected override void ExecuteCmdlet()
 
             if (ct == null)
             {
-                WriteError(new ErrorRecord(new Exception($"Invalid content type id."), "INVALIDCTID", ErrorCategory.InvalidArgument, ContentType));
+                LogError("Invalid content type id.");
                 return;
             }
 
diff --git a/src/Commands/ContentTypes/PublishContentType.cs b/src/Commands/ContentTypes/PublishContentType.cs
@@ -24,7 +24,7 @@ protected override void ExecuteCmdlet()
 
             if (ct == null)
             {
-                WriteError(new ErrorRecord(new Exception($"Invalid content type id."), "INVALIDCTID", ErrorCategory.InvalidArgument, ContentType));
+                LogError("Invalid content type id.");
                 return;
             }
 
diff --git a/src/Commands/ContentTypes/UnpublishContentType.cs b/src/Commands/ContentTypes/UnpublishContentType.cs
@@ -23,7 +23,7 @@ protected override void ExecuteCmdlet()
 
             if (ct == null)
             {
-                WriteError(new ErrorRecord(new Exception($"Invalid content type id."), "INVALIDCTID", ErrorCategory.InvalidArgument, ContentType));
+                LogError("Invalid content type id.");
                 return;
             }
 
diff --git a/src/Commands/Files/SetFolderPermission.cs b/src/Commands/Files/SetFolderPermission.cs
@@ -56,7 +56,7 @@ protected override void ExecuteCmdlet()
                 // Ensure the folder has been found
                 if (folder == null)
                 {
-                    WriteError(new ErrorRecord(new Exception("Folder not found"), "1", ErrorCategory.ObjectNotFound, null));
+                    LogError("Folder not found");
                     return;
                 }
 
@@ -66,7 +66,7 @@ protected override void ExecuteCmdlet()
                 // Validate that the ListItemAllFields contains the Id which represents the ListItem ID equivallent for this folder
                 if (folder.ListItemAllFields.ServerObjectIsNull.GetValueOrDefault(true) || folder.ListItemAllFields.Id <= 0)
                 {
-                    WriteError(new ErrorRecord(new Exception("ListItemId on folder not found"), "1", ErrorCategory.InvalidData, null));
+                    LogError("ListItemId on folder not found");
                     return;
                 }
 
@@ -156,7 +156,7 @@ protected override void ExecuteCmdlet()
                 }
                 else
                 {
-                    WriteError(new ErrorRecord(new Exception("Principal not found"), "1", ErrorCategory.ObjectNotFound, null));
+                    LogError("Principal not found");
                 }
             }
         }
diff --git a/src/Commands/Graph/InvokeGraphMethod.cs b/src/Commands/Graph/InvokeGraphMethod.cs
@@ -109,7 +109,7 @@ protected override void ExecuteCmdlet()
             }
             catch (Exception ex)
             {
-                WriteError(ex);
+                LogError(ex);
             }
         }
 
diff --git a/src/Commands/Graph/RemoveAvailableSiteClassification.cs b/src/Commands/Graph/RemoveAvailableSiteClassification.cs
@@ -48,14 +48,14 @@ protected override void ExecuteCmdlet()
                 }
                 else
                 {
-                    WriteError(new ErrorRecord(new InvalidOperationException("At least one classification is required. If you want to disable classifications, use Disable-PnPSiteClassification."), "SITECLASSIFICATIONS_ARE_REQUIRED", ErrorCategory.InvalidOperation, null));
+                    LogError("At least one classification is required. If you want to disable classifications, use Disable-PnPSiteClassification.");
                 }
             }
             catch (ApplicationException ex)
             {
                 if (ex.Message == @"Missing DirectorySettingTemplate for ""Group.Unified""")
                 {
-                    WriteError(new ErrorRecord(new InvalidOperationException("Site Classification is not enabled for this tenant"), "SITECLASSIFICATION_NOT_ENABLED", ErrorCategory.ResourceUnavailable, null));
+                    LogError("Site Classification is not enabled for this tenant");
                 }
             }
         }
diff --git a/src/Commands/Lists/SetListPermission.cs b/src/Commands/Lists/SetListPermission.cs
@@ -87,7 +87,7 @@ protected override void ExecuteCmdlet()
             }
             else
             {
-                WriteError(new ErrorRecord(new Exception("Principal not found"), "1", ErrorCategory.ObjectNotFound, null));
+                LogError(new Exception("Principal not found"));
             }
         }
     }
diff --git a/src/Commands/PowerPlatform/PowerAutomate/GetFlow.cs b/src/Commands/PowerPlatform/PowerAutomate/GetFlow.cs
@@ -76,7 +76,7 @@ protected override void ExecuteCmdlet()
             }
             catch (Exception e)
             {
-                WriteError(new ErrorRecord(new Exception("Make sure you have granted access to Azure AD App to Interact with Power Platform, To help understand the required permissions visit https://pnp.github.io/powershell/articles/determinepermissions.html#help-i-cant-figure-out-which-permissions-i-need"), e.Message, ErrorCategory.AuthenticationError, null));
+                LogError($"Error: {e.Message}. Make sure you have granted access to your Entra AD App to Interact with Power Platform, To help understand the required permissions visit https://pnp.github.io/powershell/articles/determinepermissions.html#help-i-cant-figure-out-which-permissions-i-need");
             }
         }
     }
diff --git a/src/Commands/Provisioning/Site/AddDataRowsToSiteTemplate.cs b/src/Commands/Provisioning/Site/AddDataRowsToSiteTemplate.cs
@@ -64,7 +64,7 @@ protected override void ExecuteCmdlet()
 
             var template = ProvisioningHelper.LoadSiteTemplateFromFile(Path, TemplateProviderExtensions, (e) =>
                     {
-                        WriteError(new ErrorRecord(e, "TEMPLATENOTVALID", ErrorCategory.SyntaxError, null));
+                        LogError(e);
                     });
 
             if (template == null)
diff --git a/src/Commands/Provisioning/Site/AddFileToSiteTemplate.cs b/src/Commands/Provisioning/Site/AddFileToSiteTemplate.cs
@@ -52,7 +52,7 @@ protected override void ProcessRecord()
             // Load the template
             var template = ProvisioningHelper.LoadSiteTemplateFromFile(Path, TemplateProviderExtensions, (e) =>
                 {
-                    WriteError(new ErrorRecord(e, "TEMPLATENOTVALID", ErrorCategory.SyntaxError, null));
+                    LogError(e);
                 });
 
             if (template == null)
diff --git a/src/Commands/Provisioning/Site/AddListFoldersToSiteTemplate.cs b/src/Commands/Provisioning/Site/AddListFoldersToSiteTemplate.cs
@@ -42,7 +42,7 @@ protected override void ExecuteCmdlet()
             // Load the template
             var template = ProvisioningHelper.LoadSiteTemplateFromFile(Path, TemplateProviderExtensions, (e) =>
                 {
-                    WriteError(new ErrorRecord(e, "TEMPLATENOTVALID", ErrorCategory.SyntaxError, null));
+                    LogError(e);
                 });
 
             if (template == null)
diff --git a/src/Commands/Provisioning/Site/InvokeSiteTemplate.cs b/src/Commands/Provisioning/Site/InvokeSiteTemplate.cs
@@ -150,7 +150,7 @@ protected override void ExecuteCmdlet()
                 if (provisioningTemplate == null)
                 {
                     // If we don't have the template, raise an error and exit
-                    WriteError(new ErrorRecord(new Exception("The -Path parameter targets an invalid repository or template object."), "WRONG_PATH", ErrorCategory.SyntaxError, null));
+                    LogError("The -Path parameter targets an invalid repository or template object.");
                     return;
                 }
 
diff --git a/src/Commands/Provisioning/Site/ReadSiteTemplate.cs b/src/Commands/Provisioning/Site/ReadSiteTemplate.cs
@@ -38,23 +38,23 @@ protected override void ProcessRecord()
                         }
                         WriteObject(ProvisioningHelper.LoadSiteTemplateFromFile(Path, TemplateProviderExtensions, (e) =>
                         {
-                            WriteError(new ErrorRecord(e, "TEMPLATENOTVALID", ErrorCategory.SyntaxError, null));
+                            LogError(e);
                         }));
                         break;
                     }
                 case ParameterSet_XML:
                     {
                         WriteObject(ProvisioningHelper.LoadSiteTemplateFromString(Xml, TemplateProviderExtensions, (e) =>
                         {
-                            WriteError(new ErrorRecord(e, "TEMPLATENOTVALID", ErrorCategory.SyntaxError, null));
+                            LogError(e);
                         }));
                         break;
                     }
                 case ParameterSet_STREAM:
                     {
                         WriteObject(ProvisioningHelper.LoadSiteTemplatesFromStream(Stream, TemplateProviderExtensions, (e) =>
                         {
-                            WriteError(new ErrorRecord(e, "TEMPLATENOTVALID", ErrorCategory.SyntaxError, null));
+                            LogError(e);
                         }), true);
                         break;
                     }                    
diff --git a/src/Commands/Provisioning/Site/RemoveFileFromSiteTemplate.cs b/src/Commands/Provisioning/Site/RemoveFileFromSiteTemplate.cs
@@ -32,7 +32,7 @@ protected override void ProcessRecord()
             // Load the template
             ProvisioningTemplate template = ProvisioningHelper.LoadSiteTemplateFromFile(Path, TemplateProviderExtensions, (e) =>
                 {
-                    WriteError(new ErrorRecord(e, "TEMPLATENOTVALID", ErrorCategory.SyntaxError, null));
+                    LogError(e);
                 });
 
             if (template == null)
diff --git a/src/Commands/Provisioning/Site/SaveSiteTemplate.cs b/src/Commands/Provisioning/Site/SaveSiteTemplate.cs
@@ -35,7 +35,7 @@ protected override void ProcessRecord()
         {
             var templateObject = Template.GetTemplate(SessionState.Path.CurrentFileSystemLocation.Path, (e) =>
             {
-                WriteError(new ErrorRecord(e, "TEMPLATENOTVALID", ErrorCategory.SyntaxError, null));
+                LogError(e);
             });
 
             // Determine the output file name and path
@@ -101,7 +101,7 @@ private void ProcessFiles(ProvisioningTemplate template, string templateFileName
         {
             var templateFile = ProvisioningHelper.LoadSiteTemplateFromFile(templateFileName, null, (e) =>
             {
-                WriteError(new ErrorRecord(e, "TEMPLATENOTVALID", ErrorCategory.SyntaxError, null));
+                LogError(e);
             });
             if (template.Tenant?.AppCatalog != null)
             {
diff --git a/src/Commands/Provisioning/Tenant/AddSiteTemplate.cs b/src/Commands/Provisioning/Tenant/AddSiteTemplate.cs
@@ -21,7 +21,7 @@ protected override void ProcessRecord()
             {
                 TenantTemplate.Templates.Add(SiteTemplate);
             } else { 
-                WriteError(new ErrorRecord(new Exception($"Template with ID {SiteTemplate.Id} already exists in template"), "DUPLICATETEMPLATE", ErrorCategory.InvalidData, SiteTemplate));
+                LogError($"Template with ID {SiteTemplate.Id} already exists in template");
             }
         }
     }
diff --git a/src/Commands/Provisioning/Tenant/AddTenantSequence.cs b/src/Commands/Provisioning/Tenant/AddTenantSequence.cs
@@ -24,7 +24,7 @@ protected override void ProcessRecord()
             }
             else
             {
-                WriteError(new ErrorRecord(new Exception($"Sequence with ID {Sequence.ID} already exists in template"), "DUPLICATESEQUENCEID", ErrorCategory.InvalidData, Sequence));
+                LogError($"Sequence with ID {Sequence.ID} already exists in template");
             }
         }
     }
diff --git a/src/Commands/Provisioning/Tenant/AddTenantSequenceSubSite.cs b/src/Commands/Provisioning/Tenant/AddTenantSequenceSubSite.cs
diff --git a/src/Commands/Provisioning/Tenant/InvokeTenantTemplate.cs b/src/Commands/Provisioning/Tenant/InvokeTenantTemplate.cs
diff --git a/src/Commands/Provisioning/Tenant/ReadTenantTemplate.cs b/src/Commands/Provisioning/Tenant/ReadTenantTemplate.cs
diff --git a/src/Commands/Provisioning/Tenant/SaveTenantTemplate.cs b/src/Commands/Provisioning/Tenant/SaveTenantTemplate.cs
diff --git a/src/Commands/Search/GetSearchCrawlLog.cs b/src/Commands/Search/GetSearchCrawlLog.cs
diff --git a/src/Commands/Site/AddAvailableSiteClassification.cs b/src/Commands/Site/AddAvailableSiteClassification.cs
diff --git a/src/Commands/Site/GetAvailableSiteClassification.cs b/src/Commands/Site/GetAvailableSiteClassification.cs
diff --git a/src/Commands/Site/UpdateAvailableSiteClassification.cs b/src/Commands/Site/UpdateAvailableSiteClassification.cs
diff --git a/src/Commands/SiteDesigns/SetSiteDesign.cs b/src/Commands/SiteDesigns/SetSiteDesign.cs
diff --git a/src/Commands/Teams/GetTeamsTab.cs b/src/Commands/Teams/GetTeamsTab.cs
diff --git a/src/Commands/Teams/RemoveTeamsChannel.cs b/src/Commands/Teams/RemoveTeamsChannel.cs
diff --git a/src/Commands/Teams/RemoveTeamsTeam.cs b/src/Commands/Teams/RemoveTeamsTeam.cs
diff --git a/src/Commands/Web/SetWebPermission.cs b/src/Commands/Web/SetWebPermission.cs

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ protected override void ExecuteCmdlet()`
`41`	`41`	`}`
`42`	`42`	`else`
`43`	`43`	`{`
`44`		`- WriteError(new ErrorRecord(new Exception($"Theme exists"), "THEMEEXISTS", ErrorCategory.ResourceExists, Identity.Name));`
	`44`	`+ LogError("Theme exists");`
`45`	`45`	`}`
`46`	`46`	`}`
`47`	`47`	`else`
Original file line number	Diff line number	Diff line change
`@@ -190,12 +190,12 @@ protected override void ExecuteCmdlet()`
`190`	`190`	`}`
`191`	`191`	`catch (Exception ex)`
`192`	`192`	`{`
`193`		`- WriteError(ex);`
	`193`	`+ LogError(ex);`
`194`	`194`	`}`
`195`	`195`	`}`
`196`	`196`	`else`
`197`	`197`	`{`
`198`		`- WriteError(new PSInvalidOperationException("Creating a new teamsite requires an underlying Microsoft 365 group. In order to create this we need to acquire an access token for the Microsoft Graph. This is not possible using ACS App Only connections."));`
	`198`	`+ LogError(new PSInvalidOperationException("Creating a new teamsite requires an underlying Microsoft 365 group. In order to create this we need to acquire an access token for the Microsoft Graph. This is not possible using ACS App Only connections."));`
`199`	`199`	`}`
`200`	`200`	`}`
`201`	`201`	`else`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ protected override void ExecuteCmdlet()`
`23`	`23`	`var app = Identity.GetApp(GraphRequestHelper);`
`24`	`24`	`if (app == null)`
`25`	`25`	`{`
`26`		`- WriteError(new PSArgumentException("Azure AD App not found"));`
	`26`	`+ LogError(new PSArgumentException("Azure AD App not found"));`
`27`	`27`	`}`
`28`	`28`	`WriteObject(ConvertToPSObject(app));`
`29`	`29`	`}`
Original file line number	Diff line number	Diff line change
`@@ -98,12 +98,12 @@ protected override void ExecuteCmdlet()`
`98`	`98`	`catch (Exception e)`
`99`	`99`	`{`
`100`	`100`	`while (e.InnerException != null) e = e.InnerException;`
`101`		`- WriteError(new ErrorRecord(e, "GROUPUPDATEFAILED", ErrorCategory.InvalidOperation, this));`
	`101`	`+ LogError(e);`
`102`	`102`	`}`
`103`	`103`	`}`
`104`	`104`	`else`
`105`	`105`	`{`
`106`		`- WriteError(new ErrorRecord(new Exception("Group not found"), "GROUPNOTFOUND", ErrorCategory.ObjectNotFound, this));`
	`106`	`+ LogError("Group not found");`
`107`	`107`	`}`
`108`	`108`	`}`
`109`	`109`	`}`
Original file line number	Diff line number	Diff line change
`@@ -130,16 +130,16 @@ public bool ParameterSpecified(string parameterName)`
`130`	`130`	`/// Allows logging an error`
`131`	`131`	`/// </summary>`
`132`	`132`	`/// <param name="exception">The exception to log as an error</param>`
`133`		`- internal void WriteError(Exception exception)`
	`133`	`+ internal void LogError(Exception exception)`
`134`	`134`	`{`
`135`		`- WriteError(exception.Message);`
	`135`	`+ LogError(exception.Message);`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`/// <summary>`
`139`	`139`	`/// Allows logging an error`
`140`	`140`	`/// </summary>`
`141`	`141`	`/// <param name="message">The message to log</param>`
`142`		`- internal void WriteError(string message)`
	`142`	`+ internal void LogError(string message)`
`143`	`143`	`{`
`144`	`144`	`Utilities.Logging.LoggingUtility.Error(this, message, correlationId: CorrelationId);`
`145`	`145`	`}`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ protected override void ExecuteCmdlet()`
`84`	`84`
`85`	`85`	`if (accessTokenValue == null)`
`86`	`86`	`{`
`87`		`- WriteError(new PSArgumentException("Unable to retrieve access token"));`
	`87`	`+ LogError(new PSArgumentException("Unable to retrieve access token"));`
`88`	`88`	`}`
`89`	`89`	`if (ListPermissionScopes.IsPresent)`
`90`	`90`	`{`
Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ protected override void ProcessRecord()`
`20`	`20`	`}`
`21`	`21`	`else`
`22`	`22`	`{`
`23`		`- WriteError(new ErrorRecord(new Exception("AppId not found"), "APPIDNOTFOUND", ErrorCategory.AuthenticationError, this));`
	`23`	`+ LogError("AppId not found");`
`24`	`24`	`}`
`25`	`25`	`}`
`26`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ protected override void ProcessRecord()`
`18`	`18`	`}`
`19`	`19`	`else`
`20`	`20`	`{`
`21`		`- WriteError(new ErrorRecord(new System.Exception("Credentials not found"), "CREDSNOTFOUND", ErrorCategory.AuthenticationError, this));`
	`21`	`+ LogError(new System.Exception("Credentials not found"));`
`22`	`22`	`}`
`23`	`23`	`}`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -240,20 +240,20 @@ internal PnPCore.IContentType GetContentTypeOrThrow(string paramName, PnP.Core.S`
`240`	`240`	`=> GetContentType(context, searchInSiteHierarchy)`
`241`	`241`	`?? throw new PSArgumentException(NotFoundMessage(searchInSiteHierarchy), paramName);`
`242`	`242`
`243`		`- internal ContentType GetContentTypeOrError(Cmdlet cmdlet, string paramName, Web web, bool searchInSiteHierarchy = true)`
	`243`	`+ internal ContentType GetContentTypeOrError(BasePSCmdlet cmdlet, string paramName, Web web, bool searchInSiteHierarchy = true)`
`244`	`244`	`{`
`245`	`245`	`var ct = GetContentType(web, searchInSiteHierarchy);`
`246`	`246`	`if (ct is null)`
`247`		`- cmdlet.WriteError(new ErrorRecord(new PSArgumentException(NotFoundMessage(searchInSiteHierarchy), paramName), "CONTENTTYPEDOESNOTEXIST", ErrorCategory.InvalidArgument, this));`
	`247`	`+ cmdlet.LogError(new PSArgumentException(NotFoundMessage(searchInSiteHierarchy), paramName));`
`248`	`248`	`return ct;`
`249`	`249`	`}`
`250`	`250`
`251`		`- internal PnPCore.IContentType GetContentTypeOrError(Cmdlet cmdlet, string paramName, PnP.Core.Services.PnPContext context, bool searchInSiteHierarchy = true)`
	`251`	`+ internal PnPCore.IContentType GetContentTypeOrError(BasePSCmdlet cmdlet, string paramName, PnP.Core.Services.PnPContext context, bool searchInSiteHierarchy = true)`
`252`	`252`	`{`
`253`	`253`	`var ct = GetContentType(context, searchInSiteHierarchy);`
`254`	`254`	`if (ct is null)`
`255`	`255`	`{`
`256`		`- cmdlet.WriteError(new ErrorRecord(new PSArgumentException(NotFoundMessage(searchInSiteHierarchy), paramName), "CONTENTTYPEDOESNOTEXIST", ErrorCategory.InvalidArgument, this));`
	`256`	`+ cmdlet.LogError(new PSArgumentException(NotFoundMessage(searchInSiteHierarchy), paramName));`
`257`	`257`	`}`
`258`	`258`	`return ct;`
`259`	`259`	`}`
`@@ -262,19 +262,19 @@ internal ContentType GetContentTypeOrThrow(string paramName, List list)`
`262`	`262`	`=> GetContentType(list)`
`263`	`263`	`?? throw new PSArgumentException(NotFoundMessage(list), paramName);`
`264`	`264`
`265`		`- internal ContentType GetContentTypeOrError(Cmdlet cmdlet, string paramName, List list)`
	`265`	`+ internal ContentType GetContentTypeOrError(BasePSCmdlet cmdlet, string paramName, List list)`
`266`	`266`	`{`
`267`	`267`	`var ct = GetContentType(list);`
`268`	`268`	`if (ct is null)`
`269`		`- cmdlet.WriteError(new ErrorRecord(new PSArgumentException(NotFoundMessage(list), paramName), "CONTENTTYPEDOESNOTEXIST", ErrorCategory.InvalidArgument, this));`
	`269`	`+ cmdlet.LogError(new PSArgumentException(NotFoundMessage(list), paramName));`
`270`	`270`	`return ct;`
`271`	`271`	`}`
`272`	`272`
`273`		`- internal PnPCore.IContentType GetContentTypeOrError(Cmdlet cmdlet, string paramName, PnPCore.IList list)`
	`273`	`+ internal PnPCore.IContentType GetContentTypeOrError(BasePSCmdlet cmdlet, string paramName, PnPCore.IList list)`
`274`	`274`	`{`
`275`	`275`	`var ct = GetContentType(list);`
`276`	`276`	`if (ct is null)`
`277`		`- cmdlet.WriteError(new ErrorRecord(new PSArgumentException(NotFoundMessage(list), paramName), "CONTENTTYPEDOESNOTEXIST", ErrorCategory.InvalidArgument, this));`
	`277`	`+ cmdlet.LogError(new PSArgumentException(NotFoundMessage(list), paramName));`
`278`	`278`	`return ct;`
`279`	`279`	`}`
`280`	`280`
Original file line number	Diff line number	Diff line change
`@@ -113,13 +113,8 @@ protected override void ProcessRecord()`
`113`	`113`	`{`
`114`	`114`	`ex.Data["CorrelationId"] = Connection.Context.TraceCorrelationId;`
`115`	`115`	`ex.Data["TimeStampUtc"] = DateTime.UtcNow;`
`116`		`- var errorDetails = new ErrorDetails(errorMessage);`
`117`	`116`
`118`		`- errorDetails.RecommendedAction = "Use Get-PnPException for more details.";`
`119`		`- var errorRecord = new ErrorRecord(ex, "EXCEPTION", ErrorCategory.WriteError, null);`
`120`		`- errorRecord.ErrorDetails = errorDetails;`
`121`		`-`
`122`		`- WriteError(errorRecord);`
	`117`	`+ LogError(errorMessage);`
`123`	`118`	`}`
`124`	`119`
`125`	`120`	`}`