Thoughts @pnp/cli-for-microsoft-365-maintainers?

Good call 👍

Always up to improve consistency 👍

yep. Let's keep it consistent!
Should we open it up? @waldekmastykarz maybe we could do a bit of research and point out all places/commands that should be updated

Agreed @Adam-it!

Since this is a breaking change, we can go about it in two ways:

1. We wait until we're closer to v11 and start working on it then.
2. We introduce the new options besides the existing ones and make the old ones (--include...) deprecated. We remove them as we start working on v11.

Thoughts @pnp/cli-for-microsoft-365-maintainers?

I think option 2 will be the most user-friendly one. That way people get notified way ahead about the coming change.

I think option 2 will be the most user-friendly one. That way people get notified way ahead about the coming change.

+1 to that opinion as well

Can I work on it?

Thank you @nanddeepn!

@waldekmastykarz,
When doing review I noticed that IncludedInMyFilesScope in spo list add/set command and includeResourceData in graph subscription add command were named like this because they align 1:1 with the corresponding option in the API request. I wonder that if we now rename those to withInMyFilesScope and withResourceData we wont create more confusion🤔
any feed on that @pnp/cli-for-microsoft-365-maintainers?

We don't necessarily have to align with the api interface I think.

That being said, I think includedInMyFilesScope does a different thing, you can see it from the spelling (included vs include) and from the description (which is difficult to read by the way). We should NOT update this one to with. @nanddeepn. That goes for listitem add and listitem set

--includedInMyFilesScope [includedInMyFilesScope]
Specifies whether this list is accessible to an app principal that has been granted an OAuth scope that contains the string “myfiles” by a case-insensitive comparison when the current user is a site collection administrator of the personal site that contains the list.

The other options are used to include extra data on the response, while this one sets a setting on the entity instead.