Refactors 'pp solution remove' to use util. Closes #5252

Author: nicodecleyre

src/m365/pp/commands/solution/solution-remove.spec.ts

@@ -1,18 +1,17 @@
 import assert from 'assert';
 import sinon from 'sinon';
+import { telemetry } from '../../../../telemetry.js';
 import auth from '../../../../Auth.js';
 import { cli } from '../../../../cli/cli.js';
 import { CommandInfo } from '../../../../cli/CommandInfo.js';
 import { Logger } from '../../../../cli/Logger.js';
 import { CommandError } from '../../../../Command.js';
 import request from '../../../../request.js';
-import { telemetry } from '../../../../telemetry.js';
 import { pid } from '../../../../utils/pid.js';
-import { powerPlatform } from '../../../../utils/powerPlatform.js';
 import { session } from '../../../../utils/session.js';
+import { powerPlatform } from '../../../../utils/powerPlatform.js';
 import { sinonUtil } from '../../../../utils/sinonUtil.js';
 import commands from '../../commands.js';
-import ppSolutionGetCommand from './solution-get.js';
 import command from './solution-remove.js';
 import { accessToken } from '../../../../utils/accessToken.js';
 
@@ -23,6 +22,19 @@ describe(commands.SOLUTION_REMOVE, () => {
   const validId = '00000001-0000-0000-0001-00000000009b';
   const validName = 'Solution name';
   const envUrl = "https://contoso-dev.api.crm4.dynamics.com";
+  const solutionResponse = {
+    solutionid: validId,
+    uniquename: validName,
+    version: '1.0.0.0',
+    installedon: '2021-10-01T21:54:14Z',
+    solutionpackageversion: null,
+    friendlyname: validName,
+    versionnumber: 860052,
+    publisherid: {
+      friendlyname: 'CDS Default Publisher',
+      publisherid: '00000001-0000-0000-0000-00000000005a'
+    }
+  };
   //#endregion
 
   let log: string[];
@@ -66,6 +78,7 @@ describe(commands.SOLUTION_REMOVE, () => {
     sinonUtil.restore([
       request.delete,
       powerPlatform.getDynamicsInstanceApiUrl,
+      powerPlatform.getSolutionByName,
       cli.promptForConfirmation,
       cli.executeCommandWithOutput
     ]);
@@ -129,28 +142,7 @@ describe(commands.SOLUTION_REMOVE, () => {
 
   it('removes the specified solution owned by the currently signed-in user when prompt confirmed', async () => {
     sinon.stub(powerPlatform, 'getDynamicsInstanceApiUrl').callsFake(async () => envUrl);
-
-    sinon.stub(cli, 'executeCommandWithOutput').callsFake(async (command): Promise<any> => {
-      if (command === ppSolutionGetCommand) {
-        return ({
-          stdout: `{
-            "solutionid": "${validId}",
-            "uniquename": "${validName}",
-            "version": "1.0.0.0",
-            "installedon": "2022-10-30T13:59:26Z",
-            "solutionpackageversion": null,
-            "friendlyname": "${validName}",
-            "versionnumber": 1209676,
-            "publisherid": {
-              "friendlyname": "Default Publisher for org1547b730",
-              "publisherid": "d21aab71-79e7-11dd-8874-00188b01e34f"
-            }
-          }`
-        });
-      }
-
-      throw new CommandError('Unknown case');
-    });
+    sinon.stub(powerPlatform, 'getSolutionByName').resolves(solutionResponse);
 
     sinon.stub(request, 'delete').callsFake(async (opts) => {
       if (opts.url === `https://contoso-dev.api.crm4.dynamics.com/api/data/v9.1/solutions(${validId})`) {

src/m365/pp/commands/solution/solution-remove.ts

@@ -1,13 +1,11 @@
 import { cli } from '../../../../cli/cli.js';
 import { Logger } from '../../../../cli/Logger.js';
-import Command from '../../../../Command.js';
 import GlobalOptions from '../../../../GlobalOptions.js';
 import request, { CliRequestOptions } from '../../../../request.js';
 import { powerPlatform } from '../../../../utils/powerPlatform.js';
 import { validation } from '../../../../utils/validation.js';
 import PowerPlatformCommand from '../../../base/PowerPlatformCommand.js';
 import commands from '../../commands.js';
-import ppSolutionGetCommand, { Options as PpSolutionGetCommandOptions } from './solution-get.js';
 
 interface CommandArgs {
   options: Options;
@@ -106,29 +104,20 @@ class PpSolutionRemoveCommand extends PowerPlatformCommand {
     }
   }
 
-  private async getSolutionId(args: CommandArgs): Promise<string> {
+  private async getSolutionId(args: CommandArgs, dynamicsApiUrl: string): Promise<string> {
     if (args.options.id) {
       return args.options.id;
     }
 
-    const options: PpSolutionGetCommandOptions = {
-      environmentName: args.options.environmentName,
-      name: args.options.name,
-      output: 'json',
-      debug: this.debug,
-      verbose: this.verbose
-    };
-
-    const output = await cli.executeCommandWithOutput(ppSolutionGetCommand as Command, { options: { ...options, _: [] } });
-    const getSolutionOutput = JSON.parse(output.stdout);
-    return getSolutionOutput.solutionid;
+    const solution = await powerPlatform.getSolutionByName(dynamicsApiUrl, args.options.name!);
+    return solution.solutionid;
   }
 
   private async deleteSolution(args: CommandArgs): Promise<void> {
     try {
       const dynamicsApiUrl = await powerPlatform.getDynamicsInstanceApiUrl(args.options.environmentName, args.options.asAdmin);
 
-      const solutionId = await this.getSolutionId(args);
+      const solutionId = await this.getSolutionId(args, dynamicsApiUrl);
       const requestOptions: CliRequestOptions = {
         url: `${dynamicsApiUrl}/api/data/v9.1/solutions(${solutionId})`,
         headers: {