You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have a few handlers defined for the component. After I have upgraded react-three-fiber from 5.2.1 to 5.3.0, all these handlers will not work after this component reloaded.
// It should NOT call onUpdate on object instanciation, because it hasn't been added to the
// view yet. If the callback relies on references for instance, they won't be ready yet, this is
// why it passes "true" here
applyProps(instance, props, {});
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
I have a few handlers defined for the component. After I have upgraded react-three-fiber from 5.2.1 to 5.3.0, all these handlers will not work after this component reloaded.
I compared the changes and found it most likely caused by the newly introduced
accumulative
in the applyProps method. It will no cache the planeHelper for interaction filter late.https://github.com/pmndrs/react-three-fiber/blob/master/packages/fiber/src/core/renderer.ts#L264
I found the comment in createInstance method saying to set
accumulative
to true, but it is false as the default value is false.https://github.com/pmndrs/react-three-fiber/blob/master/packages/fiber/src/core/renderer.ts#L336
Beta Was this translation helpful? Give feedback.
All reactions