Animation smoothness with frameloop="demand"

[maxibenner]

I just started using v6. Is it normal that a react-spring animation runs less smooth with frameloop="demand" then it does in game loop? Might make perfect sense, I'm just curious about the technical explanation.

[maxibenner]

Just pushing to make sure everyone who might have an answer saw this.

[drcmda]

it shouldn't be the case. @joshuaellis @dbismut did you see anything?

[dmaslan]

I'm having the same issue and just wanted to follow up. The docs say that react spring animations will automatically invalidate and trigger a render but, for instance, if you take this example and change it to frameloop="demand" (see forked sandbox) it either doesn't work or produces a super choppy animation when clicked. Any ideas? Or am I missing something? How would one go about manually triggering a render with a react spring animation?

[drcmda]

then something in react-spring must have changed, it sounds like a RS bug. it has to invalidate on every frame it causes. if it misses that it won't be an animation. i think this should continue as a bug ticket on RS GH

[dmaslan]

Submitted a ticket. It seems to be an issue that started with react-spring v9.2.2, as going back to v9.2.1 fixes the issue.

[joshuaellis]

It's a complicated issue, rs under VR needs to be ran by r3f, so when you set the frameLoop to demand, and you're not calling that invalidate function then it won't run either.

We do this because of this pmndrs/react-spring#1518

Where r3f can run in non-brower ENVs. There's probably a solution to this that would resolve the issue, but i'd argue the docs are a little inaccurate.

I've also posted this in the comment of the issue, where we should continue the conversation since this is a discussion in r3f.