Skip to content

PalettedBlockArray::fromData() does not require any user input about bits-per-block #29

@dktapps

Description

@dktapps

Bits-per-block can be inferred from the size of the offset table (or $words), meaning that having this parameter at all is completely redundant.

The only thing bpb is required for is to know how many bytes to read when decoding palettes from disk, which is not something fromData has to care about. It only needs to care that the provided data is valid. This useless parameter is just providing an extra avenue for potential bugs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    BC breakBreaks API backwards compatibilityenhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions