Check tests with phpstan

Author: dktapps

composer.json

@@ -11,7 +11,8 @@
         "phpstan/phpstan": "2.1.0",
         "phpunit/phpunit": "^9.5",
         "phpstan/extension-installer": "^1.0",
-        "phpstan/phpstan-strict-rules": "^2.0"
+        "phpstan/phpstan-strict-rules": "^2.0",
+        "phpstan/phpstan-phpunit": "^2.0"
     },
     "license": "LGPL-3.0",
     "autoload": {

phpstan.neon.dist

@@ -1,4 +1,5 @@
 includes:
+	- tests/phpstan/configs/expected-test-errors.neon
 	- tests/phpstan/configs/impossible-mixed.neon
 	- tests/phpstan/configs/phpstan-bugs.neon
 
@@ -7,3 +8,4 @@ parameters:
 	treatPhpDocTypesAsCertain: false
 	paths:
 		- src
+		- tests

tests/phpstan/configs/expected-test-errors.neon

@@ -0,0 +1,13 @@
+parameters:
+	ignoreErrors:
+		-
+			message: '#^Expression "clone \$tag" on a separate line does not do anything\.$#'
+			identifier: expr.resultUnused
+			count: 1
+			path: ../../phpunit/tag/CompoundTagTest.php
+
+		-
+			message: '#^Expression "clone \$tag" on a separate line does not do anything\.$#'
+			identifier: expr.resultUnused
+			count: 1
+			path: ../../phpunit/tag/ListTagTest.php

tests/phpstan/configs/phpstan-bugs.neon

@@ -17,3 +17,9 @@ parameters:
 			identifier: assign.propertyType
 			count: 1
 			path: ../../../src/tag/ListTag.php
+
+		-
+			message: '#^Call to function is_string\(\) with string will always evaluate to true\.$#'
+			identifier: function.alreadyNarrowedType
+			count: 1
+			path: ../../phpunit/tag/CompoundTagTest.php

tests/phpunit/JsonNbtParserTest.php

@@ -56,13 +56,11 @@ public function testParseGarbage() : void{
 
 	public function testEmptyCompound() : void{
 		$tag = JsonNbtParser::parseJson("{}");
-		self::assertNotNull($tag);
 		self::assertCount(0, $tag);
 	}
 
 	public function testEmptyList() : void{
 		$tag = JsonNbtParser::parseJson("{TestList:[]}");
-		self::assertNotNull($tag);
 		$list = $tag->getTag("TestList");
 		self::assertTrue($list instanceof ListTag);
 		self::assertCount(0, $list);

tests/phpunit/tag/CompoundTagTest.php

@@ -129,7 +129,9 @@ public function testEquals() : void{
 
 		self::assertTrue($tag1->equals($tag2));
 
-		$tag2->getCompoundTag("child9")->setFloat("hello", 1.0);
+		$child9 = $tag2->getCompoundTag("child9");
+		self::assertNotNull($child9);
+		$child9->setFloat("hello", 1.0);
 		self::assertNotTrue($tag1->equals($tag2));
 	}