Remove polling period from evaluator

Evaluator will receive events when poller changes, so naturally this
option was not even used. Although it could become a problem for
external pollers, but we will cross that bridge when (if) we get there.

Author: dee-kryvenko

api/autoscaler/v1alpha1/mostwantedtwophasehysteresisevaluation_types.go

@@ -25,10 +25,6 @@ import (
 type MostWantedTwoPhaseHysteresisEvaluationSpec struct {
 	common.EvaluatorSpec `json:",inline"`
 
-	// PollingPeriod is the period for polling the partitioning.
-	// +kubebuilder:validation:Required
-	PollingPeriod metav1.Duration `json:"pollingPeriod,omitempty"`
-
 	// StabilizationPeriod is the amount of time to wait before evaluating historical records.
 	// Older historical records are always pruned.
 	// +kubebuilder:validation:Required

api/autoscaler/v1alpha1/zz_generated.deepcopy.go

@@ -75,17 +75,13 @@ spec:
                 - name
                 type: object
                 x-kubernetes-map-type: atomic
-              pollingPeriod:
-                description: PollingPeriod is the period for polling the partitioning.
-                type: string
               stabilizationPeriod:
                 description: |-
                   StabilizationPeriod is the amount of time to wait before evaluating historical records.
                   Older historical records are always pruned.
                 type: string
             required:
             - partitionProviderRef
-            - pollingPeriod
             - stabilizationPeriod
             type: object
           status:

config/crd/bases/autoscaler.argoproj.io_mostwantedtwophasehysteresisevaluations.yaml

@@ -9,5 +9,4 @@ spec:
     apiGroup: autoscaler.argoproj.io
     kind: LongestProcessingTimePartition
     name: default
-  pollingPeriod: 1h
   stabilizationPeriod: 24h

config/default-scaling-strategy/autoscaler_v1alpha1_mostwantedtwophasehysteresisevaluation.yaml

@@ -9,48 +9,48 @@ spec:
     apiGroup: autoscaler.argoproj.io
     kind: SecretTypeClusterShardManager
     name: default
-  period: 1h
+  period: 1m
   address: http://prometheus.prometheus.svc.cluster.local:9090
   metrics:
   - id: argocd_app_info
     query: |-
       quantile_over_time(
-        0.50,
+        0.95,
         (
           sum(argocd_app_info{job="argocd-metrics",namespace="{{ .namespace }}",dest_server="{{ .server }}"})
-        )[24h:1m]
+        )[1h:1m]
       )
   - id: argocd_cluster_api_resource_objects
     query: |-
       quantile_over_time(
-        0.50,
+        0.95,
         (
           sum(argocd_cluster_api_resource_objects{job="argocd-metrics",namespace="{{ .namespace }}",server="{{ .server }}"})
-        )[24h:1m]
+        )[1h:1m]
       )
   - id: argocd_cluster_api_resources
     query: |-
       quantile_over_time(
-        0.50,
+        0.95,
         (
           sum(argocd_cluster_api_resources{job="argocd-metrics",namespace="{{ .namespace }}",server="{{ .server }}"})
-        )[24h:1m]
+        )[1h:1m]
       )
   - id: argocd_app_reconcile_count
     query: |-
       quantile_over_time(
-        0.50,
+        0.95,
         (
           sum(increase(argocd_app_reconcile_count{job="argocd-metrics",namespace="{{ .namespace }}",dest_server="{{ .server }}"}[1m]))
-        )[24h:1m]
+        )[1h:1m]
       )
   - id: argocd_cluster_events_total
     query: |-
       quantile_over_time(
-        0.50,
+        0.95,
         (
           sum(increase(argocd_cluster_events_total{job="argocd-metrics",namespace="{{ .namespace }}",server="{{ .server }}"}[1m]))
-        )[24h:1m]
+        )[1h:1m]
       )
   - id: argocd_app_k8s_request_total
     noData: "0"
@@ -61,10 +61,10 @@ spec:
         {{- $server = "https://100.64.0.1:443" -}}
       {{- end -}}
       quantile_over_time(
-        0.50,
+        0.95,
         (
           sum(increase(argocd_app_k8s_request_total{job="argocd-metrics",namespace="{{ .namespace }}",server="{{ $server }}"}[1m]))
-        )[24h:1m]
+        )[1h:1m]
       )
   - id: rest_client_requests_total
     query: |-
@@ -75,8 +75,8 @@ spec:
         {{- $host = "100.64.0.1:443" -}}
       {{- end -}}
       quantile_over_time(
-        0.50,
+        0.95,
         (
           sum(increase(rest_client_requests_total{job="argocd-metrics",namespace="{{ .namespace }}",host="{{ $host }}"}[1m]))
-        )[24h:1m]
+        )[1h:1m]
       )

config/default-scaling-strategy/autoscaler_v1alpha1_prometheuspoll.yaml

@@ -9,5 +9,4 @@ spec:
     apiGroup: autoscaler.argoproj.io
     kind: LongestProcessingTimePartition
     name: sample
-  pollingPeriod: 5s
   stabilizationPeriod: 1m

config/e2e/samples/autoscaler_v1alpha1_mostwantedtwophasehysteresisevaluation.yaml

@@ -336,8 +336,8 @@ func (r *MostWantedTwoPhaseHysteresisEvaluationReconciler) Reconcile(ctx context
 	}
 	log.Info("Resource status updated", "projection", len(evaluation.Status.Projection))
 
-	// Re-queue for the next poll
-	return ctrl.Result{RequeueAfter: evaluation.Spec.PollingPeriod.Duration}, nil
+	// We should get a reconciliation request when poller is changed
+	return ctrl.Result{}, nil
 }
 
 // SetupWithManager sets up the controller with the Manager.

internal/controller/autoscaler/mostwantedtwophasehysteresisevaluation_controller.go

@@ -82,7 +82,6 @@ var _ = Describe("MostWantedTwoPhaseHysteresisEvaluation Controller", func() {
 								Name: "N/A",
 							},
 						},
-						PollingPeriod:       metav1.Duration{Duration: time.Second},
 						StabilizationPeriod: metav1.Duration{Duration: 5 * time.Minute},
 					},
 				},
@@ -209,7 +208,7 @@ var _ = Describe("MostWantedTwoPhaseHysteresisEvaluation Controller", func() {
 			func(run *ScenarioRun[*autoscalerv1alpha1.MostWantedTwoPhaseHysteresisEvaluation]) {
 				Expect(run.ReconcileError()).ToNot(HaveOccurred())
 				Expect(run.ReconcileResult().RequeueAfter).
-					To(Equal(run.Container().Object().Spec.PollingPeriod.Duration))
+					To(Equal(time.Duration(0)))
 				Expect(run.ReconcileResult().Requeue).To(BeFalse())
 
 				By("Checking conditions")
@@ -248,7 +247,7 @@ var _ = Describe("MostWantedTwoPhaseHysteresisEvaluation Controller", func() {
 
 				Expect(run.ReconcileError()).ToNot(HaveOccurred())
 				Expect(run.ReconcileResult().RequeueAfter).
-					To(Equal(run.Container().Object().Spec.PollingPeriod.Duration))
+					To(Equal(time.Duration(0)))
 				Expect(run.ReconcileResult().Requeue).To(BeFalse())
 
 				By("Checking conditions")