Prepare for the 0.3.2 release

Author: 38

CHANGELOG.md

@@ -1,15 +1,23 @@
 # Changelog
 
-## Plotters latest (?)
+## Plotters 0.3.3 (?)
+
+## Plotters 0.3.2 (2022-07-05)
 
 ### Added
 
-- Pie element (by hhamana)
+- Pie element (by @hhamana)
 
 ### Improved
 
-- Improved documentaiton for predefined colors. (Thanks to siefkenj)
-- Introduce the full Material Design 2014 Color Palette. (Thanks to siefkenj)
+- Improved documentaiton for predefined colors. (Thanks to @siefkenj)
+- Introduce the full Material Design 2014 Color Palette. (Thanks to @siefkenj)
+- Massive documentation improvements (Thanks to @facorread and many others)
+
+### Fixed
+
+- More float point axis key point algorithm fixes (@38)
+- Default rasterizer fixes (@shinmili and @38)
 
 ## Plotters 0.3.1 (2021-05-21)
 
@@ -26,6 +34,7 @@
 - Examples that uses old APIs (thanks to chrisduerr)
 
 ## Plotters 0.3.0 (2020-09-03)
+
 This is the next major release of Plotters, see [release notes](./RELEASE-NOTES.md) for more detials.
 
 ### Added
@@ -44,26 +53,28 @@ This is the next major release of Plotters, see [release notes](./RELEASE-NOTES.
 ### Improvement
 
 - Enhanced key point algorithms: New key point hint trait are used for key point algorithms && many improvment on key point algorithms for different types
-- Renamed `MeshStyle::line\_style\_1\ and `MeshStyle::line\_style\_2` to `bold\_line\_style` and `light\_line\_style`
-- Reorganize the "plotters::coord" namespace 
+- Renamed `MeshStyle::line\_style\_1` and `MeshStyle::line\_style\_2` to `bold\_line\_style` and `light\_line\_style`
+- Reorganize the "plotters::coord" namespace
 - Improved discrete coordinate trait
 - Split backend code into isolated crates and can be maintained indepdendenly
 - Category coordinate is now replaced by slice coordinate
-- Removing the requirement for `Debug` trait for chart coordinate, allows ranged coordinate define its own formatting function. 
+- Removing the requirement for `Debug` trait for chart coordinate, allows ranged coordinate define its own formatting function.
 
 ### Removed
 
 - The `Path` name alias for `PathElement`
-- Most code `plotters::drawing::backend\_impl::\* ` (expect `MockedBackend` for testing purpose) is removed due to crate split. 
+- Most code `plotters::drawing::backend\_impl::\*` (expect `MockedBackend` for testing purpose) is removed due to crate split. 
 - Piston backend due to the Piston project seems not actively developing
 
 ## Plotters 0.2.15 (2020-05-26)
+
 ### Fixed
 
 - Division by zero with logarithmic coord (issue #143)
 - Update dependencies
 
 ## Plotters 0.2.14 (2020-05-05)
+
 ### Fixed
 
 - Compile error with older rustc which causing breaks

doc-template/latest_version

@@ -1 +1 @@
-0.3.1
+0.3.2

plotters-backend/src/lib.rs

@@ -174,6 +174,7 @@ pub trait DrawingBackend: Sized {
             for end in path.into_iter() {
                 if let Some(begin) = begin {
                     let result = self.draw_line(begin, end, style);
+                    #[allow(clippy::question_mark)]
                     if result.is_err() {
                         return result;
                     }
@@ -290,11 +291,11 @@ pub trait DrawingBackend: Sized {
     /// TODO: The default implementation of bitmap blitting assumes that the bitmap is RGB, but
     /// this may not be the case. But for bitmap backend it's actually ok if we use the bitmap
     /// element that matches the pixel format, but we need to fix this.
-    fn blit_bitmap<'a>(
+    fn blit_bitmap(
         &mut self,
         pos: BackendCoord,
         (iw, ih): (u32, u32),
-        src: &'a [u8],
+        src: &[u8],
     ) -> Result<(), DrawingErrorKind<Self::ErrorType>> {
         let (w, h) = self.get_size();
 
@@ -315,6 +316,7 @@ pub trait DrawingBackend: Sized {
                     rgb: (r, g, b),
                 };
                 let result = self.draw_pixel((pos.0 + dx as i32, pos.1 + dy as i32), color);
+                #[allow(clippy::question_mark)]
                 if result.is_err() {
                     return result;
                 }

plotters-backend/src/rasterizer/line.rs

@@ -109,7 +109,7 @@ pub fn draw_line<DB: DrawingBackend, S: BackendStyle>(
         y += grad;
     }
 
-    if to.0 >= batch_limit + 1 && y < f64::from(to.1) {
+    if to.0 > batch_limit && y < f64::from(to.1) {
         let x = batch_limit as i32 + 1;
         if 1.0 + y.floor() - y > 1e-5 {
             check_result!(put_pixel((x, y as i32), 1.0 + y.floor() - y));

plotters-backend/src/rasterizer/mod.rs

@@ -6,10 +6,19 @@
 
 */
 
-// TODO: ? operator is very slow. See issue #58 for details
+// TODO: We need to revisit this. It has been a long time since last time we figured out
+// the question mark operator has a huge performance impact due to LLVM unable to handle it.
+// So the question is if this trick is still useful, or LLVM is smart enough to handle it since
+// then.
+// 
+// --
+// Original comment:
+//
+// ? operator is very slow. See issue #58 for details
 macro_rules! check_result {
     ($e:expr) => {
         let result = $e;
+        #[allow(clippy::question_mark)]
         if result.is_err() {
             return result;
         }

plotters-backend/src/rasterizer/path.rs

@@ -122,7 +122,7 @@ fn traverse_vertices<'a>(
         recent.swap(1, 2);
         recent[2] = *p;
         compute_polygon_vertex(&recent, f64::from(width) / 2.0, &mut vertex_buf);
-        vertex_buf.iter().cloned().for_each(|v| op(v));
+        vertex_buf.iter().cloned().for_each(&mut op);
     }
 
     let b = recent[1];

plotters-backend/src/text.rs

@@ -241,6 +241,7 @@ pub trait BackendTextStyle {
 
     fn family(&self) -> FontFamily;
 
+    #[allow(clippy::type_complexity)]
     fn layout_box(&self, text: &str) -> Result<((i32, i32), (i32, i32)), Self::FontError>;
 
     fn draw<E, DrawFunc: FnMut(i32, i32, BackendColor) -> Result<(), E>>(

plotters-bitmap/src/bitmap.rs

@@ -289,11 +289,11 @@ impl<'a, P: PixelFormat> DrawingBackend for BitMapBackend<'a, P> {
         plotters_backend::rasterizer::draw_rect(self, upper_left, bottom_right, style, fill)
     }
 
-    fn blit_bitmap<'b>(
+    fn blit_bitmap(
         &mut self,
         pos: BackendCoord,
         (sw, sh): (u32, u32),
-        src: &'b [u8],
+        src: &[u8],
     ) -> Result<(), DrawingErrorKind<Self::ErrorType>> {
         let (dw, dh) = self.get_size();
 

plotters-svg/src/svg.rs

@@ -45,7 +45,7 @@ impl Target<'_> {
 }
 
 enum SVGTag {
-    SVG,
+    Svg,
     Circle,
     Line,
     Polygon,
@@ -59,7 +59,7 @@ enum SVGTag {
 impl SVGTag {
     fn to_tag_name(&self) -> &'static str {
         match self {
-            SVGTag::SVG => "svg",
+            SVGTag::Svg => "svg",
             SVGTag::Circle => "circle",
             SVGTag::Line => "line",
             SVGTag::Polyline => "polyline",
@@ -92,14 +92,14 @@ impl<'a> SVGBackend<'a> {
     }
     fn open_tag(&mut self, tag: SVGTag, attr: &[(&str, &str)], close: bool) {
         let buf = self.target.get_mut();
-        buf.push_str("<");
+        buf.push('<');
         buf.push_str(tag.to_tag_name());
         for (key, value) in attr {
-            buf.push_str(" ");
+            buf.push(' ');
             buf.push_str(key);
             buf.push_str("=\"");
             Self::escape_and_push(buf, value);
-            buf.push_str("\"");
+            buf.push('\"');
         }
         if close {
             buf.push_str("/>\n");
@@ -122,7 +122,7 @@ impl<'a> SVGBackend<'a> {
 
     fn init_svg_file(&mut self, size: (u32, u32)) {
         self.open_tag(
-            SVGTag::SVG,
+            SVGTag::Svg,
             &[
                 ("width", &format!("{}", size.0)),
                 ("height", &format!("{}", size.1)),
@@ -472,7 +472,7 @@ impl<'a> DrawingBackend for SVGBackend<'a> {
         );
 
         Self::escape_and_push(self.target.get_mut(), text);
-        self.target.get_mut().push_str("\n");
+        self.target.get_mut().push('\n');
 
         self.close_tag();
 

plotters/clippy.toml

@@ -1 +1 @@
-msrv = "1.39"
+msrv = "1.56"