Skip to content

Commit a09814b

Browse files
committed
Improve and approve new palmerpenguin visual baselines. Also make sure docker container installs dependencies at run-time
1 parent 273b1ed commit a09814b

34 files changed

+40
-41
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,3 +18,4 @@ revdep/
1818
travis_debug.R
1919
.httr-oauth
2020
tests/testthat/Rplots.pdf
21+
inst/examples/shiny/event_data/tests/shinytest/mytest-current/

inst/docker/Dockerfile.vtest

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,9 @@ RUN R -e "remotes::install_github('r-lib/vdiffr')"
9595
# install any new dependencies, then either manage cases (the default) or run tests
9696
# note the workaround to get docker to run a proper exit status when there are testthat errors
9797
# https://github.com/r-lib/testthat/issues/515#issuecomment-304169376
98-
CMD R -e "remotes::install_deps(dependencies = TRUE)"
9998

100-
CMD cd /home/plotly; R -e "if (!identical(Sys.getenv('VMODE'), 'ci')) vdiffr::manage_cases(); \
99+
CMD cd /home/plotly; R -e "remotes::install_deps(dependencies = T); \
100+
if (!identical(Sys.getenv('VMODE'), 'ci')) vdiffr::manage_cases(); \
101101
res <- devtools::test(reporter='summary'); \
102102
df <- as.data.frame(res); \
103103
if (sum(df\$failed) > 0 || any(df\$error)) q(status=1)"

tests/figs/density2d/density2d.svg

Lines changed: 1 addition & 1 deletion
Loading

tests/figs/ggplot-themes/theme-background.svg

Lines changed: 1 addition & 1 deletion
Loading

tests/figs/ggplot-themes/theme-panel-border-1.svg

Lines changed: 1 addition & 1 deletion
Loading

tests/figs/ggplot-themes/theme-panel-border-2.svg

Lines changed: 1 addition & 1 deletion
Loading

tests/figs/ggplot-themes/theme-ticks-and-grids.svg

Lines changed: 1 addition & 1 deletion
Loading

tests/figs/ggplot-themes/theme-ticks-default.svg

Lines changed: 1 addition & 1 deletion
Loading

tests/figs/ggplot-themes/theme-zeroline-default.svg

Lines changed: 1 addition & 1 deletion
Loading

tests/figs/labels/labels-angles.svg

Lines changed: 1 addition & 1 deletion
Loading

0 commit comments

Comments
 (0)