Feature/enable tests api layer (#3)

* Enable tests on the API layer. Fixing the first set of issues after the build pipeline migration.
* Fix all the broken tests in the API layer.
* Update build script to include the xml code coverage results.

Author: gjong

.github/workflows/component-build.yml

@@ -24,7 +24,7 @@ jobs:
           path: |
             **/build/classes/**
             **/build/libs/*.jar
-            **/build/jacoco/*.exec
+            **/build/reports/jacoco/test/*.xml
       - name: Upload test results
         uses: actions/upload-artifact@v4
         with:

fintrack-api/build.gradle.kts

@@ -1,28 +1,32 @@
 plugins {
     id("io.micronaut.application")
-    id("io.freefair.lombok")
 }
-//mainClassName = "com.jongsoft.finance.Application"
 
+application {
+    mainClass.set("com.jongsoft.finance.Application")
+}
 
-//jar {
-//    manifest {
-//        attributes('Main-Class': 'com.jongsoft.finance.Application')
-//    }
-//}
+micronaut {
+    runtime("jetty")
+    testRuntime("junit5")
+}
 
 dependencies {
-    annotationProcessor("io.micronaut.openapi:micronaut-openapi")
+    annotationProcessor(mn.micronaut.openapi.asProvider())
+    annotationProcessor(mn.micronaut.http.validation)
+    annotationProcessor(mn.micronaut.validation.processor)
+    annotationProcessor(mn.micronaut.inject.java)
 
     implementation(libs.camunda)
     implementation(mn.swagger.annotations)
+
+    implementation(mn.micronaut.validation)
     implementation(mn.micronaut.security.annotations)
     implementation(mn.micronaut.security.jwt)
     implementation(mn.micronaut.http.server.jetty)
+    implementation(mn.micronaut.http.validation)
 
-    implementation(mn.micronaut.hibernate.validator)
-
-    implementation("at.favre.lib:bcrypt:0.9.0")
+    implementation(libs.bcrypt)
     implementation(libs.bouncy)
     implementation(libs.bcpkix)
     implementation(libs.otp)
@@ -36,6 +40,7 @@ dependencies {
 
     // Investigate if this can be swapped for micronaut serde
     implementation(mn.micronaut.jackson.databind)
+    implementation(mn.micronaut.serde.jackson)
 
     implementation(project(":core"))
     implementation(project(":domain"))

fintrack-api/src/main/java/com/jongsoft/finance/factory/EventBusFactory.java

@@ -4,12 +4,14 @@
 import io.micronaut.context.annotation.Context;
 import io.micronaut.context.annotation.Factory;
 import io.micronaut.context.event.ApplicationEventPublisher;
-import lombok.extern.slf4j.Slf4j;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
-@Slf4j
 @Factory
 public class EventBusFactory {
 
+    private final Logger log = LoggerFactory.getLogger(EventBusFactory.class);
+
     @Context
     public EventBus eventBus(ApplicationEventPublisher eventPublisher) {
         log.info("Staring the event bus");

fintrack-api/src/main/java/com/jongsoft/finance/filter/AuthenticationFilter.java

@@ -11,23 +11,27 @@
 import io.micronaut.http.filter.ServerFilterChain;
 import io.micronaut.http.filter.ServerFilterPhase;
 import io.micronaut.serde.ObjectMapper;
-import jakarta.inject.Inject;
-import lombok.RequiredArgsConstructor;
-import lombok.extern.slf4j.Slf4j;
 import org.reactivestreams.Publisher;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.security.Principal;
 import java.time.Duration;
 import java.time.Instant;
 
-@Slf4j
 @Filter("/**")
-@RequiredArgsConstructor(onConstructor_ = @Inject)
 public class AuthenticationFilter implements HttpServerFilter {
 
+    private final Logger log = LoggerFactory.getLogger(AuthenticationFilter.class);
+
     private final ApplicationEventPublisher<InternalAuthenticationEvent> eventPublisher;
     private final ObjectMapper objectMapper;
 
+    public AuthenticationFilter(ApplicationEventPublisher<InternalAuthenticationEvent> eventPublisher, ObjectMapper objectMapper) {
+        this.eventPublisher = eventPublisher;
+        this.objectMapper = objectMapper;
+    }
+
     @Override
     public int getOrder() {
         return ServerFilterPhase.SECURITY.after();

fintrack-api/src/main/java/com/jongsoft/finance/filter/CurrencyHeaderFilter.java

@@ -6,16 +6,17 @@
 import io.micronaut.http.annotation.Filter;
 import io.micronaut.http.filter.HttpServerFilter;
 import io.micronaut.http.filter.ServerFilterChain;
-import jakarta.inject.Inject;
-import lombok.RequiredArgsConstructor;
 import org.reactivestreams.Publisher;
 
 @Filter("/**")
-@RequiredArgsConstructor(onConstructor_ = @Inject)
 public class CurrencyHeaderFilter implements HttpServerFilter {
 
     private final CurrencyProvider currencyProvider;
 
+    public CurrencyHeaderFilter(CurrencyProvider currencyProvider) {
+        this.currencyProvider = currencyProvider;
+    }
+
     @Override
     public Publisher<MutableHttpResponse<?>> doFilter(final HttpRequest<?> request, final ServerFilterChain chain) {
         var requestedCurrency = request.getHeaders().get("X-Accept-Currency", String.class);

fintrack-api/src/main/java/com/jongsoft/finance/filter/LocaleHeaderFilter.java

@@ -5,15 +5,17 @@
 import io.micronaut.http.annotation.Filter;
 import io.micronaut.http.filter.HttpServerFilter;
 import io.micronaut.http.filter.ServerFilterChain;
-import lombok.extern.slf4j.Slf4j;
 import org.reactivestreams.Publisher;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.util.Locale;
 
-@Slf4j
 @Filter("/**")
 public class LocaleHeaderFilter implements HttpServerFilter {
 
+    private final Logger log = LoggerFactory.getLogger(LocaleHeaderFilter.class);
+
     @Override
     public Publisher<MutableHttpResponse<?>> doFilter(HttpRequest<?> request, ServerFilterChain chain) {
         log.debug("Filtering for locale {}", request.getHeaders().get("Accept-Language"));

fintrack-api/src/main/java/com/jongsoft/finance/filter/StatusExceptionHandler.java

@@ -9,13 +9,15 @@
 import io.micronaut.http.hateoas.Link;
 import io.micronaut.http.server.exceptions.ExceptionHandler;
 import jakarta.inject.Singleton;
-import lombok.extern.slf4j.Slf4j;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
-@Slf4j
 @Produces
 @Singleton
 public class StatusExceptionHandler implements ExceptionHandler<StatusException, HttpResponse<JsonError>> {
 
+    private final Logger log = LoggerFactory.getLogger(StatusExceptionHandler.class);
+
     @Override
     public HttpResponse<JsonError> handle(HttpRequest request, StatusException exception) {
         if (exception.getStatusCode() != 404) {

fintrack-api/src/main/java/com/jongsoft/finance/rest/StaticResource.java

@@ -13,17 +13,18 @@
 import io.micronaut.security.rules.SecurityRule;
 import io.swagger.v3.oas.annotations.Operation;
 import jakarta.inject.Inject;
-import lombok.extern.slf4j.Slf4j;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.IOException;
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.net.URL;
 
-@Slf4j
 @Controller
 @Secured(SecurityRule.IS_ANONYMOUS)
 public class StaticResource {
+    private final Logger log = LoggerFactory.getLogger(StaticResource.class);
 
     @Inject
     ResourceResolver res;
@@ -42,7 +43,7 @@ public HttpResponse<?> favicon() {
     @Operation(hidden = true)
     @Get("/ui/{path:([^\\.]+)$}")
     @Produces(MediaType.TEXT_HTML)
-    public HttpResponse<?> refresh() {
+    public HttpResponse<?> refresh(@PathVariable String path) {
         return resource("index.html");
     }
 

fintrack-api/src/main/java/com/jongsoft/finance/rest/account/AccountEditRequest.java

@@ -3,9 +3,7 @@
 import com.jongsoft.finance.schedule.Periodicity;
 import io.micronaut.serde.annotation.Serdeable;
 import jakarta.validation.constraints.*;
-import lombok.Builder;
 
-@Builder
 @Serdeable
 class AccountEditRequest {
 
@@ -34,6 +32,18 @@ class AccountEditRequest {
     @NotNull
     private String type;
 
+    public AccountEditRequest(String name, String description,String currency, String iban, String bic, String number, double interest, Periodicity interestPeriodicity, String type) {
+        this.name = name;
+        this.description = description;
+        this.currency = currency;
+        this.iban = iban;
+        this.bic = bic;
+        this.number = number;
+        this.interest = interest;
+        this.interestPeriodicity = interestPeriodicity;
+        this.type = type;
+    }
+
     public String getName() {
         return name;
     }

fintrack-api/src/main/java/com/jongsoft/finance/rest/account/AccountEditResource.java

@@ -17,22 +17,22 @@
 import io.swagger.v3.oas.annotations.media.Schema;
 import io.swagger.v3.oas.annotations.responses.ApiResponse;
 import io.swagger.v3.oas.annotations.tags.Tag;
-import jakarta.inject.Inject;
 import jakarta.validation.Valid;
 import jakarta.validation.constraints.Positive;
-import lombok.RequiredArgsConstructor;
 
 import java.math.BigDecimal;
 
 @Controller("/api/accounts/{accountId}")
 @Tag(name = "Account information")
 @Secured(SecurityRule.IS_AUTHENTICATED)
-@RequiredArgsConstructor(onConstructor_ = @Inject)
 public class AccountEditResource {
 
-    private final CurrentUserProvider currentUserProvider;
     private final AccountProvider accountProvider;
 
+    public AccountEditResource(AccountProvider accountProvider) {
+        this.accountProvider = accountProvider;
+    }
+
     @Get
     @Operation(
             summary = "Get Account",
@@ -155,9 +155,9 @@ AccountResponse createSavingGoal(
         accountProvider.lookup(accountId)
                 .ifPresent(account ->
                         account.createSavingGoal(
-                                request.getName(),
-                                request.getGoal(),
-                                request.getTargetDate()))
+                                request.name(),
+                                request.goal(),
+                                request.targetDate()))
                 .elseThrow(() -> StatusException.notFound("No account found for id " + accountId));
 
         return accountProvider.lookup(accountId)
@@ -181,7 +181,7 @@ AccountResponse adjustSavingGoal(
                         account.getSavingGoals()
                                 .filter(goal -> goal.getId() == savingId)
                                 .head()
-                                .adjustGoal(request.getGoal(), request.getTargetDate()))
+                                .adjustGoal(request.goal(), request.targetDate()))
                 .elseThrow(() -> StatusException.notFound("No account found for id " + accountId));
 
         return accountProvider.lookup(accountId)