Update pagination logic and remove unused SettingProvider (#98)

Author: gjong

fintrack-api/src/main/java/com/jongsoft/finance/rest/account/AccountTransactionResource.java

@@ -80,7 +80,7 @@ ResultPageResponse<TransactionResponse> search(
                 .range(Dates.range(
                         request.dateRange().start(),
                         request.dateRange().end()))
-                .page(request.getPage(), settingProvider.getPageSize());
+                .page(request.getPage(), Integer.MAX_VALUE);
 
         if (request.text() != null) {
             command.description(request.text(), false);

fintrack-api/src/main/java/com/jongsoft/finance/rest/transaction/TransactionResource.java

@@ -8,7 +8,6 @@
 import com.jongsoft.finance.messaging.EventBus;
 import com.jongsoft.finance.providers.AccountProvider;
 import com.jongsoft.finance.providers.AccountTypeProvider;
-import com.jongsoft.finance.providers.SettingProvider;
 import com.jongsoft.finance.providers.TransactionProvider;
 import com.jongsoft.finance.rest.model.ResultPageResponse;
 import com.jongsoft.finance.rest.model.TransactionResponse;
@@ -42,16 +41,14 @@
 @Secured(AuthenticationRoles.IS_AUTHENTICATED)
 public class TransactionResource {
 
-    private final SettingProvider settingProvider;
     private final TransactionProvider transactionProvider;
     private final AccountProvider accountProvider;
     private final FilterFactory filterFactory;
     private final AccountTypeProvider accountTypeProvider;
     private final RuntimeResource runtimeResource;
     private final AuthenticationFacade authenticationFacade;
 
-    public TransactionResource(SettingProvider settingProvider, TransactionProvider transactionProvider, AccountProvider accountProvider, FilterFactory filterFactory, AccountTypeProvider accountTypeProvider, RuntimeResource runtimeResource, AuthenticationFacade authenticationFacade) {
-        this.settingProvider = settingProvider;
+    public TransactionResource(TransactionProvider transactionProvider, AccountProvider accountProvider, FilterFactory filterFactory, AccountTypeProvider accountTypeProvider, RuntimeResource runtimeResource, AuthenticationFacade authenticationFacade) {
         this.transactionProvider = transactionProvider;
         this.accountProvider = accountProvider;
         this.filterFactory = filterFactory;
@@ -71,7 +68,7 @@ ResultPageResponse<TransactionResponse> search(@Valid @Body TransactionSearchReq
                 .range(Dates.range(
                         request.getDateRange().start(),
                         request.getDateRange().end()))
-                .page(request.getPage(), settingProvider.getPageSize());
+                .page(request.getPage(), Integer.MAX_VALUE);
 
         Control.Option(request.getCategory())
                 .map(e -> new EntityRef(e.id()))

jpa-repository/src/main/java/com/jongsoft/finance/jpa/query/JpaQuery.java

@@ -194,7 +194,12 @@ public Optional<E> singleResult() {
      */
     public ResultPage<E> paged() {
         var countHql = "SELECT count(DISTINCT e.id) %s".formatted(generateHql(false));
-        var numberOfRecords = createQuery(Long.class, countHql).getSingleResult();
+        var query = entityManager.createQuery(countHql, Long.class);
+        for (var condition : conditions()) {
+            condition.addParameters(query);
+        }
+
+        var numberOfRecords = query.getSingleResult();
         var limit = limitRows == null ? Integer.MAX_VALUE : limitRows;
         if (numberOfRecords > 0) {
             // only run the actual query if we had hits in the count query.

jpa-repository/src/test/java/com/jongsoft/finance/jpa/account/AccountProviderJpaIT.java

@@ -92,6 +92,31 @@ void lookup_name() {
         Assertions.assertThat(account.getUser()).isEqualTo(new UserIdentifier("demo-user"));
     }
 
+    @Test
+    void lookup_page1() {
+        var filter = filterFactory.account()
+                .page(0, 1);
+
+        var check = accountProvider.lookup(filter);
+
+        Assertions.assertThat(check.total()).isEqualTo(1);
+        Assertions.assertThat(check.content())
+                .hasSize(1)
+                .extracting("name")
+                .contains("Account One");
+    }
+
+    @Test
+    void lookup_page2() {
+        var filter = filterFactory.account()
+                .page(1, 1);
+
+        var check = accountProvider.lookup(filter);
+
+        Assertions.assertThat(check.total()).isEqualTo(1);
+        Assertions.assertThat(check.content()).isEmpty();
+    }
+
     @Test
     void lookup_partialName() {
         var filter = filterFactory.account()