Skip to content

Commit 708a412

Browse files
committed
comments and review fixes
1 parent 76e3d1a commit 708a412

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

workflow/src/main.tpl.tengo

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ wf.body(func(args) {
2222
if is_undefined(datasetRef) {
2323
ll.panic("Dataset is undefined")
2424
}
25+
// it's blockId of MiXCR, we suppose that it procuce only one clns column
2526
datasets[datasetRef.blockId] = wf.resolve(datasetRef)
2627
}
2728

workflow/src/prepare-donor-column.lib.tengo

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ groupDataByDonorId := func(donorColumn, datasets) {
2424

2525
resultSpec := {
2626
// annotations and domain could differ between datasets
27-
"annotations": {},
28-
"domain": {},
2927
"axesSpec": [
3028
{
3129
"annotations": donorColumnSpec["annotations"],
@@ -38,7 +36,6 @@ groupDataByDonorId := func(donorColumn, datasets) {
3836
"annotations": {
3937
"pl7.app/label": "Clonotyping block id"
4038
},
41-
"domain": {},
4239
"name": "pl7.app/blockId",
4340
"type": "String"
4441
}

workflow/src/process.tpl.tengo

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,10 @@ pframes := import("@platforma-sdk/workflow-tengo:pframes")
1212
reconstructShmTreesTpl := assets.importTemplate(":reconstruct-shm-trees")
1313

1414
// this templete should run only after resolving of all inputs
15-
self.awaitState("datasets", { wildcard: "*" }, "ResourceReady")
15+
// we don't need to wait for file content, just refs
16+
self.awaitState("datasets", { wildcard: "*" }, "data", "InputsLocked")
17+
// but we need spec already
18+
self.awaitState("datasets", { wildcard: "*" }, "spec", "ResourceReady")
1619
self.awaitState("donorColumn", "ResourceReady")
1720

1821
self.body(func(inputs) {

0 commit comments

Comments
 (0)