Skip to content

Commit 512defb

Browse files
Bump org.seleniumhq.selenium:selenium-java from 4.12.1 to 4.17.0 in /Plan (#3434)
* Bump org.seleniumhq.selenium:selenium-java in /Plan Bumps [org.seleniumhq.selenium:selenium-java](https://github.com/SeleniumHQ/selenium) from 4.12.1 to 4.17.0. - [Release notes](https://github.com/SeleniumHQ/selenium/releases) - [Commits](https://github.com/SeleniumHQ/selenium/commits/selenium-4.17.0) --- updated-dependencies: - dependency-name: org.seleniumhq.selenium:selenium-java dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Use new headless setup method --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Aurora Lahtela <24460436+AuroraLS3@users.noreply.github.com>
1 parent 89355d4 commit 512defb

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Plan/common/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ dependencies {
9494
testArtifacts project(":extensions:adventure")
9595
testImplementation project(":extensions:adventure")
9696
testImplementation "com.google.code.gson:gson:$gsonVersion"
97-
testImplementation "org.seleniumhq.selenium:selenium-java:4.12.1"
97+
testImplementation "org.seleniumhq.selenium:selenium-java:4.17.0"
9898
testImplementation "org.testcontainers:testcontainers:$testContainersVersion"
9999
testImplementation "org.testcontainers:junit-jupiter:$testContainersVersion"
100100
testImplementation "org.testcontainers:nginx:$testContainersVersion"

Plan/common/src/test/java/extension/SeleniumExtension.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public static void newTab(WebDriver driver) {
4949

5050
public static void waitForPageLoadForSeconds(int i, ChromeDriver driver) {
5151
Awaitility.await("waitForPageLoadForSeconds")
52-
.atMost(5, TimeUnit.SECONDS)
52+
.atMost(i, TimeUnit.SECONDS)
5353
.until(() -> "complete".equals(driver.executeScript("return document.readyState")));
5454
}
5555

@@ -92,7 +92,7 @@ private ChromeDriver getChromeWebDriver() {
9292
// Using environment variable assumes linux
9393
if (System.getenv(CIProperties.CHROME_DRIVER) != null) {
9494
chromeOptions.setBinary("/usr/bin/google-chrome-stable");
95-
chromeOptions.setHeadless(true);
95+
chromeOptions.addArguments("--headless=new");
9696
}
9797

9898
return new ChromeDriver(chromeOptions);

0 commit comments

Comments
 (0)