migrate to async closures where possible

[GlenDC]

Most of the code, mostly examples and tests I imagine, in rama codebase which now uses the construct:

|...| async move {

can probably move to the async closures we now have access to since edition 2024 (MSRV 1.85)

async |...| {

and if move required:

async move |...| {

[harshithsaiv]

Hi @GlenDC! I'd love to contribute to this issue and learn more in the process. Please let me know how I can get started, and kindly assign this issue to me. Looking forward to your guidance!

[GlenDC]

Most certainly, I've assigned it to you @harshithsaiv .

As a first time contributor please do take your time to read through https://github.com/plabayo/rama/blob/main/CONTRIBUTING.md, especially the tip about using just qa is useful as it will ensure that stuff like formatting and clippy lints are respected prior to pushing it to a a Pull Request (PR).

The way I would start is honestly just global search / grep through the codebase for patterns like:

| async move {

e.g.

grep -rn --include="*.rs" '| async move {' .

But in case you use a Graphical IDE you can probably achieve the same with a global search :)

[GlenDC]

There are also a couple that have the following:

grep -rn --include="*.rs" '| async {' .

Those should also be migrated to async functions, where possible.

Note that there are still valid use cases for async (move) { ... }, future blocks,
e.g. for low level bits where you wish to create a future only at the end of an otherwise sync function.
So there might very well still be patterns that match at the end of this task, which should only be the valid use cases left.

[harshithsaiv]

Thank you, @GlenDC! I appreciate the guidance. I'll go through the CONTRIBUTING.md file and start searching for occurrences of async move { as suggested. I'll update you if I have any questions.

[GlenDC]

Awesome. Do let me know if you need further guidance, or have any other questions. Also feel free to open a (draft) PR, even when not everything is working (yet). Especially useful in case you are stuck in any way.

[GlenDC]

@harshithsaiv no pressure, but I do want to check in with you as a good mentor.
Are there any questions you have so far. Any pointers or guidance you need?
Do let me know, and feel free to share progress as soon as you can or feel comfortable.

[GlenDC]

I'll take this over next week FYI in case I hear nothing back from you. I'm sorry, but I'm starting to work towards a first rama release. Even if that's the case you are more than welcome to at any time contribute for another issue or anything else. We're happy to have you either way.