generated from orchestras/deno
-
Notifications
You must be signed in to change notification settings - Fork 0
feature/story_141: Report Hooks | Error Handlers | Aggregation #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tures -- automated
…tures -- automated
…tures -- automated
…tures -- automated
Contributor
|
v0.3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Information:
We added
$ruleset.getRulesetBypassList()as a method for pulling all bypassactors for all rulesets. This is a requirement as we finish the complete
Ruleset, Rule, and Branch Protection/ Bypass framework.
We also added a bunch of 0.2.9 types:
GithubRulesetand associated interfacesRulesetBypassActorfor bypassActor interfaceRulesetConditionRefNamefor rulesetConditions interfaceImplemented
customFieldsfor report types from dynamic object for use inrules reporting in pass/fail report scenarios
Implemented
custom exceptionsfor report typesImplemented
dynamic repository + ownerobject for executeCode() incustomFieldsby defaultImplemented
createReportfunction withhookswhich are now dynamicfunctions executed at runtime in
reportExecutionImplemented
createReportEntryfunction acceptingCustomWith*generic typesfor handling exceptions as part of the rules engine reporting feature.
Implemented
report.addEntryandReportingobject using observer pattern toaccept new entries and merge them into the JSON aggregation object.
Example: custom fields
In the below example we use
exts.$reporting.createReportEntry<exts.Type.ReportEntryWithNone<ReportRecord>>That is the
reportEntry typeand its interface allows:exts.Type.ReportEntryWithNone<ReportRecord>exts.Type.ReportEntryWithErrors<ReportRecord>This flexibility allows any developer to create custom fields and even custom
object types for the aggregate reporting capabilities:
type ReportRecord = Record<string, unknown>forcustomFieldsautomatically uses your type in the Report class.exts.$reporting.createReportto create a new report object for eachtest on each repository
exts.$reporting.notifyTeamsHookto create teams notifications as a hookanyFunctionas a hook inexts.$reporting.createReport