Skip to content

Commit b9b4c47

Browse files
committed
Setting PIXI version dependency >=6.0.4 <8.0.0
Also forcing typescript to ignore the child's index in the childRemoved event as requested. Additionally, adding contentIsolation option to the pixi-v6-module test, allowing the test to run successfully.
1 parent 97c103d commit b9b4c47

File tree

3 files changed

+19
-16
lines changed

3 files changed

+19
-16
lines changed

package.json

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -34,27 +34,27 @@
3434
"test": "echo done"
3535
},
3636
"peerDependencies": {
37-
"@pixi/constants": "^7.0.4",
38-
"@pixi/core": "^7.0.4",
39-
"@pixi/display": "^7.0.4",
40-
"@pixi/math": "^7.0.4",
41-
"@pixi/sprite": "^7.0.4",
42-
"@pixi/ticker": "^7.0.4"
37+
"@pixi/constants": ">=6.0.4 <8.0.0",
38+
"@pixi/core": ">=6.0.4 <8.0.0",
39+
"@pixi/display": ">=6.0.4 <8.0.0",
40+
"@pixi/math": ">=6.0.4 <8.0.0",
41+
"@pixi/sprite": ">=6.0.4 <8.0.0",
42+
"@pixi/ticker": ">=6.0.4 <8.0.0"
4343
},
4444
"devDependencies": {
45-
"@pixi/constants": "^7.0.4",
46-
"@pixi/core": "^7.0.4",
47-
"@pixi/display": "^7.0.4",
45+
"@pixi/constants": ">=6.0.4 <8.0.0",
46+
"@pixi/core": ">=6.0.4 <8.0.0",
47+
"@pixi/display": ">=6.0.4 <8.0.0",
4848
"@pixi/eslint-config": "^2.0.1",
49-
"@pixi/math": "^7.0.4",
50-
"@pixi/settings": "^7.0.4",
51-
"@pixi/sprite": "^7.0.4",
52-
"@pixi/ticker": "^7.0.4",
49+
"@pixi/math": ">=6.0.4 <8.0.0",
50+
"@pixi/settings": ">=6.0.4 <8.0.0",
51+
"@pixi/sprite": ">=6.0.4 <8.0.0",
52+
"@pixi/ticker": ">=6.0.4 <8.0.0",
5353
"electron": "^18.3.7",
5454
"eslint": "^7.2.0",
5555
"gh-pages": "^2.0.0",
5656
"ncp": "^2.0.0",
57-
"pixi.js": "^7.0.4",
57+
"pixi.js": ">=6.0.4 <8.0.0",
5858
"rimraf": "^2.5.4",
5959
"rollup": "^2.7.0",
6060
"rollup-plugin-commonjs": "^9.2.1",

src/LinkedListContainer.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,9 @@ export class LinkedListContainer extends Container
438438
// TODO - lets either do all callbacks or all events.. not both!
439439
this.onChildrenChange();
440440
child.emit('removed', this);
441-
this.emit('childRemoved', child, this, this._childCount);
441+
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
442+
// @ts-ignore
443+
this.emit('childRemoved', child, this);
442444
}
443445

444446
return children[0];

test/pixi-v6-module/main.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ function createWindow () {
1111
width: 800,
1212
height: 600,
1313
webPreferences: {
14-
nodeIntegration: true
14+
nodeIntegration: true,
15+
contextIsolation: false
1516
}
1617
});
1718

0 commit comments

Comments
 (0)