Skip to content

Commit 5616a50

Browse files
authored
[http] Re-introduce read optimization when buffer is empty (#907)
1 parent 5f11644 commit 5616a50

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

smart_open/http.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,10 @@ def read(self, size=-1):
181181
return b""
182182

183183
if size == -1:
184-
retval = self._read_buffer.read() + self.response.raw.read()
184+
if len(self._read_buffer):
185+
retval = self._read_buffer.read() + self.response.raw.read()
186+
else: # Avoid unnecessary +
187+
retval = self.response.raw.read()
185188
else:
186189
# Fill _read_buffer until it contains enough bytes
187190
while len(self._read_buffer) < size:

0 commit comments

Comments
 (0)