You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+11-1Lines changed: 11 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,6 +1,8 @@
1
1
> Please **pick a concise, informative and complete title** for your PR.
2
2
>
3
-
> The title is important because it will appear in [our change log](https://github.com/RaRe-Technologies/smart_open/blob/master/CHANGELOG.md).
3
+
> The title is important because it will appear in [`CHANGELOG.md`](/CHANGELOG.md).
4
+
5
+
4
6
5
7
### Motivation
6
8
@@ -12,6 +14,8 @@
12
14
13
15
Fixes #{issue_number}
14
16
17
+
18
+
15
19
### Tests
16
20
17
21
> If you're fixing a bug, consider [test-driven development](https://en.wikipedia.org/wiki/Test-driven_development):
@@ -29,6 +33,8 @@ Fixes #{issue_number}
29
33
>
30
34
> If there are any failures, please fix them before creating the PR (or mark it as WIP, see below).
31
35
36
+
37
+
32
38
### Work in progress
33
39
34
40
> If you're still working on your PR, mark the PR as [draft PR](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-stage-of-a-pull-request).
@@ -37,6 +43,8 @@ Fixes #{issue_number}
37
43
>
38
44
> Once it's ready, mark the PR as "ready for review", and ping one of the maintainers (e.g. mpenkov).
39
45
46
+
47
+
40
48
### Checklist
41
49
42
50
> Before you mark the PR as "ready for review", please make sure you have:
@@ -48,6 +56,8 @@ Fixes #{issue_number}
48
56
-[ ] Run `python update_helptext.py` in case there are API changes
49
57
-[ ] Checked that all unit tests pass
50
58
59
+
60
+
51
61
### Workflow
52
62
53
63
> Please avoid rebasing and force-pushing to the branch of the PR once a review is in progress.
0 commit comments